From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D37EC76186 for ; Wed, 24 Jul 2019 19:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D81BB22ADC for ; Wed, 24 Jul 2019 19:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563998249; bh=gJLQAtZw1C/+PfpyYuzgkc+A8g7f3VcKj88GMkkkEdY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1jbtYPmxbzcdcYpkWevqDMN9LGMqSKOSxno4t1p5bJ2V2hRdcxsA2EmNFaXhqPIzk DpEU9z2f//D0GL1J4n9jdavXpUqGkSUBpj+eVg36mLK718+Aj85eO94QG/6mYeSaAP EMVR1eUsDSE8IBpZbfyyVw3UeP8ooqgL+u0ZHFiw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391962AbfGXT51 (ORCPT ); Wed, 24 Jul 2019 15:57:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:42726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391917AbfGXT5Z (ORCPT ); Wed, 24 Jul 2019 15:57:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B87922ADC; Wed, 24 Jul 2019 19:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563998244; bh=gJLQAtZw1C/+PfpyYuzgkc+A8g7f3VcKj88GMkkkEdY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yUEnbyFpBEVClEfH1gKgup+q7u8mcXDXCGqjl2sAZTqFvvb0rcK0IIkhfjxOFY9L/ cTfUUDR/eEnhObYUKYjE8ejQ4FJr+he+p3UUUU/KPjnSBI14ec2sgnIXpjreMI3LIp Dn3xOT8Zj4PEitAenRrSdJajs4/Lo00OIVbpwnAk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Zabel , Ezequiel Garcia , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 5.1 295/371] media: coda: Remove unbalanced and unneeded mutex unlock Date: Wed, 24 Jul 2019 21:20:47 +0200 Message-Id: <20190724191746.543515467@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191724.382593077@linuxfoundation.org> References: <20190724191724.382593077@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ezequiel Garcia commit 766b9b168f6c75c350dd87c3e0bc6a9b322f0013 upstream. The mutex unlock in the threaded interrupt handler is not paired with any mutex lock. Remove it. This bug has been here for a really long time, so it applies to any stable repo. Reviewed-by: Philipp Zabel Signed-off-by: Ezequiel Garcia Signed-off-by: Hans Verkuil Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/coda/coda-bit.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -2314,7 +2314,6 @@ irqreturn_t coda_irq_handler(int irq, vo if (ctx == NULL) { v4l2_err(&dev->v4l2_dev, "Instance released before the end of transaction\n"); - mutex_unlock(&dev->coda_mutex); return IRQ_HANDLED; }