From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 7/3] xfs/194: unmount forced v4 fs during cleanup
Date: Thu, 25 Jul 2019 09:22:59 +1000 [thread overview]
Message-ID: <20190724232259.GC7777@dread.disaster.area> (raw)
In-Reply-To: <20190724155656.GH7084@magnolia>
On Wed, Jul 24, 2019 at 08:56:56AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Unmount the V4 filesystem we forcibly created to run this test during
> test cleanup so that the post-test wrapup checks won't try to remount
> the filesystem with different MOUNT_OPTIONS (specifically, the ones
> that get screened out by _force_xfsv4_mount_options) and fail.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/194 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/194 b/tests/xfs/194
> index 3e186528..1f46d403 100755
> --- a/tests/xfs/194
> +++ b/tests/xfs/194
> @@ -18,6 +18,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> _cleanup()
> {
> cd /
> + _scratch_unmount
Comment as to why this is necessary here so we don't go and remove
it because unmounting in cleanup should generally be unnecessary....
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-07-24 23:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:12 [PATCH 0/3] fstests: various fixes Darrick J. Wong
2019-07-24 4:12 ` [PATCH 1/3] common: filter aiodio dmesg after fs/iomap.c to fs/iomap/ move Darrick J. Wong
2019-07-24 23:21 ` Dave Chinner
2019-07-25 18:02 ` Darrick J. Wong
2019-07-25 18:03 ` [PATCH v2 " Darrick J. Wong
2019-07-28 11:30 ` Eryu Guan
2019-07-30 0:55 ` Darrick J. Wong
2019-08-07 1:44 ` Darrick J. Wong
2019-08-11 15:25 ` Eryu Guan
2019-07-24 4:13 ` [PATCH 2/3] xfs/504: fix bogus test description Darrick J. Wong
2019-07-24 4:13 ` [PATCH 3/3] generic/561: kill duperemove after sleep_time Darrick J. Wong
2019-07-24 15:55 ` [PATCH 4/3] generic/506: mount scratch fs before testing for prjquota presence Darrick J. Wong
2019-07-24 15:56 ` [PATCH 5/3] various: disable quotas before running test Darrick J. Wong
2019-07-24 15:56 ` [PATCH 6/3] xfs/033: filter out root inode nlink repair Darrick J. Wong
2019-07-24 15:56 ` [PATCH 7/3] xfs/194: unmount forced v4 fs during cleanup Darrick J. Wong
2019-07-24 23:22 ` Dave Chinner [this message]
2019-07-25 18:03 ` Darrick J. Wong
2019-07-25 18:04 ` [PATCH v2 " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724232259.GC7777@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.