Re: [Xen-devel] [PATCH 5/6] domain: remove the 'is_xenstore' flag

["Roger Pau Monné" <roger.pau@citrix.com>]

On Tue, Jul 23, 2019 at 05:06:08PM +0100, Paul Durrant wrote:
> This patch introduces a convenience macro, is_xenstore_domain(), which
> tests the domain 'createflags' directly and then uses that in place of
> the 'is_xenstore' flag.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Just one request below (which is not related to your code actually).

> ---
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <George.Dunlap@eu.citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Tim Deegan <tim@xen.org>
> Cc: Wei Liu <wl@xen.org>
> Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> ---
>  xen/common/domain.c     | 5 +----
>  xen/common/domctl.c     | 2 +-
>  xen/include/xen/sched.h | 7 +++++--
>  xen/include/xsm/dummy.h | 2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 6f405d2541..5703da357f 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -429,11 +429,8 @@ struct domain *domain_create(domid_t domid,
>          watchdog_domain_init(d);
>          init_status |= INIT_watchdog;
>  
> -        if ( d->createflags & XEN_DOMCTL_CDF_xs_domain )
> -        {
> -            d->is_xenstore = 1;
> +        if ( is_xenstore_domain(d) )
>              d->disable_migrate = 1;

While here can you also fix this line to use true instead of 1?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel