From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E818C7618B for ; Thu, 25 Jul 2019 13:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 031872190F for ; Thu, 25 Jul 2019 13:36:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="OOMNvaxn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388647AbfGYNgQ (ORCPT ); Thu, 25 Jul 2019 09:36:16 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:34752 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388380AbfGYNgQ (ORCPT ); Thu, 25 Jul 2019 09:36:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4VXwvzkEj9NF1gRnbsRNQSHO8CIYBoFwOxJC55LwU9g=; b=OOMNvaxn2yOarMXVC7lVByXPs PnP9viWt6p1OTkUWe6RCXklHR1dHERQQl3DiSSpWMkLI1R27A/lfX1EpA52Oyc4ZWCKGRbEjAAE+J MoMSrDnBNusgkkafSqpd5rARfTxURb4zl+gIVjAmsEANW/slBvEcF7M8HHEw0hi1Q7CbFe2QzoLcp wSvKccHXjLGDqWjoQVDqs/7kQQfG9jmQ8ED+pF2abq5T6iEmA7syIIJTJg+6gfgJiOwxd9tZlY/Bm LsnCfCB7mLpGmffEV0tibvESx7/MJ5PE7X4k8KLWkVGz5SgR87WAgv6sYs2NPamuoW0WJUWE7H9Oz ZMPqjY+Wg==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:37040) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hqduf-0000OB-Aa; Thu, 25 Jul 2019 14:36:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1hqdua-0005fG-ET; Thu, 25 Jul 2019 14:36:00 +0100 Date: Thu, 25 Jul 2019 14:36:00 +0100 From: Russell King - ARM Linux admin To: Parshuram Raju Thombare Cc: Andrew Lunn , "nicolas.ferre@microchip.com" , "davem@davemloft.net" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "hkallweit1@gmail.com" , "linux-kernel@vger.kernel.org" , Rafal Ciepiela , Piotr Sroka , Anil Joy Varughese , Arthur Marris , Steven Ho , Milind Parab Subject: Re: [PATCH v6 0/5] net: macb: cover letter Message-ID: <20190725133559.GI1330@shell.armlinux.org.uk> References: <1562769391-31803-1-git-send-email-pthombar@cadence.com> <20190718151310.GE25635@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2019 at 01:27:58PM +0000, Parshuram Raju Thombare wrote: > Hi Andrew, > > >One thing which was never clear is how you are testing the features you are > >adding. Please could you describe your test setup and how each new feature > >is tested using that hardware. I'm particularly interested in what C45 device > >are you using? But i expect Russell would like to know more about SFP > >modules you are using. Do you have any which require 1000BaseX, > >2500BaseX, or provide copper 1G? > > Sorry for late reply. > Here is a little more information on our setup used for testing C45 patch with a view to > try clarify a few points. > Regarding the MDIO communication channel that our controller supports - We have tested > MDIO transfers through Clause 22, but none of our local PHY's support Clause 45 so our hardware > team have created an example Clause 45 slave device for us to add support to the driver. > Note our hardware has been in silicon for 20 years, with customers using their own software to support > MDIO (both clause 22 and clause 45 functionality) and so this has been in Cadence's hardware controller > many times. > The programming interface is not hugely different between the two clauses and therefore we feel the risk is low. > > For other features like SGMII, USXGMII we are using kc705 and vcu118 FPGA boards. > 10G SFP+ module from Tyco electronics is used for testing 10G USXGMII in fixed AN mode. SFP and SFP+ modules take SGMII, 1000BASE-X, possibly 2500BASE-X and 10GBASE-R all over a single serdes lane. USXGMII might be used from the MAC to some sort of PHY which then converts to 10GBASE-R. If you have a PHY present, then using phylink and trying to link the MAC directly with the SFP cage in software is the _wrong approach_. I've stated this several times. I'm getting to the point of asking you not to persist with your use of phylink with your driver - I do not believe that your hardware has any justification for its use, and I also believe that your use of phylink is positively hurtful to the long term maintenance of phylink itself. In other words, you persisting to (ab)use phylink _hurts_ our ability to maintain it into the future. I'm also at the point where I'm giving up reviewing your patches - you don't seem to take the issues I raise on board at all, so I feel like I'm completely wasting my time trying to get you to make improvements. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up