Re: [PATCH v3 3/3] media: uapi: h264: Get rid of the p0/b0/b1 ref-lists

From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Tomasz Figa <tfiga@chromium.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@iki.fi>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Nicolas Dufresne <nicolas@ndufresne.ca>,
	kernel@collabora.com, Maxime Ripard <maxime.ripard@bootlin.com>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Alexandre Courbot <acourbot@chromium.org>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v3 3/3] media: uapi: h264: Get rid of the p0/b0/b1 ref-lists
Date: Thu, 25 Jul 2019 21:38:06 +0200	[thread overview]
Message-ID: <20190725193806.GE14499@aptenodytes> (raw)
In-Reply-To: <20190724074624.508388aa@collabora.com>

Hi,

On Wed 24 Jul 19, 07:46, Boris Brezillon wrote:
> On Wed, 24 Jul 2019 12:39:55 +0900
> Tomasz Figa <tfiga@chromium.org> wrote:
> 
> > Hi Boris,
> > 
> > On Wed, Jul 3, 2019 at 9:28 PM Boris Brezillon
> > <boris.brezillon@collabora.com> wrote:
> > >
> > > Those lists can be extracted from the dpb, let's simplify userspace
> > > life and build that list kernel-side (generic helpers will be provided
> > > for drivers that need this list).
> > >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > ---
> > > Changes in v3:
> > > * None
> > >
> > > Changes in v2:
> > > * None
> > > ---
> > >  Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 9 ---------
> > >  1 file changed, 9 deletions(-)
> > >
> > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> > > index 47ba2d057a92..237c8e8e6bca 100644
> > > --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> > > +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> > > @@ -1946,15 +1946,6 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
> > >      * - __u16
> > >        - ``nal_ref_idc``
> > >        - NAL reference ID value coming from the NAL Unit header
> > > -    * - __u8
> > > -      - ``ref_pic_list_p0[32]``
> > > -      - Backward reference list used by P-frames in the original bitstream order
> > > -    * - __u8
> > > -      - ``ref_pic_list_b0[32]``
> > > -      - Backward reference list used by B-frames in the original bitstream order
> > > -    * - __u8
> > > -      - ``ref_pic_list_b1[32]``
> > > -      - Forward reference list used by B-frames in the original bitstream order
> > >      * - __s32
> > >        - ``top_field_order_cnt``
> > >        - Picture Order Count for the coded top field  
> > 
> > Thanks for the patch.
> > 
> > Don't we also need to remove these fields from the UAPI structs?
> 
> Oops, indeed. I'll drop them in the next version.

With that change, feel free to add my:
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers and thanks!

Paul

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com