From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B261C7618F for ; Fri, 26 Jul 2019 21:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46C5222BE8 for ; Fri, 26 Jul 2019 21:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728310AbfGZVLu (ORCPT ); Fri, 26 Jul 2019 17:11:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55158 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfGZVLu (ORCPT ); Fri, 26 Jul 2019 17:11:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CD9B312B88C13; Fri, 26 Jul 2019 14:11:49 -0700 (PDT) Date: Fri, 26 Jul 2019 14:11:49 -0700 (PDT) Message-Id: <20190726.141149.2082260287271973845.davem@davemloft.net> To: claudiu.manoil@nxp.com Cc: alexandre.belloni@bootlin.com, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net] ocelot: Cancel delayed work before wq destruction From: David Miller In-Reply-To: <1564061598-4440-1-git-send-email-claudiu.manoil@nxp.com> References: <1564061598-4440-1-git-send-email-claudiu.manoil@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 26 Jul 2019 14:11:50 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Claudiu Manoil Date: Thu, 25 Jul 2019 16:33:18 +0300 > Make sure the delayed work for stats update is not pending before > wq destruction. > This fixes the module unload path. > The issue is there since day 1. > > Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") > > Signed-off-by: Claudiu Manoil Applied, thanks.