From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC08C7618B for ; Fri, 26 Jul 2019 13:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 164B522CE8 for ; Fri, 26 Jul 2019 13:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388506AbfGZNrY (ORCPT ); Fri, 26 Jul 2019 09:47:24 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42214 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388487AbfGZNrX (ORCPT ); Fri, 26 Jul 2019 09:47:23 -0400 Received: by mail-qt1-f193.google.com with SMTP id h18so52620608qtm.9 for ; Fri, 26 Jul 2019 06:47:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aREd7oX/KjjR1y+/DoK7i/ri4F4zE0JK5o/p5Emjkas=; b=TtHmj1/8/3N621Cn5GzIlz7UxIWVhN/xzV9TP+dnZoUB/wVZHdr6dYG9Lu5yvRBD0D 1KXdV7ZT9sueIExiStzsRq/GHeGV64SqlIPaD5p9RFbIeXj0TCkHfh5H2PShPrj2BGq0 Xm2Qnb9gLCjy+978ZEMb0z6t//0QobCDETcHdECziIL95s2KuZ+arM6ZnsRBhpFZVVpt +ehYj703JQjA2WTaakZgJKrYH5VzHTewXjE6Ave5x0a4aThwXE3l9JSqAgm7SHUdhfvA JEXRQfWepUN4vmZ4zWzb4HxZPkQCTUiY/zs3bGe3EtNGCJiE1vvcTaPhHqHyzvMBx76b CAwA== X-Gm-Message-State: APjAAAUi/pBwQ9U15LnQrGegwyU+Bt4RmB582Qb8ADrO58IFVAkEuVb7 dop6iCYYI8KU88+OeAGle7vc5g== X-Google-Smtp-Source: APXvYqzVdYsizVTGT9hdpWznFaUhHBwNJSFBNQoI8apQUSuT6ROsP77q6nipE0mfzkXGrjdjl9uw3A== X-Received: by 2002:a0c:ba0b:: with SMTP id w11mr68077058qvf.71.1564148842235; Fri, 26 Jul 2019 06:47:22 -0700 (PDT) Received: from redhat.com ([212.92.104.165]) by smtp.gmail.com with ESMTPSA id g2sm21326394qkm.31.2019.07.26.06.47.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 06:47:21 -0700 (PDT) Date: Fri, 26 Jul 2019 09:47:12 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: syzbot , aarcange@redhat.com, akpm@linux-foundation.org, christian@brauner.io, davem@davemloft.net, ebiederm@xmission.com, elena.reshetova@intel.com, guro@fb.com, hch@infradead.org, james.bottomley@hansenpartnership.com, jglisse@redhat.com, keescook@chromium.org, ldv@altlinux.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, luto@amacapital.net, mhocko@suse.com, mingo@kernel.org, namit@vmware.com, peterz@infradead.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, wad@chromium.org Subject: Re: WARNING in __mmdrop Message-ID: <20190726094353-mutt-send-email-mst@kernel.org> References: <20190725012149-mutt-send-email-mst@kernel.org> <55e8930c-2695-365f-a07b-3ad169654d28@redhat.com> <20190725042651-mutt-send-email-mst@kernel.org> <84bb2e31-0606-adff-cf2a-e1878225a847@redhat.com> <20190725092332-mutt-send-email-mst@kernel.org> <11802a8a-ce41-f427-63d5-b6a4cf96bb3f@redhat.com> <20190726074644-mutt-send-email-mst@kernel.org> <5cc94f15-b229-a290-55f3-8295266edb2b@redhat.com> <20190726082837-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Fri, Jul 26, 2019 at 08:53:18PM +0800, Jason Wang wrote: > > On 2019/7/26 下午8:38, Michael S. Tsirkin wrote: > > On Fri, Jul 26, 2019 at 08:00:58PM +0800, Jason Wang wrote: > > > On 2019/7/26 下午7:49, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2019 at 10:25:25PM +0800, Jason Wang wrote: > > > > > On 2019/7/25 下午9:26, Michael S. Tsirkin wrote: > > > > > > > Exactly, and that's the reason actually I use synchronize_rcu() there. > > > > > > > > > > > > > > So the concern is still the possible synchronize_expedited()? > > > > > > I think synchronize_srcu_expedited. > > > > > > > > > > > > synchronize_expedited sends lots of IPI and is bad for realtime VMs. > > > > > > > > > > > > > Can I do this > > > > > > > on through another series on top of the incoming V2? > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > The question is this: is this still a gain if we switch to the > > > > > > more expensive srcu? If yes then we can keep the feature on, > > > > > I think we only care about the cost on srcu_read_lock() which looks pretty > > > > > tiny form my point of view. Which is basically a READ_ONCE() + WRITE_ONCE(). > > > > > > > > > > Of course I can benchmark to see the difference. > > > > > > > > > > > > > > > > if not we'll put it off until next release and think > > > > > > of better solutions. rcu->srcu is just a find and replace, > > > > > > don't see why we need to defer that. can be a separate patch > > > > > > for sure, but we need to know how well it works. > > > > > I think I get here, let me try to do that in V2 and let's see the numbers. > > > > > > > > > > Thanks > > > > > > It looks to me for tree rcu, its srcu_read_lock() have a mb() which is too > > > expensive for us. > > I will try to ponder using vq lock in some way. > > Maybe with trylock somehow ... > > > Ok, let me retry if necessary (but I do remember I end up with deadlocks > last try). > > > > > > > > > If we just worry about the IPI, > > With synchronize_rcu what I would worry about is that guest is stalled > > > Can this synchronize_rcu() be triggered by guest? If yes, there are several > other MMU notifiers that can block. Is vhost something special here? Sorry, let me explain: guests (and tasks in general) can trigger activity that will make synchronize_rcu take a long time. Thus blocking an mmu notifier until synchronize_rcu finishes is a bad idea. > > > because system is busy because of other guests. > > With expedited it's the IPIs... > > > > The current synchronize_rcu()  can force a expedited grace period: > > void synchronize_rcu(void) > { >         ... >         if (rcu_blocking_is_gp()) > return; >         if (rcu_gp_is_expedited()) > synchronize_rcu_expedited(); > else > wait_rcu_gp(call_rcu); > } > EXPORT_SYMBOL_GPL(synchronize_rcu); An admin can force rcu to finish faster, trading interrupts for responsiveness. > > > > can we do something like in > > > vhost_invalidate_vq_start()? > > > > > >         if (map) { > > >                 /* In order to avoid possible IPIs with > > >                  * synchronize_rcu_expedited() we use call_rcu() + > > >                  * completion. > > > */ > > > init_completion(&c.completion); > > >                 call_rcu(&c.rcu_head, vhost_finish_vq_invalidation); > > > wait_for_completion(&c.completion); > > >                 vhost_set_map_dirty(vq, map, index); > > > vhost_map_unprefetch(map); > > >         } > > > > > > ? > > Why would that be faster than synchronize_rcu? > > > No faster but no IPI. > Sorry I still don't see the point. synchronize_rcu doesn't normally do an IPI either. > > > > > > > > There's one other thing that bothers me, and that is that > > > > for large rings which are not physically contiguous > > > > we don't implement the optimization. > > > > > > > > For sure, that can wait, but I think eventually we should > > > > vmap large rings. > > > > > > Yes, worth to try. But using direct map has its own advantage: it can use > > > hugepage that vmap can't > > > > > > Thanks > > Sure, so we can do that for small rings. > > > Yes, that's possible but should be done on top. > > Thanks Absolutely. Need to fix up the bugs first. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A672C41517 for ; Fri, 26 Jul 2019 13:48:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F30FC22CE5 for ; Fri, 26 Jul 2019 13:48:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="COAhrLd1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F30FC22CE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=crb19G/oWJMJKpHip9luhbHJ6VkcR/TI4VnBKbH97cw=; b=COAhrLd1rVix3C sIvzfr/pItJ6Tjq+h0z/egv2UQFFuNRp9YmKTx8UPNReD/EeJ0e0yKoOZlDn4Ot5QHl5v8SgRn9K8 gyZfng4nFfGis5HHamH7um7XaUyOh8jHXHZ9z+ZKMNEjOIS/b7oY4obfu7rid/PNhvXBTk/SDOUhj UGQJCe0kyNDusVgEIoKOEJuR4iXTvnpvinZ0HqwdIZka957yKA41QpvQU1jWYTvjxZTC1853LYGJB L6VojBk9tvgGGSpjFCaKhHy3WX/FdH2q+JgBr2vio1BBL70GtKh1qX5nYfn+LwOZ1NmHfHIkfE18m LIR0mL3us4U5/SBiEm0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hr0Zz-0005BB-Dh; Fri, 26 Jul 2019 13:48:15 +0000 Received: from mail-qt1-f194.google.com ([209.85.160.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hr0Z9-0004RM-F3 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 13:47:25 +0000 Received: by mail-qt1-f194.google.com with SMTP id d23so52658211qto.2 for ; Fri, 26 Jul 2019 06:47:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aREd7oX/KjjR1y+/DoK7i/ri4F4zE0JK5o/p5Emjkas=; b=IwfjDy5EzRkyi/tUmLsS/mKgamwtcQs3Cwi6UNliEtwKG4oFzxk3cv8o+MJtJqFzPC CK1fisKKn2K2Hh8ehwXVfc2jM3krGy89ijeWnwf61Ww1XjON3d8Y3lLqCT/pbIf9LUhG CxxseLzVHtpKXhmIsHNohamExRthKpLe73QPGuqIJYI9hdq2oz+HG9rgnj8z2c/wajq0 dyheaJbv8KBqO7+xTJfnZM8jRq248sMfnlI5S9++BKC5g3Rzlz5geY76TQCb5JK+guz6 pVUf9+WPAG84/0bL26qKfye/rFiXmgGcu2r6AfSVxQlwa0Y48ppmzMiWqC2AWd8bXrFN 2fYw== X-Gm-Message-State: APjAAAXGmdQuKUBQBUPYO8k8SYvJx8Vl9bY1VIsgCI3ehWREScbcNvfO 0N2CV9t3gYlZ5PmR92ryn8biGA== X-Google-Smtp-Source: APXvYqzVdYsizVTGT9hdpWznFaUhHBwNJSFBNQoI8apQUSuT6ROsP77q6nipE0mfzkXGrjdjl9uw3A== X-Received: by 2002:a0c:ba0b:: with SMTP id w11mr68077058qvf.71.1564148842235; Fri, 26 Jul 2019 06:47:22 -0700 (PDT) Received: from redhat.com ([212.92.104.165]) by smtp.gmail.com with ESMTPSA id g2sm21326394qkm.31.2019.07.26.06.47.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 06:47:21 -0700 (PDT) Date: Fri, 26 Jul 2019 09:47:12 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: WARNING in __mmdrop Message-ID: <20190726094353-mutt-send-email-mst@kernel.org> References: <20190725012149-mutt-send-email-mst@kernel.org> <55e8930c-2695-365f-a07b-3ad169654d28@redhat.com> <20190725042651-mutt-send-email-mst@kernel.org> <84bb2e31-0606-adff-cf2a-e1878225a847@redhat.com> <20190725092332-mutt-send-email-mst@kernel.org> <11802a8a-ce41-f427-63d5-b6a4cf96bb3f@redhat.com> <20190726074644-mutt-send-email-mst@kernel.org> <5cc94f15-b229-a290-55f3-8295266edb2b@redhat.com> <20190726082837-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_064723_623304_7A14A803 X-CRM114-Status: GOOD ( 28.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mhocko@suse.com, peterz@infradead.org, ldv@altlinux.org, james.bottomley@hansenpartnership.com, linux-mm@kvack.org, namit@vmware.com, mingo@kernel.org, elena.reshetova@intel.com, keescook@chromium.org, aarcange@redhat.com, davem@davemloft.net, hch@infradead.org, christian@brauner.io, syzbot , syzkaller-bugs@googlegroups.com, jglisse@redhat.com, viro@zeniv.linux.org.uk, linux-arm-kernel@lists.infradead.org, wad@chromium.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, ebiederm@xmission.com, akpm@linux-foundation.org, guro@fb.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdWwgMjYsIDIwMTkgYXQgMDg6NTM6MThQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE5LzcvMjYg5LiL5Y2IODozOCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+ID4gT24gRnJpLCBKdWwgMjYsIDIwMTkgYXQgMDg6MDA6NThQTSArMDgwMCwgSmFzb24gV2Fu ZyB3cm90ZToKPiA+ID4gT24gMjAxOS83LzI2IOS4i+WNiDc6NDksIE1pY2hhZWwgUy4gVHNpcmtp biB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIEp1bCAyNSwgMjAxOSBhdCAxMDoyNToyNVBNICswODAw LCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPiA+ID4gT24gMjAxOS83LzI1IOS4i+WNiDk6MjYsIE1p Y2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiA+ID4gPiA+ID4gPiBFeGFjdGx5LCBhbmQgdGhhdCdz IHRoZSByZWFzb24gYWN0dWFsbHkgSSB1c2Ugc3luY2hyb25pemVfcmN1KCkgdGhlcmUuCj4gPiA+ ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gU28gdGhlIGNvbmNlcm4gaXMgc3RpbGwgdGhlIHBvc3Np YmxlIHN5bmNocm9uaXplX2V4cGVkaXRlZCgpPwo+ID4gPiA+ID4gPiBJIHRoaW5rIHN5bmNocm9u aXplX3NyY3VfZXhwZWRpdGVkLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gc3luY2hyb25pemVf ZXhwZWRpdGVkIHNlbmRzIGxvdHMgb2YgSVBJIGFuZCBpcyBiYWQgZm9yIHJlYWx0aW1lIFZNcy4K PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gQ2FuIEkgZG8gdGhpcwo+ID4gPiA+ID4gPiA+IG9u IHRocm91Z2ggYW5vdGhlciBzZXJpZXMgb24gdG9wIG9mIHRoZSBpbmNvbWluZyBWMj8KPiA+ID4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBUaGFua3MKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g VGhlIHF1ZXN0aW9uIGlzIHRoaXM6IGlzIHRoaXMgc3RpbGwgYSBnYWluIGlmIHdlIHN3aXRjaCB0 byB0aGUKPiA+ID4gPiA+ID4gbW9yZSBleHBlbnNpdmUgc3JjdT8gSWYgeWVzIHRoZW4gd2UgY2Fu IGtlZXAgdGhlIGZlYXR1cmUgb24sCj4gPiA+ID4gPiBJIHRoaW5rIHdlIG9ubHkgY2FyZSBhYm91 dCB0aGUgY29zdCBvbiBzcmN1X3JlYWRfbG9jaygpIHdoaWNoIGxvb2tzIHByZXR0eQo+ID4gPiA+ ID4gdGlueSBmb3JtIG15IHBvaW50IG9mIHZpZXcuIFdoaWNoIGlzIGJhc2ljYWxseSBhIFJFQURf T05DRSgpICsgV1JJVEVfT05DRSgpLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBPZiBjb3Vyc2UgSSBj YW4gYmVuY2htYXJrIHRvIHNlZSB0aGUgZGlmZmVyZW5jZS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+IGlmIG5vdCB3ZSdsbCBwdXQgaXQgb2ZmIHVudGlsIG5leHQgcmVsZWFzZSBh bmQgdGhpbmsKPiA+ID4gPiA+ID4gb2YgYmV0dGVyIHNvbHV0aW9ucy4gcmN1LT5zcmN1IGlzIGp1 c3QgYSBmaW5kIGFuZCByZXBsYWNlLAo+ID4gPiA+ID4gPiBkb24ndCBzZWUgd2h5IHdlIG5lZWQg dG8gZGVmZXIgdGhhdC4gY2FuIGJlIGEgc2VwYXJhdGUgcGF0Y2gKPiA+ID4gPiA+ID4gZm9yIHN1 cmUsIGJ1dCB3ZSBuZWVkIHRvIGtub3cgaG93IHdlbGwgaXQgd29ya3MuCj4gPiA+ID4gPiBJIHRo aW5rIEkgZ2V0IGhlcmUsIGxldCBtZSB0cnkgdG8gZG8gdGhhdCBpbiBWMiBhbmQgbGV0J3Mgc2Vl IHRoZSBudW1iZXJzLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGFua3MKPiA+ID4gCj4gPiA+IEl0 IGxvb2tzIHRvIG1lIGZvciB0cmVlIHJjdSwgaXRzIHNyY3VfcmVhZF9sb2NrKCkgaGF2ZSBhIG1i KCkgd2hpY2ggaXMgdG9vCj4gPiA+IGV4cGVuc2l2ZSBmb3IgdXMuCj4gPiBJIHdpbGwgdHJ5IHRv IHBvbmRlciB1c2luZyB2cSBsb2NrIGluIHNvbWUgd2F5Lgo+ID4gTWF5YmUgd2l0aCB0cnlsb2Nr IHNvbWVob3cgLi4uCj4gCj4gCj4gT2ssIGxldCBtZSByZXRyeSBpZiBuZWNlc3NhcnkgKGJ1dCBJ IGRvIHJlbWVtYmVyIEkgZW5kIHVwIHdpdGggZGVhZGxvY2tzCj4gbGFzdCB0cnkpLgo+IAo+IAo+ ID4gCj4gPiAKPiA+ID4gSWYgd2UganVzdCB3b3JyeSBhYm91dCB0aGUgSVBJLAo+ID4gV2l0aCBz eW5jaHJvbml6ZV9yY3Ugd2hhdCBJIHdvdWxkIHdvcnJ5IGFib3V0IGlzIHRoYXQgZ3Vlc3QgaXMg c3RhbGxlZAo+IAo+IAo+IENhbiB0aGlzIHN5bmNocm9uaXplX3JjdSgpIGJlIHRyaWdnZXJlZCBi eSBndWVzdD8gSWYgeWVzLCB0aGVyZSBhcmUgc2V2ZXJhbAo+IG90aGVyIE1NVSBub3RpZmllcnMg dGhhdCBjYW4gYmxvY2suIElzIHZob3N0IHNvbWV0aGluZyBzcGVjaWFsIGhlcmU/CgpTb3JyeSwg bGV0IG1lIGV4cGxhaW46IGd1ZXN0cyAoYW5kIHRhc2tzIGluIGdlbmVyYWwpCmNhbiB0cmlnZ2Vy IGFjdGl2aXR5IHRoYXQgd2lsbAptYWtlIHN5bmNocm9uaXplX3JjdSB0YWtlIGEgbG9uZyB0aW1l LiBUaHVzIGJsb2NraW5nCmFuIG1tdSBub3RpZmllciB1bnRpbCBzeW5jaHJvbml6ZV9yY3UgZmlu aXNoZXMKaXMgYSBiYWQgaWRlYS4KCj4gCj4gPiBiZWNhdXNlIHN5c3RlbSBpcyBidXN5IGJlY2F1 c2Ugb2Ygb3RoZXIgZ3Vlc3RzLgo+ID4gV2l0aCBleHBlZGl0ZWQgaXQncyB0aGUgSVBJcy4uLgo+ ID4gCj4gCj4gVGhlIGN1cnJlbnQgc3luY2hyb25pemVfcmN1KCnCoCBjYW4gZm9yY2UgYSBleHBl ZGl0ZWQgZ3JhY2UgcGVyaW9kOgo+IAo+IHZvaWQgc3luY2hyb25pemVfcmN1KHZvaWQpCj4gewo+ IMKgwqDCoCDCoMKgwqAgLi4uCj4gwqDCoMKgwqDCoMKgwqAgaWYgKHJjdV9ibG9ja2luZ19pc19n cCgpKQo+IHJldHVybjsKPiDCoMKgwqDCoMKgwqDCoCBpZiAocmN1X2dwX2lzX2V4cGVkaXRlZCgp KQo+IHN5bmNocm9uaXplX3JjdV9leHBlZGl0ZWQoKTsKPiBlbHNlCj4gd2FpdF9yY3VfZ3AoY2Fs bF9yY3UpOwo+IH0KPiBFWFBPUlRfU1lNQk9MX0dQTChzeW5jaHJvbml6ZV9yY3UpOwoKCkFuIGFk bWluIGNhbiBmb3JjZSByY3UgdG8gZmluaXNoIGZhc3RlciwgdHJhZGluZwppbnRlcnJ1cHRzIGZv ciByZXNwb25zaXZlbmVzcy4KCj4gCj4gPiA+IGNhbiB3ZSBkbyBzb21ldGhpbmcgbGlrZSBpbgo+ ID4gPiB2aG9zdF9pbnZhbGlkYXRlX3ZxX3N0YXJ0KCk/Cj4gPiA+IAo+ID4gPiAgwqDCoMKgwqDC oMKgwqAgaWYgKG1hcCkgewo+ID4gPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8q IEluIG9yZGVyIHRvIGF2b2lkIHBvc3NpYmxlIElQSXMgd2l0aAo+ID4gPiAgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBzeW5jaHJvbml6ZV9yY3VfZXhwZWRpdGVkKCkgd2UgdXNl IGNhbGxfcmN1KCkgKwo+ID4gPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBj b21wbGV0aW9uLgo+ID4gPiAqLwo+ID4gPiBpbml0X2NvbXBsZXRpb24oJmMuY29tcGxldGlvbik7 Cj4gPiA+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2FsbF9yY3UoJmMucmN1X2hl YWQsIHZob3N0X2ZpbmlzaF92cV9pbnZhbGlkYXRpb24pOwo+ID4gPiB3YWl0X2Zvcl9jb21wbGV0 aW9uKCZjLmNvbXBsZXRpb24pOwo+ID4gPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHZob3N0X3NldF9tYXBfZGlydHkodnEsIG1hcCwgaW5kZXgpOwo+ID4gPiB2aG9zdF9tYXBfdW5w cmVmZXRjaChtYXApOwo+ID4gPiAgwqDCoMKgwqDCoMKgwqAgfQo+ID4gPiAKPiA+ID4gPwo+ID4g V2h5IHdvdWxkIHRoYXQgYmUgZmFzdGVyIHRoYW4gc3luY2hyb25pemVfcmN1Pwo+IAo+IAo+IE5v IGZhc3RlciBidXQgbm8gSVBJLgo+IAoKU29ycnkgSSBzdGlsbCBkb24ndCBzZWUgdGhlIHBvaW50 LgpzeW5jaHJvbml6ZV9yY3UgZG9lc24ndCBub3JtYWxseSBkbyBhbiBJUEkgZWl0aGVyLgoKCj4g PiAKPiA+IAo+ID4gPiA+IFRoZXJlJ3Mgb25lIG90aGVyIHRoaW5nIHRoYXQgYm90aGVycyBtZSwg YW5kIHRoYXQgaXMgdGhhdAo+ID4gPiA+IGZvciBsYXJnZSByaW5ncyB3aGljaCBhcmUgbm90IHBo eXNpY2FsbHkgY29udGlndW91cwo+ID4gPiA+IHdlIGRvbid0IGltcGxlbWVudCB0aGUgb3B0aW1p emF0aW9uLgo+ID4gPiA+IAo+ID4gPiA+IEZvciBzdXJlLCB0aGF0IGNhbiB3YWl0LCBidXQgSSB0 aGluayBldmVudHVhbGx5IHdlIHNob3VsZAo+ID4gPiA+IHZtYXAgbGFyZ2UgcmluZ3MuCj4gPiA+ IAo+ID4gPiBZZXMsIHdvcnRoIHRvIHRyeS4gQnV0IHVzaW5nIGRpcmVjdCBtYXAgaGFzIGl0cyBv d24gYWR2YW50YWdlOiBpdCBjYW4gdXNlCj4gPiA+IGh1Z2VwYWdlIHRoYXQgdm1hcCBjYW4ndAo+ ID4gPiAKPiA+ID4gVGhhbmtzCj4gPiBTdXJlLCBzbyB3ZSBjYW4gZG8gdGhhdCBmb3Igc21hbGwg cmluZ3MuCj4gCj4gCj4gWWVzLCB0aGF0J3MgcG9zc2libGUgYnV0IHNob3VsZCBiZSBkb25lIG9u IHRvcC4KPiAKPiBUaGFua3MKCkFic29sdXRlbHkuIE5lZWQgdG8gZml4IHVwIHRoZSBidWdzIGZp cnN0LgoKLS0gCk1TVAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=