From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Fri, 26 Jul 2019 16:09:53 +0000 Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Message-Id: <20190726160953.GA25708@ravnborg.org> List-Id: References: <20190725143224.GB31803@ravnborg.org> <20190725143934.GH15868@phenom.ffwll.local> <20190725150629.GN23883@dell> In-Reply-To: <20190725150629.GN23883@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lee Jones Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Gerd Hoffmann , Jingoo Han , Peter Rosin Hi Lee. On Thu, Jul 25, 2019 at 04:06:29PM +0100, Lee Jones wrote: > On Thu, 25 Jul 2019, Daniel Vetter wrote: > > > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > > This patch removes the support in backlight, > > > and drop the notifier in fbmem. > > > > > > That EARLY_FB_BLANK is not used can be verified that no driver set any of: > > > > > > lcd_ops.early_set_power() > > > lcd_ops.r_early_set_power() > > > > > > Noticed while browsing backlight code for other reasons. > > > > Ah I didn't grep hard enough, I didn't realize that no one sets the > > lcd_ops->(r_)early_set_power hooks. Nice find! > > > > Reviewed-by: Daniel Vetter > > > > > Signed-off-by: Sam Ravnborg > > > Cc: Lee Jones > > > Cc: Daniel Thompson > > > Cc: Jingoo Han > > > Cc: Bartlomiej Zolnierkiewicz > > > Cc: Daniel Vetter > > > Cc: Sam Ravnborg > > > Cc: Maarten Lankhorst > > > Cc: "Michał Mirosław" > > > Cc: Peter Rosin > > > Cc: Gerd Hoffmann > > > Cc: dri-devel@lists.freedesktop.org > > > Cc: linux-fbdev@vger.kernel.org > > > --- > > > > > > Build tested with various architectures, configs. > > > > > > Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is > > > maintained today? > > > > backlight is separate from fbdev in Lee's own tree, not in drm-misc. I > > think at least. > > That's correct. We'll sort that once we have all the Acks. We have acks all around now. OK that I commit this to drm-misc-next? This is where we maintain fbdev these days. Or you could apply it to your backlight tree. Both solutins would be fine as the risk of introducing merge conflicts in these code paths are minimal. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Date: Fri, 26 Jul 2019 18:09:53 +0200 Message-ID: <20190726160953.GA25708@ravnborg.org> References: <20190725143224.GB31803@ravnborg.org> <20190725143934.GH15868@phenom.ffwll.local> <20190725150629.GN23883@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6FD06EDBE for ; Fri, 26 Jul 2019 16:09:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190725150629.GN23883@dell> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lee Jones Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Gerd Hoffmann , Jingoo Han , Peter Rosin List-Id: dri-devel@lists.freedesktop.org SGkgTGVlLgoKT24gVGh1LCBKdWwgMjUsIDIwMTkgYXQgMDQ6MDY6MjlQTSArMDEwMCwgTGVlIEpv bmVzIHdyb3RlOgo+IE9uIFRodSwgMjUgSnVsIDIwMTksIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4g Cj4gPiBPbiBUaHUsIEp1bCAyNSwgMjAxOSBhdCAwNDozMjoyNFBNICswMjAwLCBTYW0gUmF2bmJv cmcgd3JvdGU6Cj4gPiA+IFRoZXJlIHdhcyBubyB1c2VycyBsZWZ0IC0gc28gZHJvcCB0aGUgY29k ZSB0byBzdXBwb3J0IEVBUkxZX0ZCX0JMQU5LLgo+ID4gPiBUaGlzIHBhdGNoIHJlbW92ZXMgdGhl IHN1cHBvcnQgaW4gYmFja2xpZ2h0LAo+ID4gPiBhbmQgZHJvcCB0aGUgbm90aWZpZXIgaW4gZmJt ZW0uCj4gPiA+IAo+ID4gPiBUaGF0IEVBUkxZX0ZCX0JMQU5LIGlzIG5vdCB1c2VkIGNhbiBiZSB2 ZXJpZmllZCB0aGF0IG5vIGRyaXZlciBzZXQgYW55IG9mOgo+ID4gPiAKPiA+ID4gICAgIGxjZF9v cHMuZWFybHlfc2V0X3Bvd2VyKCkKPiA+ID4gICAgIGxjZF9vcHMucl9lYXJseV9zZXRfcG93ZXIo KQo+ID4gPiAKPiA+ID4gTm90aWNlZCB3aGlsZSBicm93c2luZyBiYWNrbGlnaHQgY29kZSBmb3Ig b3RoZXIgcmVhc29ucy4KPiA+IAo+ID4gQWggSSBkaWRuJ3QgZ3JlcCBoYXJkIGVub3VnaCwgSSBk aWRuJ3QgcmVhbGl6ZSB0aGF0IG5vIG9uZSBzZXRzIHRoZQo+ID4gbGNkX29wcy0+KHJfKWVhcmx5 X3NldF9wb3dlciBob29rcy4gTmljZSBmaW5kIQo+ID4gCj4gPiBSZXZpZXdlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gPiA+IENjOiBMZWUgSm9uZXMgPGxl ZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gPiBDYzogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhv bXBzb25AbGluYXJvLm9yZz4KPiA+ID4gQ2M6IEppbmdvbyBIYW4gPGppbmdvb2hhbjFAZ21haWwu Y29tPgo+ID4gPiBDYzogQmFydGxvbWllaiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVya2llQHNh bXN1bmcuY29tPgo+ID4gPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4KPiA+ID4gQ2M6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiA+ID4gQ2M6IE1h YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ IENjOiAiTWljaGHFgiBNaXJvc8WCYXciIDxtaXJxLWxpbnV4QHJlcmUucW1xbS5wbD4KPiA+ID4g Q2M6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+Cj4gPiA+IENjOiBHZXJkIEhvZmZtYW5u IDxrcmF4ZWxAcmVkaGF0LmNvbT4KPiA+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiA+ID4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+ID4gPiAtLS0KPiA+ ID4gCj4gPiA+IEJ1aWxkIHRlc3RlZCB3aXRoIHZhcmlvdXMgYXJjaGl0ZWN0dXJlcywgY29uZmln cy4KPiA+ID4gCj4gPiA+IExlZSwgRGFuaWVsIC0gT0sgdG8gY29tbWl0IHRvIGRybS1taXNjLW5l eHQgd2hlcmUgZmJkZXYgc3R1ZmYgaXMKPiA+ID4gbWFpbnRhaW5lZCB0b2RheT8KPiA+IAo+ID4g YmFja2xpZ2h0IGlzIHNlcGFyYXRlIGZyb20gZmJkZXYgaW4gTGVlJ3Mgb3duIHRyZWUsIG5vdCBp biBkcm0tbWlzYy4gSQo+ID4gdGhpbmsgYXQgbGVhc3QuCj4gCj4gVGhhdCdzIGNvcnJlY3QuICBX ZSdsbCBzb3J0IHRoYXQgb25jZSB3ZSBoYXZlIGFsbCB0aGUgQWNrcy4KCldlIGhhdmUgYWNrcyBh bGwgYXJvdW5kIG5vdy4KT0sgdGhhdCBJIGNvbW1pdCB0aGlzIHRvIGRybS1taXNjLW5leHQ/CgpU aGlzIGlzIHdoZXJlIHdlIG1haW50YWluIGZiZGV2IHRoZXNlIGRheXMuIE9yIHlvdSBjb3VsZCBh cHBseSBpdCB0bwp5b3VyIGJhY2tsaWdodCB0cmVlLgoKQm90aCBzb2x1dGlucyB3b3VsZCBiZSBm aW5lIGFzIHRoZSByaXNrIG9mIGludHJvZHVjaW5nIG1lcmdlIGNvbmZsaWN0cwppbiB0aGVzZSBj b2RlIHBhdGhzIGFyZSBtaW5pbWFsLgoKCVNhbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw=