From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v7 3/3] serial: imx: get rid of imx_uart_rts_auto() Date: Fri, 26 Jul 2019 21:29:40 +0200 Message-ID: <20190726192940.jy4frulgbetf5d2v@pengutronix.de> References: <20190614072801.3187-1-s.hauer@pengutronix.de> <1564167161-3972-1-git-send-email-sorganov@gmail.com> <1564167161-3972-4-git-send-email-sorganov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1564167161-3972-4-git-send-email-sorganov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sergey Organov Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Sascha Hauer , NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On Fri, Jul 26, 2019 at 09:52:41PM +0300, Sergey Organov wrote: > Called in only one place, for RS232, it only obscures things, as it > doesn't go well with 2 similar named functions, > imx_uart_rts_inactive() and imx_uart_rts_active(), that both are > RS485-specific. I don't share the critic. IMHO the name is fine. imx_uart_rts_inactive sets rts to its inactive level, imx_uart_rts_active() to its active level and imx_uart_rts_auto() lets the output drive automatically by the receiver. The name started to be a bit wrong in patch 1 of the series however. And I still object removing this function because with the semantic this function got in patch 1 it is suiteable to be used in imx_uart_set_mctrl(). Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA3CC7618F for ; Fri, 26 Jul 2019 19:29:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B172821880 for ; Fri, 26 Jul 2019 19:29:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g9Pazz/h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B172821880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aMiTMmtLoszMUzIXYUbuazKmcERA2hpQHtzBIB7Rkq0=; b=g9Pazz/hG4MvZH l3X4ZESZvqTqhoUwzJvz1CPOvHtinh+JyTp3pideGl3W3SxLdL3UH8zAPdlf+qkos1wxRkVb0Uo8S G/GSvNC6a6pRoFRrUN5dryVjdeJijOg6m6iLvUYyFKS0t6lXjV7DLp/lumlRJ0JbiTVvic/2hjCz+ 6FJddY54RB5g/apwbYapy+aa0Bpm/IW7tKAHXrczZozpqHu86UoeTDMf6iPXZTpuV6+85ipBEDbcX 8L1nA+csQLjoxr7IlBYbF6j6qoopyOjR+1r+YvVG8jUK1dsAwmRjexFofolnwJC4f7Eqquf57ZVOx Fi1DqGistWsAVD0SoT5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hr5uW-0004C6-8y; Fri, 26 Jul 2019 19:29:48 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hr5uS-0004Bl-SY for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 19:29:46 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hr5uP-0003Qy-W9; Fri, 26 Jul 2019 21:29:42 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hr5uO-0005ZH-Vj; Fri, 26 Jul 2019 21:29:40 +0200 Date: Fri, 26 Jul 2019 21:29:40 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Sergey Organov Subject: Re: [PATCH v7 3/3] serial: imx: get rid of imx_uart_rts_auto() Message-ID: <20190726192940.jy4frulgbetf5d2v@pengutronix.de> References: <20190614072801.3187-1-s.hauer@pengutronix.de> <1564167161-3972-1-git-send-email-sorganov@gmail.com> <1564167161-3972-4-git-send-email-sorganov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1564167161-3972-4-git-send-email-sorganov@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_122944_925829_D12B51D0 X-CRM114-Status: UNSURE ( 8.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Sascha Hauer , NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2019 at 09:52:41PM +0300, Sergey Organov wrote: > Called in only one place, for RS232, it only obscures things, as it > doesn't go well with 2 similar named functions, > imx_uart_rts_inactive() and imx_uart_rts_active(), that both are > RS485-specific. I don't share the critic. IMHO the name is fine. imx_uart_rts_inactive sets rts to its inactive level, imx_uart_rts_active() to its active level and imx_uart_rts_auto() lets the output drive automatically by the receiver. The name started to be a bit wrong in patch 1 of the series however. And I still object removing this function because with the semantic this function got in patch 1 it is suiteable to be used in imx_uart_set_mctrl(). Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel