From: Kamal Heib <kamalheib1@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Faisal Latif <faisal.latif@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>
Subject: Re: [PATCH for-next 0/3] {cxgb3, cxgb4, i40iw} Report phys_state
Date: Sun, 28 Jul 2019 12:22:53 +0300 [thread overview]
Message-ID: <20190728092253.GA5250@kheib-workstation> (raw)
In-Reply-To: <20190725184744.GC7467@ziepe.ca>
On Thu, Jul 25, 2019 at 03:47:44PM -0300, Jason Gunthorpe wrote:
> On Thu, Jul 25, 2019 at 11:37:37AM +0300, Kamal Heib wrote:
> > On Mon, Jul 22, 2019 at 10:43:27AM -0300, Jason Gunthorpe wrote:
> > > On Mon, Jul 22, 2019 at 10:05:47AM +0300, Kamal Heib wrote:
> > > > This series includes three patches that add the support for reporting
> > > > physical state for the cxgb3, cxgb4, and i40iw drivers via sysfs.
> > > >
> > > > Kamal Heib (3):
> > > > RDMA/cxgb3: Report phys_state in query_port
> > > > RDMA/cxgb4: Report phys_state in query_port
> > > > RDMA/i40iw: Report phys_state in query_port
> > > >
> > > > drivers/infiniband/hw/cxgb3/iwch_provider.c | 16 +++++++++++-----
> > > > drivers/infiniband/hw/cxgb4/provider.c | 16 +++++++++++-----
> > > > drivers/infiniband/hw/i40iw/i40iw_verbs.c | 7 +++++--
> > > > 3 files changed, 27 insertions(+), 12 deletions(-)
> > >
> > > Lets not have this generic iwapr code open coded please.
> > >
> > > The core code already knows what the netdev is for the iWarp device.
> > >
> > > Jason
> >
> > I'm not sure if I truly understand what you are trying to say here.
> >
> > Could you please add more info?
>
> Implement this in the core code if the port type is iwarp
OK, I'll give it a try.
>
> Jason
prev parent reply other threads:[~2019-07-28 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 7:05 [PATCH for-next 0/3] {cxgb3, cxgb4, i40iw} Report phys_state Kamal Heib
2019-07-22 7:05 ` [PATCH for-next 1/3] RDMA/cxgb3: Report phys_state in query_port Kamal Heib
2019-07-22 7:05 ` [PATCH for-next 2/3] RDMA/cxgb4: " Kamal Heib
2019-07-22 7:05 ` [PATCH for-next 3/3] RDMA/i40iw: " Kamal Heib
2019-07-22 13:43 ` [PATCH for-next 0/3] {cxgb3, cxgb4, i40iw} Report phys_state Jason Gunthorpe
2019-07-25 8:37 ` Kamal Heib
2019-07-25 18:47 ` Jason Gunthorpe
2019-07-28 9:22 ` Kamal Heib [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728092253.GA5250@kheib-workstation \
--to=kamalheib1@gmail.com \
--cc=bharat@chelsio.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.