From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E30C433FF for ; Mon, 29 Jul 2019 12:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8789206E0 for ; Mon, 29 Jul 2019 12:50:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbfG2MuW (ORCPT ); Mon, 29 Jul 2019 08:50:22 -0400 Received: from foss.arm.com ([217.140.110.172]:43638 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726805AbfG2MuW (ORCPT ); Mon, 29 Jul 2019 08:50:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5EA528; Mon, 29 Jul 2019 05:50:21 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3C2A43F71F; Mon, 29 Jul 2019 05:50:19 -0700 (PDT) Date: Mon, 29 Jul 2019 13:50:13 +0100 From: Mark Rutland To: Anshuman Khandual Cc: Steven Price , linux-mm@kvack.org, Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Peter Zijlstra , Thomas Gleixner , Will Deacon , x86@kernel.org, "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Liang, Kan" , Andrew Morton Subject: Re: [PATCH v9 10/21] mm: Add generic p?d_leaf() macros Message-ID: <20190729125013.GA33794@lakrids.cambridge.arm.com> References: <20190722154210.42799-1-steven.price@arm.com> <20190722154210.42799-11-steven.price@arm.com> <20190723094113.GA8085@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 28, 2019 at 05:14:31PM +0530, Anshuman Khandual wrote: > On 07/23/2019 03:11 PM, Mark Rutland wrote: > > It might also be worth pointing out the reasons for this naming, e.g. > > p?d_large() aren't currently generic, and this name minimizes potential > > confusion between p?d_{large,huge}(). > > Agreed. But these fallback also need to first check non-availability of large > pages. We're deliberately not making the p?d_large() helpers generic, so this shouldn't fall back on those. It's up to the architecture to implement these correctly, and the architecture-specific implementations will be added in subsequent patches. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 837E2C7618B for ; Mon, 29 Jul 2019 12:50:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55A4421655 for ; Mon, 29 Jul 2019 12:50:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eC4m8m+p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55A4421655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3dGcRfzZFDrmyDJvzvdvYrczlMfFUEZ39TGRdoUR4vs=; b=eC4m8m+pWvw6F4 M+BBBOrErK/aNOh39n2mMf8tvl8Gc2evKNtFoRLUGdVLOkn47LpQht4XWaMj1ZbFpSG1C7UHmr4IZ ozCoQUNZmKnxFjk9oph+y2whtYbGZ+WCQlCkNtnCOlwKoILoFO4O1yXb/kdxISumXjYtAvnAyIGut sud9EN9fmqK6fs8JIqNEiDB/EhnwvAY7LlvrBNzpoSj7X3VW+XkuR4UAwzmRpOPOOdj9zQNZOPVSO TyulI7WscCXyR11swcWlInaDzAWOLBUHkxyNDM4hEhNzb3J0YUpguychPPEDHY7GxzW0GzGPdsH3Z UC5yvU8euRZQKWFUM4JA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs56i-00037G-DW; Mon, 29 Jul 2019 12:50:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs56d-00036B-R7 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2019 12:50:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5EA528; Mon, 29 Jul 2019 05:50:21 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3C2A43F71F; Mon, 29 Jul 2019 05:50:19 -0700 (PDT) Date: Mon, 29 Jul 2019 13:50:13 +0100 From: Mark Rutland To: Anshuman Khandual Subject: Re: [PATCH v9 10/21] mm: Add generic p?d_leaf() macros Message-ID: <20190729125013.GA33794@lakrids.cambridge.arm.com> References: <20190722154210.42799-1-steven.price@arm.com> <20190722154210.42799-11-steven.price@arm.com> <20190723094113.GA8085@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_055023_922953_779CD4CF X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Arnd Bergmann , Ard Biesheuvel , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-kernel@vger.kernel.org, Steven Price , linux-mm@kvack.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, "Liang, Kan" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 28, 2019 at 05:14:31PM +0530, Anshuman Khandual wrote: > On 07/23/2019 03:11 PM, Mark Rutland wrote: > > It might also be worth pointing out the reasons for this naming, e.g. > > p?d_large() aren't currently generic, and this name minimizes potential > > confusion between p?d_{large,huge}(). > > Agreed. But these fallback also need to first check non-availability of large > pages. We're deliberately not making the p?d_large() helpers generic, so this shouldn't fall back on those. It's up to the architecture to implement these correctly, and the architecture-specific implementations will be added in subsequent patches. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel