From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: josef@toxicpanda.com
Cc: kjlu@umn.edu, smccaman@umn.edu, secalert@redhat.com,
emamd001@umn.edu, Navid Emamdoost <navid.emamdoost@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, nbd@other.debian.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] nbd_genl_status: null check for nla_nest_start
Date: Mon, 29 Jul 2019 11:42:26 -0500 [thread overview]
Message-ID: <20190729164226.22632-1-navid.emamdoost@gmail.com> (raw)
In-Reply-To: <20190729130912.7imtg3hfnvb4lt2y@MacBook-Pro-91.local>
nla_nest_start may fail and return NULL. The check is inserted, and
errno is selected based on other call sites within the same source code.
Update: removed extra new line.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/block/nbd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 9bcde2325893..2410812d1e82 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -2149,6 +2149,11 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info)
}
dev_list = nla_nest_start_noflag(reply, NBD_ATTR_DEVICE_LIST);
+ if (!dev_list) {
+ ret = -EMSGSIZE;
+ goto out;
+ }
+
if (index == -1) {
ret = idr_for_each(&nbd_index_idr, &status_cb, reply);
if (ret) {
--
2.17.1
next prev parent reply other threads:[~2019-07-29 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 23:01 [PATCH] nbd_genl_status: null check for nla_nest_start Navid Emamdoost
2019-07-29 13:09 ` Josef Bacik
2019-07-29 16:42 ` Navid Emamdoost [this message]
2019-07-30 5:52 ` [engineering.redhat.com #494735] " Red Hat Product Security
2019-07-30 6:05 ` [PATCH v2] " Bob Liu
2019-09-10 11:35 ` Michal Kubecek
2019-09-11 16:40 ` [PATCH v3] " Navid Emamdoost
2019-10-21 6:42 ` Michal Kubecek
2021-04-14 3:05 ` Mark-PK Tsai
2019-10-17 2:17 ` [PATCH v2] " Navid Emamdoost
2019-10-17 19:37 ` [engineering.redhat.com #498403] " Red Hat Product Security
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729164226.22632-1-navid.emamdoost@gmail.com \
--to=navid.emamdoost@gmail.com \
--cc=axboe@kernel.dk \
--cc=emamd001@umn.edu \
--cc=josef@toxicpanda.com \
--cc=kjlu@umn.edu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=secalert@redhat.com \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.