From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70EF4C433FF for ; Mon, 29 Jul 2019 22:29:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C83D2070D for ; Mon, 29 Jul 2019 22:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564439386; bh=JNZa/y24wXNDv30tuaj6kC0kdXk/z7BCg8JawB3obts=; h=In-Reply-To:References:Cc:From:To:Subject:Date:List-ID:From; b=eL3tIQyYXxu68PLJF2s/slhqFrJ20DCdFrMu930GO6FF4RGA4j/rjfZrhcqeXW1Mi yfkpEy65e+X1/o7cl0ozEnbKnHkVUFU2SgPmAaSx0Q9nM1n2hpb1Pbc1a0EBNresZf cxD4qcNWssqoQGjr3Dp1ZVEUuXdIbAMWWYaoRbPY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729029AbfG2W3p (ORCPT ); Mon, 29 Jul 2019 18:29:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:36278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725894AbfG2W3o (ORCPT ); Mon, 29 Jul 2019 18:29:44 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 116DF2070D; Mon, 29 Jul 2019 22:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564439384; bh=JNZa/y24wXNDv30tuaj6kC0kdXk/z7BCg8JawB3obts=; h=In-Reply-To:References:Cc:From:To:Subject:Date:From; b=NxRV8PsJoRIZMOqn4xIbsmF2GL9TDcczIYDurDe3IMz/R+DKattIoWJbpF0FiXiYq efBhSe5r6QPkFdQmLo4rGXOmq2NrUakQbDpwJ5+M6Fuv6rfNHmYY3AJYIt+T6TYfqD 6IEkE7SHbOp8MGy/bQESzADE7AowrIUrtnvHbSmo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190703122614.3579-3-jbrunet@baylibre.com> References: <20190703122614.3579-1-jbrunet@baylibre.com> <20190703122614.3579-3-jbrunet@baylibre.com> Cc: Jerome Brunet , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org From: Stephen Boyd To: Jerome Brunet , Neil Armstrong Subject: Re: [PATCH 2/2] clk: meson: axg-audio: add g12a reset support User-Agent: alot/0.8.1 Date: Mon, 29 Jul 2019 15:29:43 -0700 Message-Id: <20190729222944.116DF2070D@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jerome Brunet (2019-07-03 05:26:14) > @@ -1005,8 +1087,27 @@ static int axg_audio_clkc_probe(struct platform_de= vice *pdev) > } > } > =20 > - return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > - data->hw_onecell_data); > + ret =3D devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > + data->hw_onecell_data); > + if (ret) > + return ret; > + > + /* Stop here if there is no reset */ > + if (!data->reset_num) > + return 0; > + > + rst =3D devm_kzalloc(dev, sizeof(*rst), GFP_KERNEL); > + if (!rst) > + return -ENOMEM; > + > + rst->map =3D map; > + rst->offset =3D data->reset_offset; > + rst->rstc.nr_resets =3D data->reset_num; > + rst->rstc.ops =3D &axg_audio_rstc_ops; > + rst->rstc.of_node =3D dev->of_node; > + rst->rstc.owner =3D THIS_MODULE; > + > + return ret =3D devm_reset_controller_register(dev, &rst->rstc); IS this a typo? Just return devm instead? > } > =20 > static const struct audioclk_data axg_audioclk_data =3D { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869DAC76186 for ; Mon, 29 Jul 2019 22:29:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 599B12070D for ; Mon, 29 Jul 2019 22:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rqMD+kf/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NxRV8PsJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 599B12070D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wr2h5up+c2tG5XACS4S6xHLQqr2zjvR1e/fYWw9AsKs=; b=rqMD+kf/IEus2W JGlxj8PBBehx9otfmTjOkrOZWT//Lu0dTDGTsCaxgnJzatTLuLPne3Vgi7Sg1nlFlQnHRq2km/iDp 7TkcAqWmOqc2uATkqfKe7m5u/71qxR6SYXD1ZHRroegzz8oAqaZdW2NcQ8DvpXifGhRBnBM5CEIU7 dfVB/LkeSElbEvPiHEKzz2hbYjBEfJrh1Gj1hR3j9hdkkZacVg59iTXfds1JBQPWbZESRx/gjvyjW SYEFy/O8ilOxB+4ElDsGLPbxpjL0RpSA71lNzBmFG7LSXDU07DAyAGllWbCx9fh8gvry2xk+MqWdW OE0RFFESs5nA0skFkFvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsE9L-0000zn-G3; Mon, 29 Jul 2019 22:29:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsE9I-0000zT-H1 for linux-amlogic@lists.infradead.org; Mon, 29 Jul 2019 22:29:45 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 116DF2070D; Mon, 29 Jul 2019 22:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564439384; bh=JNZa/y24wXNDv30tuaj6kC0kdXk/z7BCg8JawB3obts=; h=In-Reply-To:References:Cc:From:To:Subject:Date:From; b=NxRV8PsJoRIZMOqn4xIbsmF2GL9TDcczIYDurDe3IMz/R+DKattIoWJbpF0FiXiYq efBhSe5r6QPkFdQmLo4rGXOmq2NrUakQbDpwJ5+M6Fuv6rfNHmYY3AJYIt+T6TYfqD 6IEkE7SHbOp8MGy/bQESzADE7AowrIUrtnvHbSmo= MIME-Version: 1.0 In-Reply-To: <20190703122614.3579-3-jbrunet@baylibre.com> References: <20190703122614.3579-1-jbrunet@baylibre.com> <20190703122614.3579-3-jbrunet@baylibre.com> From: Stephen Boyd To: Jerome Brunet , Neil Armstrong Subject: Re: [PATCH 2/2] clk: meson: axg-audio: add g12a reset support User-Agent: alot/0.8.1 Date: Mon, 29 Jul 2019 15:29:43 -0700 Message-Id: <20190729222944.116DF2070D@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_152944_585561_460996F5 X-CRM114-Status: UNSURE ( 8.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Quoting Jerome Brunet (2019-07-03 05:26:14) > @@ -1005,8 +1087,27 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) > } > } > > - return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > - data->hw_onecell_data); > + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > + data->hw_onecell_data); > + if (ret) > + return ret; > + > + /* Stop here if there is no reset */ > + if (!data->reset_num) > + return 0; > + > + rst = devm_kzalloc(dev, sizeof(*rst), GFP_KERNEL); > + if (!rst) > + return -ENOMEM; > + > + rst->map = map; > + rst->offset = data->reset_offset; > + rst->rstc.nr_resets = data->reset_num; > + rst->rstc.ops = &axg_audio_rstc_ops; > + rst->rstc.of_node = dev->of_node; > + rst->rstc.owner = THIS_MODULE; > + > + return ret = devm_reset_controller_register(dev, &rst->rstc); IS this a typo? Just return devm instead? > } > > static const struct audioclk_data axg_audioclk_data = { _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic