All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: axboe@fb.com
Cc: jonathan.lemon@gmail.com, willy@infradead.org,
	jakub.kicinski@netronome.com, Kernel-team@fb.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec
Date: Tue, 30 Jul 2019 14:22:38 -0700 (PDT)	[thread overview]
Message-ID: <20190730.142238.1475873068715429404.davem@davemloft.net> (raw)
In-Reply-To: <1d34658b-a807-44ae-756a-d55dead27f94@fb.com>

From: Jens Axboe <axboe@fb.com>
Date: Tue, 30 Jul 2019 20:49:09 +0000

> Pretty appalled to see this abomination:
> 
> net: Convert skb_frag_t to bio_vec
> 
> There are a lot of users of frag->page_offset, so use a union
> to avoid converting those users today.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> show up in the net tree without even having been posted on a
> block list...
> 
> At least this kills this ugly thing.

Sorry about that Jens, but at least as you say it's gone now.

  reply	other threads:[~2019-07-30 21:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 14:40 [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec Jonathan Lemon
2019-07-30 14:40 ` [PATCH v2 1/3 net-next] linux: Add skb_frag_t page_offset accessors Jonathan Lemon
2019-07-30 14:40 ` [PATCH v2 2/3 net-next] net: Use skb_frag_off accessors Jonathan Lemon
2019-07-30 14:40 ` [PATCH v2 3/3 net-next] linux: Remove bvec page_offset, use bv_offset Jonathan Lemon
2019-07-30 20:39 ` [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec Jakub Kicinski
2019-07-30 20:49 ` Jens Axboe
2019-07-30 21:22   ` David Miller [this message]
2019-07-30 21:30     ` Jens Axboe
2019-07-30 21:22 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730.142238.1475873068715429404.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Kernel-team@fb.com \
    --cc=axboe@fb.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.