From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C585CC0650F for ; Tue, 30 Jul 2019 09:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9722B206A2 for ; Tue, 30 Jul 2019 09:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564478858; bh=SKrtRvl5PY+xSQMY/2ee+4a4/9Fd63llyHB3gzj8fMw=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=HU7ocgBANI75FX+LHc8kwBgyl2LZDb3WbeLmS6AfG9DxUcCWwoUuZwe0OPpti/Mqy EuniFD/Dh52Md0vGPUKmyg4iReAnTa7gYPKPwSKdVZBEvtuYnQ4Wt8k0LV+sm4iUwk qLv/q1o759XL/eKSgzFaTe4RNanJWTm2aqgmvLkg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731304AbfG3J1h (ORCPT ); Tue, 30 Jul 2019 05:27:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:60242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727247AbfG3J1h (ORCPT ); Tue, 30 Jul 2019 05:27:37 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2096C20665; Tue, 30 Jul 2019 09:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564478856; bh=SKrtRvl5PY+xSQMY/2ee+4a4/9Fd63llyHB3gzj8fMw=; h=Date:From:To:Subject:References:In-Reply-To:From; b=ygueO2xHBORMlwOlZoAFuDF440R5FDSKuhZ6cPycOBVLY2icVq7RQyfm3gj9MSltQ EHD+sP8Ok6RCtCfOCoL5CJl+xCOS2htNHA+QTX7X/jUH2Lk8lKAQqIijLVZ4zNz5SG yPCiZ48mMqNN5WmPkqyAY/FcD3m9BDPNi0n9uRZI= Date: Tue, 30 Jul 2019 10:27:31 +0100 From: Will Deacon To: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux@dominikbrodowski.net, ebiederm@xmission.com, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, oleg@redhat.com, steve.mcintyre@arm.com, dave.martin@arm.com Subject: Re: [PATCH 0/2] Don't use SIGMINSTKSZ when enforcing alternative signal stack size for compat tasks Message-ID: <20190730092730.q6djqrv6ag7fcofs@willie-the-truck> References: <1532526312-26993-1-git-send-email-will.deacon@arm.com> <20190729202302.GA3443@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729202302.GA3443@aurel32.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 10:23:02PM +0200, Aurelien Jarno wrote: > On 2018-07-25 14:45, Will Deacon wrote: > > Hi all, > > > > The Debian folks have observed a failure in the 32-bit arm glibc testsuite > > when running under a 64-bit kernel. They tracked this down to sigaltstack(2) > > enforcing the alternative signal stack to be at least SIGMINSTKSZ bytes, > > which is higher for native arm64 tasks than compat 32-bit tasks. > > > > These patches resolve the issue by allowing an architecture to define > > COMPAT_SIGMINSTKSZ for compat tasks, which is then used by the sigaltstack > > checking code. > > > > Feedback welcome, > > > > Will > > > > --->8 > > > > Will Deacon (2): > > signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack > > arm64: compat: Provide definition for COMPAT_SIGMINSTKSZ > > Only the first patch went to the stable kernels. The second one is > missing, so the bug is still not fixed in those kernels. Would it be > possible to also get it included? Damn, you're right. I think the autosel bot picked the first commit but not the second. In hindsight, we should've tagged them both, but oh well. I've posted the patch here for -stable, with you on cc: https://lore.kernel.org/lkml/20190730092547.1284-1-will@kernel.org/T/#u Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15C2C433FF for ; Tue, 30 Jul 2019 09:27:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A30C320679 for ; Tue, 30 Jul 2019 09:27:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b0OAHH8b"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ygueO2xH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A30C320679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fWWsa3e8sJdo5S8g/jZiC2VlJHaNMsPjh4aHDSASVwA=; b=b0OAHH8bPFdo0o fOwAvc+Jl2Lr4nMbX4pukmOZxBv87ZXU3QOJG//t2t40Iww1TxdYceQO0OtdfoYBiWnnoLHQ1idwM nKHCFi9Z3kNY94qry8NxARgxvNaLNH3N1CTSGAr7GdDCtB1qDow7ybj7nIJH4HaTwjJF4UlpAhttG mQF6OFxrMp44v/R//TWOaZz/BFbxUEumHRFRrhxrWmj1eR2MbsItXE9HdsskNBpbqduTBeqEpcvEp wSm7MYyOWMuPGSzU+UTc7E4oKA6T37IN8GE06gnbJyj/XMWGumF/Goq0yqKmmORaizaaqRHqLycJH zSpOCxGFOF29dUycEPMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsOPz-0002w6-9i; Tue, 30 Jul 2019 09:27:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsOPw-0002vi-U9 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2019 09:27:38 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2096C20665; Tue, 30 Jul 2019 09:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564478856; bh=SKrtRvl5PY+xSQMY/2ee+4a4/9Fd63llyHB3gzj8fMw=; h=Date:From:To:Subject:References:In-Reply-To:From; b=ygueO2xHBORMlwOlZoAFuDF440R5FDSKuhZ6cPycOBVLY2icVq7RQyfm3gj9MSltQ EHD+sP8Ok6RCtCfOCoL5CJl+xCOS2htNHA+QTX7X/jUH2Lk8lKAQqIijLVZ4zNz5SG yPCiZ48mMqNN5WmPkqyAY/FcD3m9BDPNi0n9uRZI= Date: Tue, 30 Jul 2019 10:27:31 +0100 From: Will Deacon To: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux@dominikbrodowski.net, ebiederm@xmission.com, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, oleg@redhat.com, steve.mcintyre@arm.com, dave.martin@arm.com Subject: Re: [PATCH 0/2] Don't use SIGMINSTKSZ when enforcing alternative signal stack size for compat tasks Message-ID: <20190730092730.q6djqrv6ag7fcofs@willie-the-truck> References: <1532526312-26993-1-git-send-email-will.deacon@arm.com> <20190729202302.GA3443@aurel32.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190729202302.GA3443@aurel32.net> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_022736_993222_24499590 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 29, 2019 at 10:23:02PM +0200, Aurelien Jarno wrote: > On 2018-07-25 14:45, Will Deacon wrote: > > Hi all, > > > > The Debian folks have observed a failure in the 32-bit arm glibc testsuite > > when running under a 64-bit kernel. They tracked this down to sigaltstack(2) > > enforcing the alternative signal stack to be at least SIGMINSTKSZ bytes, > > which is higher for native arm64 tasks than compat 32-bit tasks. > > > > These patches resolve the issue by allowing an architecture to define > > COMPAT_SIGMINSTKSZ for compat tasks, which is then used by the sigaltstack > > checking code. > > > > Feedback welcome, > > > > Will > > > > --->8 > > > > Will Deacon (2): > > signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack > > arm64: compat: Provide definition for COMPAT_SIGMINSTKSZ > > Only the first patch went to the stable kernels. The second one is > missing, so the bug is still not fixed in those kernels. Would it be > possible to also get it included? Damn, you're right. I think the autosel bot picked the first commit but not the second. In hindsight, we should've tagged them both, but oh well. I've posted the patch here for -stable, with you on cc: https://lore.kernel.org/lkml/20190730092547.1284-1-will@kernel.org/T/#u Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel