From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFD2C0650F for ; Tue, 30 Jul 2019 09:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E73120651 for ; Tue, 30 Jul 2019 09:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731941AbfG3JqH (ORCPT ); Tue, 30 Jul 2019 05:46:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54000 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730150AbfG3JqG (ORCPT ); Tue, 30 Jul 2019 05:46:06 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6DC63A3B4E; Tue, 30 Jul 2019 09:46:06 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-71.pek2.redhat.com [10.72.12.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A62201001B07; Tue, 30 Jul 2019 09:46:03 +0000 (UTC) Date: Tue, 30 Jul 2019 17:45:59 +0800 From: Dave Young To: Vasily Gorbik Cc: Eric Biederman , Andrew Morton , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, AKASHI Takahiro Subject: Re: [PATCH] kexec: restore arch_kexec_kernel_image_probe declaration Message-ID: <20190730094559.GA11557@dhcp-128-65.nay.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 30 Jul 2019 09:46:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/29/19 at 02:14pm, Vasily Gorbik wrote: > arch_kexec_kernel_image_probe function declaration has been removed by > commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops > functions"). Still this function is overridden by couple of architectures > and proper prototype declaration is therefore important, so bring it > back. This fixes the following sparse warning on s390: > arch/s390/kernel/machine_kexec_file.c:333:5: warning: symbol 'arch_kexec_kernel_image_probe' was not declared. Should it be static? > > Signed-off-by: Vasily Gorbik > --- > include/linux/kexec.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > index 1740fe36b5b7..f7529d120920 100644 > --- a/include/linux/kexec.h > +++ b/include/linux/kexec.h > @@ -183,6 +183,8 @@ int kexec_purgatory_get_set_symbol(struct kimage *image, const char *name, > bool get_value); > void *kexec_purgatory_get_symbol_addr(struct kimage *image, const char *name); > > +int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf, > + unsigned long buf_len); > void * __weak arch_kexec_kernel_image_load(struct kimage *image); > int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi, > Elf_Shdr *section, > -- > 2.21.0 > Acked-by: Dave Young Thanks Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsOhr-00085I-N4 for kexec@lists.infradead.org; Tue, 30 Jul 2019 09:46:09 +0000 Date: Tue, 30 Jul 2019 17:45:59 +0800 From: Dave Young Subject: Re: [PATCH] kexec: restore arch_kexec_kernel_image_probe declaration Message-ID: <20190730094559.GA11557@dhcp-128-65.nay.redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Vasily Gorbik Cc: AKASHI Takahiro , Andrew Morton , kexec@lists.infradead.org, Eric Biederman , linux-kernel@vger.kernel.org On 07/29/19 at 02:14pm, Vasily Gorbik wrote: > arch_kexec_kernel_image_probe function declaration has been removed by > commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops > functions"). Still this function is overridden by couple of architectures > and proper prototype declaration is therefore important, so bring it > back. This fixes the following sparse warning on s390: > arch/s390/kernel/machine_kexec_file.c:333:5: warning: symbol 'arch_kexec_kernel_image_probe' was not declared. Should it be static? > > Signed-off-by: Vasily Gorbik > --- > include/linux/kexec.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > index 1740fe36b5b7..f7529d120920 100644 > --- a/include/linux/kexec.h > +++ b/include/linux/kexec.h > @@ -183,6 +183,8 @@ int kexec_purgatory_get_set_symbol(struct kimage *image, const char *name, > bool get_value); > void *kexec_purgatory_get_symbol_addr(struct kimage *image, const char *name); > > +int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf, > + unsigned long buf_len); > void * __weak arch_kexec_kernel_image_load(struct kimage *image); > int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi, > Elf_Shdr *section, > -- > 2.21.0 > Acked-by: Dave Young Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec