From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE38C0650F for ; Tue, 30 Jul 2019 16:58:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D97F0216C8 for ; Tue, 30 Jul 2019 16:58:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Rkz2n/Z4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730127AbfG3Q6e (ORCPT ); Tue, 30 Jul 2019 12:58:34 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35568 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730100AbfG3Q6d (ORCPT ); Tue, 30 Jul 2019 12:58:33 -0400 Received: by mail-pf1-f194.google.com with SMTP id u14so30175927pfn.2 for ; Tue, 30 Jul 2019 09:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=kNH9892mMSdbgyYPq04/DOS1+jjJ5DNNUuFxNaUc4lA=; b=Rkz2n/Z4fx/N0ovqStcb1ANvDKtxcDrtxVH5xiavqxMZ1id3tmJKj9s3v/0i79OK1q oslYjKScx1QzaiiFKAhy912qj3Jku9gLgZoi51x/zngQxhCvSItaR+EwuJ1BxjG44yqC 3r5vhAlvt9FrFziJLdNbUMqNe+fKrl8yEPIAQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=kNH9892mMSdbgyYPq04/DOS1+jjJ5DNNUuFxNaUc4lA=; b=fnTn1sgNkD46KKRK9TGFhJGRs//Ao/DtcaIO5itiJOPWb87DuPj4HP6q53h2PrzyFS y/tv6A6EBiLqLFeh4AG0WKZwHMe4KBElFkCECZ+nDnI1ykCQEE9WL2LGGJSMtW2L/VCx G5Thq7rOrpnwykWMgWb4O2KNnrWJJrTvlXYZnPuDzo7I7CrCmIiWmGCTb9noENMKEqUa PFA9C18BapZRKyFrlEgDfuYp1YBJUby1T52M1VXL31ywUqcOgu2aF3vJUdq6bLYRSxce GvMDb7AJtxLl+MN38fTeSSR65/Qq5bFInXnn+8qVB5VdnxF9s+Zw3fZaXacMv9Lyc0am c7Kg== X-Gm-Message-State: APjAAAWb4v4Kk0cCFErbG788DUxar+nIWo2YHbJIiJaLAe4iprS1KyCa RoHhTpXE2Nh5vs6KNo8BImMkng== X-Google-Smtp-Source: APXvYqxlkNe5qlW5oU8NKyA6zXOWROGHVUAwS/f3z/hvi4mf0dRFgYBwSNr9otMt3pnou4o4biWeGQ== X-Received: by 2002:a17:90a:33c4:: with SMTP id n62mr121088686pjb.28.1564505912808; Tue, 30 Jul 2019 09:58:32 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y22sm76514188pfo.39.2019.07.30.09.58.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jul 2019 09:58:31 -0700 (PDT) Date: Tue, 30 Jul 2019 09:58:31 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Vinod Koul , Dan Williams , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: imx-dma: Mark expected switch fall-through Message-ID: <201907300958.5F8CC90AD1@keescook> References: <20190729225221.GA24269@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190729225221.GA24269@embeddedor> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Mon, Jul 29, 2019 at 05:52:21PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: arm): > > drivers/dma/imx-dma.c: In function ‘imxdma_xfer_desc’: > drivers/dma/imx-dma.c:542:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (slot == IMX_DMA_2D_SLOT_A) { > ^ > drivers/dma/imx-dma.c:559:2: note: here > case IMXDMA_DESC_MEMCPY: > ^~~~ > > Notice that, in this particular case, the code comment is > modified in accordance with what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -Kees > --- > drivers/dma/imx-dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c > index 00a089e24150..5c0fb3134825 100644 > --- a/drivers/dma/imx-dma.c > +++ b/drivers/dma/imx-dma.c > @@ -556,6 +556,7 @@ static int imxdma_xfer_desc(struct imxdma_desc *d) > * We fall-through here intentionally, since a 2D transfer is > * similar to MEMCPY just adding the 2D slot configuration. > */ > + /* Fall through */ > case IMXDMA_DESC_MEMCPY: > imx_dmav1_writel(imxdma, d->src, DMA_SAR(imxdmac->channel)); > imx_dmav1_writel(imxdma, d->dest, DMA_DAR(imxdmac->channel)); > -- > 2.22.0 > -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659E3C0650F for ; Tue, 30 Jul 2019 16:58:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CFFB208E4 for ; Tue, 30 Jul 2019 16:58:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PKkMgOUH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Rkz2n/Z4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CFFB208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=83upIWXTN09EO0l3lAf0rCYaGPEU1R2BwRqn7OA5wrI=; b=PKkMgOUHnPA86Z hejzJQ3jlXqUw7DfaHxyRokw2h8Nno87Bmph5/BZXJT3k/eep4hstlL+MDYR3VdkboGt+iqSccDAs +8X6kJxc2qSGKfJDSJB4aCI+EEp/mD2UKlkTkLgP6KwgB5C4rYuJBSO2EfzRsy/MaCaUXPiwGX3ws uUAh+rO5LxyI8yDDU8qJ6zXI4Ydn+VNYpf+t4HT7Sfc37n18dg0s3Egr/6Cocid3RfHvgp57D3Y59 FMUdPovfxEC48Ka0W5wQlQUlvHuvdGfzP70qLS/dPynUyioOS3hha66usXhvefZg9rvgozhJT8Y87 ZU1UIUjiEMpv1/B9h9fg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsVSP-0004a4-FZ; Tue, 30 Jul 2019 16:58:37 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsVSM-0004ZK-0T for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2019 16:58:35 +0000 Received: by mail-pg1-x543.google.com with SMTP id t132so30362390pgb.9 for ; Tue, 30 Jul 2019 09:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=kNH9892mMSdbgyYPq04/DOS1+jjJ5DNNUuFxNaUc4lA=; b=Rkz2n/Z4fx/N0ovqStcb1ANvDKtxcDrtxVH5xiavqxMZ1id3tmJKj9s3v/0i79OK1q oslYjKScx1QzaiiFKAhy912qj3Jku9gLgZoi51x/zngQxhCvSItaR+EwuJ1BxjG44yqC 3r5vhAlvt9FrFziJLdNbUMqNe+fKrl8yEPIAQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=kNH9892mMSdbgyYPq04/DOS1+jjJ5DNNUuFxNaUc4lA=; b=cSN512whSdPVRT2stNAVWVQGyrjuG0b9xwlnpfvpWuKgbeJ73YFDNe/VQk9JnW5xOz I5UNgtggG9rLhMerNfbaSvuXZPb5eU8oKO3PYNQWevoz51vILMWDJ6lcjJRC57HmDMSN LC74w2mCEkbMOECLSiSZCaX5/uGEwVi5vKHhN7SbuxDuVHmIMF81BROn2xV7OLr8Olt1 bOOJT+j+ZfvoDl2NPyPOzOG4TiWvvnFl5fBIxf6/1CXnUsGZTD7k7sFx7fJBbbCiiTVw /h1vn6ukoYxuuRfHgcs0gsAJDmlNGmj5aM0AZfS2dfWU16ZalnqGstNABVg53eMrG25H x1wA== X-Gm-Message-State: APjAAAXr2/aXsRIxqd589ZYOf2FzjXK1ubGUXm+9tLL7lIqmcfgSElg7 z8sKqQxPVkhOiIUc4kyHBND8EA== X-Google-Smtp-Source: APXvYqxlkNe5qlW5oU8NKyA6zXOWROGHVUAwS/f3z/hvi4mf0dRFgYBwSNr9otMt3pnou4o4biWeGQ== X-Received: by 2002:a17:90a:33c4:: with SMTP id n62mr121088686pjb.28.1564505912808; Tue, 30 Jul 2019 09:58:32 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y22sm76514188pfo.39.2019.07.30.09.58.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jul 2019 09:58:31 -0700 (PDT) Date: Tue, 30 Jul 2019 09:58:31 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Subject: Re: [PATCH] dmaengine: imx-dma: Mark expected switch fall-through Message-ID: <201907300958.5F8CC90AD1@keescook> References: <20190729225221.GA24269@embeddedor> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190729225221.GA24269@embeddedor> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_095834_055889_E7A3CB82 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Vinod Koul , NXP Linux Team , Pengutronix Kernel Team , dmaengine@vger.kernel.org, Dan Williams , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdWwgMjksIDIwMTkgYXQgMDU6NTI6MjFQTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBNYXJrIHN3aXRjaCBjYXNlcyB3aGVyZSB3ZSBhcmUgZXhwZWN0aW5nIHRv IGZhbGwgdGhyb3VnaC4KPiAKPiBUaGlzIHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dpbmcgd2Fybmlu ZyAoQnVpbGRpbmc6IGFybSk6Cj4gCj4gZHJpdmVycy9kbWEvaW14LWRtYS5jOiBJbiBmdW5jdGlv biDigJhpbXhkbWFfeGZlcl9kZXNj4oCZOgo+IGRyaXZlcnMvZG1hL2lteC1kbWEuYzo1NDI6Njog d2FybmluZzogdGhpcyBzdGF0ZW1lbnQgbWF5IGZhbGwgdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxs dGhyb3VnaD1dCj4gICAgaWYgKHNsb3QgPT0gSU1YX0RNQV8yRF9TTE9UX0EpIHsKPiAgICAgICBe Cj4gZHJpdmVycy9kbWEvaW14LWRtYS5jOjU1OToyOiBub3RlOiBoZXJlCj4gICBjYXNlIElNWERN QV9ERVNDX01FTUNQWToKPiAgIF5+fn4KPiAKPiBOb3RpY2UgdGhhdCwgaW4gdGhpcyBwYXJ0aWN1 bGFyIGNhc2UsIHRoZSBjb2RlIGNvbW1lbnQgaXMKPiBtb2RpZmllZCBpbiBhY2NvcmRhbmNlIHdp dGggd2hhdCBHQ0MgaXMgZXhwZWN0aW5nIHRvIGZpbmQuCj4gCj4gU2lnbmVkLW9mZi1ieTogR3Vz dGF2byBBLiBSLiBTaWx2YSA8Z3VzdGF2b0BlbWJlZGRlZG9yLmNvbT4KClJldmlld2VkLWJ5OiBL ZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVtLm9yZz4KCi1LZWVzCgo+IC0tLQo+ICBkcml2ZXJz L2RtYS9pbXgtZG1hLmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hL2lteC1kbWEuYyBiL2RyaXZlcnMvZG1hL2lteC1k bWEuYwo+IGluZGV4IDAwYTA4OWUyNDE1MC4uNWMwZmIzMTM0ODI1IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZG1hL2lteC1kbWEuYwo+ICsrKyBiL2RyaXZlcnMvZG1hL2lteC1kbWEuYwo+IEBAIC01 NTYsNiArNTU2LDcgQEAgc3RhdGljIGludCBpbXhkbWFfeGZlcl9kZXNjKHN0cnVjdCBpbXhkbWFf ZGVzYyAqZCkKPiAgCQkgKiBXZSBmYWxsLXRocm91Z2ggaGVyZSBpbnRlbnRpb25hbGx5LCBzaW5j ZSBhIDJEIHRyYW5zZmVyIGlzCj4gIAkJICogc2ltaWxhciB0byBNRU1DUFkganVzdCBhZGRpbmcg dGhlIDJEIHNsb3QgY29uZmlndXJhdGlvbi4KPiAgCQkgKi8KPiArCQkvKiBGYWxsIHRocm91Z2gg Ki8KPiAgCWNhc2UgSU1YRE1BX0RFU0NfTUVNQ1BZOgo+ICAJCWlteF9kbWF2MV93cml0ZWwoaW14 ZG1hLCBkLT5zcmMsIERNQV9TQVIoaW14ZG1hYy0+Y2hhbm5lbCkpOwo+ICAJCWlteF9kbWF2MV93 cml0ZWwoaW14ZG1hLCBkLT5kZXN0LCBETUFfREFSKGlteGRtYWMtPmNoYW5uZWwpKTsKPiAtLSAK PiAyLjIyLjAKPiAKCi0tIApLZWVzIENvb2sKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK