All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: daniel.vetter@ffwll.ch, sam@ravnborg.org,
	dri-devel@lists.freedesktop.org, hdegoede@redhat.com
Subject: Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
Date: Tue, 30 Jul 2019 15:16:19 +0100	[thread overview]
Message-ID: <20190730141619.GC12424@arch-x1c3> (raw)
In-Reply-To: <45d73a17-2197-6d31-923f-93af4bfd895a@tronnes.org>

On 2019/07/30, Noralf Trønnes wrote:
> 
> 
> Den 30.07.2019 15.53, skrev Emil Velikov:
> > On 2019/07/25, Noralf Trønnes wrote:
> >> This makes the tiny drivers visible by default without having to enable a
> >> knob.
> >>
> >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> >> ---
> >>  drivers/gpu/drm/Makefile        |  2 +-
> >>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
> >>  2 files changed, 22 insertions(+), 17 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> >> index 98c732f925c7..0b30afa7524d 100644
> >> --- a/drivers/gpu/drm/Makefile
> >> +++ b/drivers/gpu/drm/Makefile
> >> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
> >>  obj-y			+= hisilicon/
> >>  obj-$(CONFIG_DRM_ZTE)	+= zte/
> >>  obj-$(CONFIG_DRM_MXSFB)	+= mxsfb/
> >> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
> >> +obj-y			+= tinydrm/
> >>  obj-$(CONFIG_DRM_PL111) += pl111/
> >>  obj-$(CONFIG_DRM_TVE200) += tve200/
> >>  obj-$(CONFIG_DRM_XEN) += xen/
> >> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> >> index 42b06f4f8989..f8c9a0e71dde 100644
> >> --- a/drivers/gpu/drm/tinydrm/Kconfig
> >> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> >> @@ -1,16 +1,9 @@
> >>  # SPDX-License-Identifier: GPL-2.0-only
> >> -menuconfig DRM_TINYDRM
> >> -	tristate "Support for simple displays"
> >> -	depends on DRM
> >> -	select DRM_KMS_HELPER
> >> -	select DRM_KMS_CMA_HELPER
> >> -	help
> >> -	  Choose this option if you have a tinydrm supported display.
> >> -	  If M is selected the module will be called tinydrm.
> >> -
> > Fwiw I would have gone with Han's idea of making this hidden. That has a
> > number of advantages, even if we don't have a separate tinydrm.ko:
> >  - the tinydrm code is not build when there are no users
> 
> The thing is, there is no tinydrm code anymore, it's all been put into
> various core helpers. The folder does only contain regular DRM drivers.
> The only thing special about them is that they fit into one source file.

Right, I saw your series killing tinydrm.ko [1] and missed see the
mipi-dbi.c move with commit 174102f4de230a1bf85e6ef2f8c83e50b3ba22c9

Thanks for the awesome work.
Emil

[1] https://patchwork.freedesktop.org/series/63811/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-07-30 14:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 10:51 [PATCH 0/3] drm/tinydrm: Rename to drm/tiny Noralf Trønnes
2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
2019-07-30 13:19   ` Hans de Goede
2019-07-30 13:34     ` Noralf Trønnes
2019-07-30 13:35       ` Hans de Goede
2019-07-30 13:53   ` Emil Velikov
2019-07-30 14:03     ` Noralf Trønnes
2019-07-30 14:16       ` Emil Velikov [this message]
2019-10-01 12:36   ` [1/3] " Jason Gunthorpe
2019-10-01 13:28     ` Noralf Trønnes
2019-10-01 13:28       ` Noralf Trønnes
2019-10-01 13:45       ` Jason Gunthorpe
2019-10-01 14:07         ` Noralf Trønnes
2019-10-09 10:45           ` Daniel Vetter
2019-10-09 10:45             ` Daniel Vetter
2019-10-09 12:48             ` Noralf Trønnes
2019-10-09 13:31               ` Maxime Ripard
2019-10-10 13:30                 ` Noralf Trønnes
2019-10-10 13:30                   ` Noralf Trønnes
2019-07-25 10:51 ` [PATCH 2/3] drm/tinydrm: Rename folder to tiny Noralf Trønnes
2019-07-25 10:51 ` [PATCH 3/3] drm/gm12u320: Move driver to drm/tiny Noralf Trønnes
2019-07-25 12:06 ` [PATCH 0/3] drm/tinydrm: Rename " Daniel Vetter
2019-07-25 12:46   ` Noralf Trønnes
2019-07-25 15:10     ` Sam Ravnborg
2019-07-31 13:32 ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730141619.GC12424@arch-x1c3 \
    --to=emil.l.velikov@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=noralf@tronnes.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.