Re: [nft PATCH v2 0/2] parser_bison: Get rid of (most) bison compiler warnings

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Jul 30, 2019 at 04:03:54PM +0200, Phil Sutter wrote:
> Hi Pablo,
> 
> On Tue, Jul 30, 2019 at 02:41:06PM +0200, Pablo Neira Ayuso wrote:
> > On Tue, Jul 23, 2019 at 03:23:11PM +0200, Phil Sutter wrote:
> > > Eliminate as many bison warnings emitted since bison-3.3 as possible.
> > > Sadly getting bison, flex and automake right is full of pitfalls so on
> > > one hand this series does not fix for deprecated %name-prefix statement
> > > and on the other passes -Wno-yacc to bison to not complain about POSIX
> > > incompatibilities although automake causes to run bison in POSIX compat
> > > mode in the first place. Fixing either of those turned out to be
> > > non-trivial.
> > 
> > Indeed, lots of warnings and things to be updated.
> > 
> > Do you think it's worth fixing those in the midterm?
> > 
> > We can just place these two small ones in the tree, I'm just concerned
> > about tech debt in the midterm, these deprecated stuff might just go
> > away.
> 
> We should avoid calling bison with -y since the parser simply isn't
> POSIX yacc compatible. I found a trick somewhere in WWW to do that (one
> has to substitute AC_PROG_YACC) but lost the reference again. But after
> doing so, there was a problem with file names I failed to resolve.
> Hence why I resorted to just passing -Wno-yacc.

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

If parser does not break with this and tests pass fine, I'm ok with
this temporary solution. I also need all most warnings go away here by
now.

Please, if you find that reference again share it with me.

Thanks.