From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
Date: Tue, 30 Jul 2019 12:18:35 -0400 [thread overview]
Message-ID: <20190730161835.GC6403@bill-the-cat> (raw)
In-Reply-To: <56130afa-7d25-a2be-a5ff-b98ad3288b93@ti.com>
On Tue, Jul 30, 2019 at 11:16:19AM -0500, Suman Anna wrote:
> Hi Lokesh,
>
> On 7/29/19 11:08 PM, Lokesh Vutla wrote:
> >
> >
> > On 29/07/19 10:18 PM, Suman Anna wrote:
> >> The K3 System Controller driver is used for loading and starting
> >> the System Firmware, and is used only on R5 SPL. It need not be
> >> enabled and built for the A53 U-Boot and SPL, so disable it from
> >> both the GP and HS AM65x A53 defconfigs.
> >>
> >> While at this, also remove the unneeded CONFIG_SPL_REMOTEPROC and
> >> CONFIG_CMD_REMOTEPROC as no remoteprocs are now loaded from A53 SPL.
> >>
> >> Signed-off-by: Suman Anna <s-anna@ti.com>
> >> ---
> >> configs/am65x_evm_a53_defconfig | 3 ---
> >> configs/am65x_hs_evm_a53_defconfig | 3 ---
> >> 2 files changed, 6 deletions(-)
> >>
> >> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
> >> index 2cf3a693fc70..d43df6a18765 100644
> >> --- a/configs/am65x_evm_a53_defconfig
> >> +++ b/configs/am65x_evm_a53_defconfig
> >> @@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y
> >> CONFIG_SPL_DM_MAILBOX=y
> >> CONFIG_SPL_DM_RESET=y
> >> CONFIG_SPL_POWER_DOMAIN=y
> >> -CONFIG_SPL_REMOTEPROC=y
> >> CONFIG_SPL_YMODEM_SUPPORT=y
> >> CONFIG_CMD_ASKENV=y
> >> # CONFIG_CMD_FLASH is not set
> >> CONFIG_CMD_GPT=y
> >> CONFIG_CMD_I2C=y
> >> CONFIG_CMD_MMC=y
> >> -CONFIG_CMD_REMOTEPROC=y
> >
> > CMD_REMOTEPROC will definitely be used in very near future. Please retain this.
> > Rest looks good to me.
>
> This is a result of using savedefconfig, I prefer it this way since it
> allows other developers adding options to do it cleanly. If and when a
> REMOTEPROC is enabled, the savedefconfig with corresponding options
> should automatically bring this back.
Indeed, if savedefconfig is taking it out, it's not being built today OR
it's already default y and being built.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190730/dfbd5887/attachment.sig>
next prev parent reply other threads:[~2019-07-30 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 16:48 [U-Boot] [PATCH 0/2] Disable K3_SYSTEM_CONTROLLER on K3 Arm64 cores Suman Anna
2019-07-29 16:48 ` [U-Boot] [PATCH 1/2] configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER Suman Anna
2019-07-30 4:08 ` Lokesh Vutla
2019-07-30 16:16 ` Suman Anna
2019-07-30 16:18 ` Tom Rini [this message]
2019-07-31 3:46 ` Lokesh Vutla
2019-08-01 3:36 ` Tom Rini
2019-07-29 16:48 ` [U-Boot] [PATCH 2/2] configs: j721e_evm_a72: " Suman Anna
2019-08-01 3:36 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730161835.GC6403@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.