All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: devel@driverdev.osuosl.org, kjlu@umn.edu,
	linux-kernel@vger.kernel.org,
	John Whitmore <johnfwhitmore@gmail.com>,
	emamd001@umn.edu, Nishka Dasgupta <nishkadg.linux@gmail.com>,
	smccaman@umn.edu, Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH v2] rtl8192_init_priv_variable: null check is missing for kzalloc
Date: Tue, 30 Jul 2019 18:43:04 +0200	[thread overview]
Message-ID: <20190730164304.GA10640@kroah.com> (raw)
In-Reply-To: <20190730143102.6662-1-navid.emamdoost@gmail.com>

On Tue, Jul 30, 2019 at 09:30:58AM -0500, Navid Emamdoost wrote:
> Allocation for priv->pFirmware may fail, so a null check is necessary.
> priv->pFirmware is accessed later in rtl8192_adapter_start. I added the
>  check and made appropriate changes to propagate the errno to the caller.
> 
> Update: fixed style errors

The "changelog" goes below the --- line, as is described in the kernel
documentation.

Also, please look at other patches for this driver, use the same prefix
for the subject line as those did.

v3 please?

thanks,

greg k-h

  reply	other threads:[~2019-07-30 16:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20 20:25 [PATCH] rtl8192_init_priv_variable: null check is missing for kzalloc Navid Emamdoost
2019-07-20 20:25 ` Navid Emamdoost
2019-07-25 12:45 ` Greg Kroah-Hartman
2019-07-25 12:45 ` Greg Kroah-Hartman
2019-07-30 14:30   ` [PATCH v2] " Navid Emamdoost
2019-07-30 16:43     ` Greg KH [this message]
2019-07-30 22:01       ` [PATCH v3] staging: rtl8192u: null check the kzalloc Navid Emamdoost
2019-07-30 22:01       ` Navid Emamdoost
2019-07-31 11:36         ` Greg KH
2019-07-31 14:19           ` [PATCH v4] " Navid Emamdoost
2019-07-31 14:19           ` Navid Emamdoost
2019-07-30 14:30   ` [PATCH v2] rtl8192_init_priv_variable: null check is missing for kzalloc Navid Emamdoost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730164304.GA10640@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=emamd001@umn.edu \
    --cc=johnfwhitmore@gmail.com \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=nishkadg.linux@gmail.com \
    --cc=smccaman@umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.