All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static
@ 2019-07-30 15:00 ` YueHaibing
  0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-07-30 15:00 UTC (permalink / raw)
  To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
	airlied, daniel, seanpaul, heiko
  Cc: linux-kernel, dri-devel, YueHaibing

Fix sparse warning:

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
 symbol 'analogix_dp_atomic_check' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index c82c7d5..f2f7f69 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
 }
 
 
-int analogix_dp_atomic_check(struct drm_connector *connector,
-			     struct drm_atomic_state *state)
+static int analogix_dp_atomic_check(struct drm_connector *connector,
+				    struct drm_atomic_state *state)
 {
 	struct analogix_dp_device *dp = to_dp(connector);
 	struct drm_connector_state *conn_state;
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static
@ 2019-07-30 15:00 ` YueHaibing
  0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-07-30 15:00 UTC (permalink / raw)
  To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
	airlied, daniel, seanpaul, heiko
  Cc: linux-kernel, dri-devel, YueHaibing

Fix sparse warning:

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
 symbol 'analogix_dp_atomic_check' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index c82c7d5..f2f7f69 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
 }
 
 
-int analogix_dp_atomic_check(struct drm_connector *connector,
-			     struct drm_atomic_state *state)
+static int analogix_dp_atomic_check(struct drm_connector *connector,
+				    struct drm_atomic_state *state)
 {
 	struct analogix_dp_device *dp = to_dp(connector);
 	struct drm_connector_state *conn_state;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static
  2019-07-30 15:00 ` YueHaibing
  (?)
@ 2019-07-30 17:07 ` Sean Paul
  -1 siblings, 0 replies; 3+ messages in thread
From: Sean Paul @ 2019-07-30 17:07 UTC (permalink / raw)
  To: YueHaibing
  Cc: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
	airlied, daniel, seanpaul, heiko, linux-kernel, dri-devel

On Tue, Jul 30, 2019 at 11:00:57PM +0800, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
>  symbol 'analogix_dp_atomic_check' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks for your patch, applied to drm-misc-next

Sean

> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index c82c7d5..f2f7f69 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
>  }
>  
>  
> -int analogix_dp_atomic_check(struct drm_connector *connector,
> -			     struct drm_atomic_state *state)
> +static int analogix_dp_atomic_check(struct drm_connector *connector,
> +				    struct drm_atomic_state *state)
>  {
>  	struct analogix_dp_device *dp = to_dp(connector);
>  	struct drm_connector_state *conn_state;
> -- 
> 2.7.4
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-30 17:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-30 15:00 [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static YueHaibing
2019-07-30 15:00 ` YueHaibing
2019-07-30 17:07 ` Sean Paul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.