From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B082CC433FF for ; Tue, 30 Jul 2019 18:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8482521726 for ; Tue, 30 Jul 2019 18:18:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="flOWBgeK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729191AbfG3SSp (ORCPT ); Tue, 30 Jul 2019 14:18:45 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:39221 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388014AbfG3SQ3 (ORCPT ); Tue, 30 Jul 2019 14:16:29 -0400 Received: by mail-pl1-f193.google.com with SMTP id b7so29256250pls.6 for ; Tue, 30 Jul 2019 11:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9QcLwsc+g9/nkAYconN3atycpaD3W9Oj7VTl50rUYI8=; b=flOWBgeKN66a+lkeYUJw67um1dky5NseAGdVBwDkLgqqgNPE51BaQrLl2XD9uIw7ow bt7ThNZmPP60v8Zjs3DNydj3XPHteDsC5c+C7zSiODg1yt4rUB/ita+9jHnavVBb0mr9 avUKc1BFKlVMQBujqr9SoXL5dRwA4Ep05wSDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9QcLwsc+g9/nkAYconN3atycpaD3W9Oj7VTl50rUYI8=; b=gqAd7gq9vE57wkLwyHy4dTyQv6w28WTF4Ffhx8EG/GlnVZKiofjA6bi/JEVBd8DXSQ lQ0yXmuaeq75NKis5ReTAWe4rH6BCZebyQ6D3QijfMdFyj6skmNTyNjHaVkCWDEedCoP XoSfXXU33k2AxXkS9oMEFLgzVpQJ6ztlmwtrkNyd5Zr6XYwWcFsqPRmOGmE4KjLohbCT rZkMzh05yfnStch9NA2p3dbKRGNKp5sYt3HCaCe/50ocLsC58Ko6ZXFfUQZT4YUff9Wk 8kujk9ujsQozxXfghYHqoBBwcheHF4+/AiPYlAo1S9F35hRqo31229+vmm4SWFa3Wg3S 0+bA== X-Gm-Message-State: APjAAAX7IZtfIDFqyMblYRcCuYltdlLO4pulB3bzo2Oo9x8Q1bOJMQsZ 128NneRqX2Ze/TzJxvgGYz8vYZok7Sj00A== X-Google-Smtp-Source: APXvYqw8qhi0NlIOlpgPnm+0CiKy/x0CAkkQYAenrtgmro/8bcy85mYSXx1l5obJEIg5J+PbbaIREA== X-Received: by 2002:a17:902:29a7:: with SMTP id h36mr119155726plb.158.1564510588597; Tue, 30 Jul 2019 11:16:28 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id g1sm106744083pgg.27.2019.07.30.11.16.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 11:16:28 -0700 (PDT) From: Stephen Boyd To: linux-kernel@vger.kernel.org Cc: Thierry Reding , linux-pwm@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() Date: Tue, 30 Jul 2019 11:15:36 -0700 Message-Id: <20190730181557.90391-37-swboyd@chromium.org> X-Mailer: git-send-email 2.22.0.709.g102302147b-goog In-Reply-To: <20190730181557.90391-1-swboyd@chromium.org> References: <20190730181557.90391-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // While we're here, remove braces on if statements that only have one statement (manually). Cc: Thierry Reding Cc: linux-pwm@vger.kernel.org Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/pwm/pwm-sti.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c index 20450e34ad57..1508616d794c 100644 --- a/drivers/pwm/pwm-sti.c +++ b/drivers/pwm/pwm-sti.c @@ -564,10 +564,8 @@ static int sti_pwm_probe(struct platform_device *pdev) return PTR_ERR(pc->regmap); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "Failed to obtain IRQ\n"); + if (irq < 0) return irq; - } ret = devm_request_irq(&pdev->dev, irq, sti_pwm_interrupt, 0, pdev->name, pc); -- Sent by a computer through tubes