From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
sthemmin@microsoft.com, dsahern@gmail.com, mlxsw@mellanox.com
Subject: Re: [patch net-next 3/3] netdevsim: create devlink and netdev instances in namespace
Date: Tue, 30 Jul 2019 23:03:01 +0200 [thread overview]
Message-ID: <20190730210301.GB2288@nanopsycho.orion> (raw)
In-Reply-To: <20190730101411.7dc1e83d@cakuba.netronome.com>
Tue, Jul 30, 2019 at 07:14:11PM CEST, jakub.kicinski@netronome.com wrote:
>On Tue, 30 Jul 2019 08:06:55 +0200, Jiri Pirko wrote:
>> >> diff --git a/drivers/net/netdevsim/netdevsim.h b/drivers/net/netdevsim/netdevsim.h
>> >> index 79c05af2a7c0..cdf53d0e0c49 100644
>> >> --- a/drivers/net/netdevsim/netdevsim.h
>> >> +++ b/drivers/net/netdevsim/netdevsim.h
>> >> @@ -19,6 +19,7 @@
>> >> #include <linux/netdevice.h>
>> >> #include <linux/u64_stats_sync.h>
>> >> #include <net/devlink.h>
>> >> +#include <net/net_namespace.h>
>> >
>> >You can just do a forward declaration, no need to pull in the header.
>>
>> Sure, but why?
>
>Less time to compile the kernel after net_namespace.h was touched.
>Don't we all spend more time that we would like to recompiling the
>kernel? :( Not a huge deal if you have a strong preference.
I removed it in v2. I don't care that much either :)
next prev parent reply other threads:[~2019-07-30 21:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 9:44 [patch net-next 0/3] net: devlink: Finish network namespace support Jiri Pirko
2019-07-27 9:44 ` [patch net-next 1/3] net: devlink: allow to change namespaces Jiri Pirko
2019-07-29 17:52 ` David Miller
2019-07-30 6:05 ` Jiri Pirko
2019-07-27 9:44 ` [patch net-next 2/3] net: devlink: export devlink net set/get helpers Jiri Pirko
2019-07-27 9:44 ` [patch net-next 3/3] netdevsim: create devlink and netdev instances in namespace Jiri Pirko
2019-07-29 18:59 ` Jakub Kicinski
2019-07-30 6:06 ` Jiri Pirko
2019-07-30 17:14 ` Jakub Kicinski
2019-07-30 21:03 ` Jiri Pirko [this message]
2019-07-27 10:05 ` [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace Jiri Pirko
2019-07-27 10:12 ` Toke Høiland-Jørgensen
2019-07-27 10:21 ` Jiri Pirko
2019-07-27 10:25 ` Toke Høiland-Jørgensen
2019-07-29 20:21 ` David Ahern
2019-07-30 6:07 ` Jiri Pirko
2019-07-29 20:17 ` David Ahern
2019-07-27 10:05 ` [patch iproute2 2/2] devlink: add support for network namespace change Jiri Pirko
2019-07-29 20:17 ` [patch net-next 0/3] net: devlink: Finish network namespace support David Ahern
2019-07-30 6:08 ` Jiri Pirko
2019-07-31 21:50 ` David Ahern
2019-07-31 22:02 ` Jakub Kicinski
2019-07-31 22:07 ` David Ahern
2019-07-31 22:28 ` Jakub Kicinski
2019-07-31 22:31 ` David Ahern
2019-08-02 7:42 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730210301.GB2288@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.