All of lore.kernel.org
 help / color / mirror / Atom feed
* Kernel patch commit message and content do differ
@ 2019-07-29 20:20 Toralf Förster
  2019-07-29 20:42 ` Matthias Kaehlcke
  0 siblings, 1 reply; 3+ messages in thread
From: Toralf Förster @ 2019-07-29 20:20 UTC (permalink / raw)
  To: Matthias Kaehlcke; +Cc: Linux Kernel, Sasha Levin

May I ask you to clarify why https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-5.2/net-ipv4-fib_trie-avoid-cryptic-ternary-expressions.patch?id=e1b76013997246a0d14b7443acbb393577d2a1e8 speaks about a ternary operator, whereas the diff shows a changed #define?


--
Toralf
PGP C4EACDDE 0076E94E


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Kernel patch commit message and content do differ
  2019-07-29 20:20 Kernel patch commit message and content do differ Toralf Förster
@ 2019-07-29 20:42 ` Matthias Kaehlcke
  2019-07-30 22:29   ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2019-07-29 20:42 UTC (permalink / raw)
  To: Toralf Förster; +Cc: Linux Kernel, Sasha Levin, Nathan Huckleberry

Hi,

On Mon, Jul 29, 2019 at 10:20:25PM +0200, Toralf Förster wrote:
> May I ask you to clarify why
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-5.2/net-ipv4-fib_trie-avoid-cryptic-ternary-expressions.patch?id=e1b76013997246a0d14b7443acbb393577d2a1e8
> speaks about a ternary operator, whereas the diff shows a changed
> #define?

This is a good question, apparently the content of the queued patch is:

commit 4df607cc6fe8e46b258ff2a53d0a60ca3008ffc7
Author: Nathan Huckleberry <nhuck@google.com>
Date:   Mon Jun 17 10:28:29 2019 -0700

    kbuild: Remove unnecessary -Wno-unused-value


however the commit message is from:

commit 25cec756891e8733433efea63b2254ddc93aa5cc
Author: Matthias Kaehlcke <mka@chromium.org>
Date:   Tue Jun 18 14:14:40 2019 -0700

    net/ipv4: fib_trie: Avoid cryptic ternary expressions


Other than that the stable port also is missing a Signed-off-by tag
from Nathan.

Looks like the patch didn't actually make it into -stable yet? If that
is correct we should be in time to fix it up before it becomes part of
the git history.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Kernel patch commit message and content do differ
  2019-07-29 20:42 ` Matthias Kaehlcke
@ 2019-07-30 22:29   ` Sasha Levin
  0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2019-07-30 22:29 UTC (permalink / raw)
  To: Matthias Kaehlcke; +Cc: Toralf Förster, Linux Kernel, Nathan Huckleberry

On Mon, Jul 29, 2019 at 01:42:42PM -0700, Matthias Kaehlcke wrote:
>Hi,
>
>On Mon, Jul 29, 2019 at 10:20:25PM +0200, Toralf Förster wrote:
>> May I ask you to clarify why
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-5.2/net-ipv4-fib_trie-avoid-cryptic-ternary-expressions.patch?id=e1b76013997246a0d14b7443acbb393577d2a1e8
>> speaks about a ternary operator, whereas the diff shows a changed
>> #define?
>
>This is a good question, apparently the content of the queued patch is:
>
>commit 4df607cc6fe8e46b258ff2a53d0a60ca3008ffc7
>Author: Nathan Huckleberry <nhuck@google.com>
>Date:   Mon Jun 17 10:28:29 2019 -0700
>
>    kbuild: Remove unnecessary -Wno-unused-value
>
>
>however the commit message is from:
>
>commit 25cec756891e8733433efea63b2254ddc93aa5cc
>Author: Matthias Kaehlcke <mka@chromium.org>
>Date:   Tue Jun 18 14:14:40 2019 -0700
>
>    net/ipv4: fib_trie: Avoid cryptic ternary expressions
>
>
>Other than that the stable port also is missing a Signed-off-by tag
>from Nathan.
>
>Looks like the patch didn't actually make it into -stable yet? If that
>is correct we should be in time to fix it up before it becomes part of
>the git history.

Right, it was an issue with my script which is now fixed. I've also
fixed up the stable tree. Thanks for pointing it out.

--
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-30 22:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 20:20 Kernel patch commit message and content do differ Toralf Förster
2019-07-29 20:42 ` Matthias Kaehlcke
2019-07-30 22:29   ` Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.