From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B32C32751 for ; Wed, 31 Jul 2019 07:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 418CE20693 for ; Wed, 31 Jul 2019 07:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfGaHjQ (ORCPT ); Wed, 31 Jul 2019 03:39:16 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45423 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbfGaHjP (ORCPT ); Wed, 31 Jul 2019 03:39:15 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hsjCb-0001qz-9h; Wed, 31 Jul 2019 09:39:13 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hsjCa-00075J-GH; Wed, 31 Jul 2019 09:39:12 +0200 Date: Wed, 31 Jul 2019 09:39:12 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Greg Kroah-Hartman Cc: Stephen Boyd , linux-kernel@vger.kernel.org, Thierry Reding , linux-pwm@vger.kernel.org Subject: Re: [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() Message-ID: <20190731073912.7wb4tb42572g35c6@pengutronix.de> References: <20190730181557.90391-1-swboyd@chromium.org> <20190730181557.90391-37-swboyd@chromium.org> <20190731065853.3ohrhqtjtuhxfq5r@pengutronix.de> <20190731071301.GA23317@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190731071301.GA23317@kroah.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 09:13:01AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 31, 2019 at 08:58:53AM +0200, Uwe Kleine-König wrote: > > On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > > > We don't need dev_err() messages when platform_get_irq() fails now that > > > platform_get_irq() prints an error message itself when something goes > > > wrong. Let's remove these prints with a simple semantic patch. > > > > Looking at v5.3-rc2 it's not obvious to me that all error paths of > > platform_get_irq issue an error message. Do I miss something? > > The commit is in my driver-core tree at the moment, so this should wait > until 5.4-rc1. I woudn't recommend merging it in 5.3-rc as it's not a > bugfix. As this is a new change pointing out its id in the commit log of the follow up changes might be beneficial. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |