From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF15C433FF for ; Wed, 31 Jul 2019 12:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52AFF2089E for ; Wed, 31 Jul 2019 12:35:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727813AbfGaMfj (ORCPT ); Wed, 31 Jul 2019 08:35:39 -0400 Received: from foss.arm.com ([217.140.110.172]:45742 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726259AbfGaMfj (ORCPT ); Wed, 31 Jul 2019 08:35:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22F17344; Wed, 31 Jul 2019 05:35:39 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFE023F575; Wed, 31 Jul 2019 05:35:37 -0700 (PDT) Date: Wed, 31 Jul 2019 13:35:33 +0100 From: Mark Rutland To: Viresh Kumar Cc: stable@vger.kernel.org, Julien Thierry , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Marc Zyngier , Will Deacon , Russell King , Vincent Guittot , mark.brown@arm.com Subject: Re: [PATCH v4.4 V2 15/43] arm64: Move cpu_die_early to smp.c Message-ID: <20190731123532.GA39768@lakrids.cambridge.arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jul 12, 2019 at 10:58:03AM +0530, Viresh Kumar wrote: > From: Suzuki K Poulose > > commit fce6361fe9b0caeba0c05b7d72ceda406f8780df upstream. > > This patch moves cpu_die_early to smp.c, where it fits better. > No functional changes, except for adding the necessary checks > for CONFIG_HOTPLUG_CPU. > > Cc: Mark Rutland > Acked-by: Will Deacon > Signed-off-by: Suzuki K Poulose > Signed-off-by: Catalin Marinas > [ Viresh: Resolved rebase conflict ] > Signed-off-by: Viresh Kumar > +void cpu_die_early(void) > + asm( > + "1: wfe\n" > + " wfi\n" > + " b 1b"); > +} Rather than open-coding this loop differently from upstream and the v4.9.y backport, please backport commit: c4bc34d20273db69 ("arm64: Add a helper for parking CPUs in a loop") ... as a prerequisite of this patch. Otherwise, this looks fine to me. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF193C433FF for ; Wed, 31 Jul 2019 12:35:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AE6320693 for ; Wed, 31 Jul 2019 12:35:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z6tGnSz+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AE6320693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jVDU2gVdWMGQhOK3+E/aBrKksfZhdgUgJku34f0S/84=; b=Z6tGnSz+jeZvIp ObD8CGkJkeMa2M8530vX+1DggpDUfEfo///MaXTyw+6OOo8Aern7r9jmaXwE6rcR2b1hPwZyUi4Pj 1wUNjqfL/VqALaIOhKLwgSFquT9vJTxW7uH4w2jeMBMf4ln+CiSbHeJ7+kSWECfSE8MLP0T6OQZRu 3YoUUUDLm2TkCh/qFRnlgDDOGXIHSl+ywMQnnFPu1kLHU7JJx9fM17r46jXlHGCiWvUQcsponsy9b VLqANcyttGtolQFWT3UtvNReeTtBuv1jOVljX3hcVBL48rizjhTXD2FeUXKqD5RmrFQ/LvY4dRypM jK9MuDKi+CJ4Wz/nEETg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsnpX-0005BM-QJ; Wed, 31 Jul 2019 12:35:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsnpU-0005B2-EF for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2019 12:35:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22F17344; Wed, 31 Jul 2019 05:35:39 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFE023F575; Wed, 31 Jul 2019 05:35:37 -0700 (PDT) Date: Wed, 31 Jul 2019 13:35:33 +0100 From: Mark Rutland To: Viresh Kumar Subject: Re: [PATCH v4.4 V2 15/43] arm64: Move cpu_die_early to smp.c Message-ID: <20190731123532.GA39768@lakrids.cambridge.arm.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190731_053540_524775_5EB98149 X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Thierry , Marc Zyngier , Catalin Marinas , Will Deacon , stable@vger.kernel.org, mark.brown@arm.com, Russell King , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 12, 2019 at 10:58:03AM +0530, Viresh Kumar wrote: > From: Suzuki K Poulose > > commit fce6361fe9b0caeba0c05b7d72ceda406f8780df upstream. > > This patch moves cpu_die_early to smp.c, where it fits better. > No functional changes, except for adding the necessary checks > for CONFIG_HOTPLUG_CPU. > > Cc: Mark Rutland > Acked-by: Will Deacon > Signed-off-by: Suzuki K Poulose > Signed-off-by: Catalin Marinas > [ Viresh: Resolved rebase conflict ] > Signed-off-by: Viresh Kumar > +void cpu_die_early(void) > + asm( > + "1: wfe\n" > + " wfi\n" > + " b 1b"); > +} Rather than open-coding this loop differently from upstream and the v4.9.y backport, please backport commit: c4bc34d20273db69 ("arm64: Add a helper for parking CPUs in a loop") ... as a prerequisite of this patch. Otherwise, this looks fine to me. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel