From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD64C32751 for ; Wed, 31 Jul 2019 13:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE201208C3 for ; Wed, 31 Jul 2019 13:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729272AbfGaNP1 (ORCPT ); Wed, 31 Jul 2019 09:15:27 -0400 Received: from foss.arm.com ([217.140.110.172]:47038 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbfGaNP1 (ORCPT ); Wed, 31 Jul 2019 09:15:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B068C344; Wed, 31 Jul 2019 06:15:26 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B5E03F575; Wed, 31 Jul 2019 06:15:26 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 2D5EC680205; Wed, 31 Jul 2019 14:15:25 +0100 (BST) Date: Wed, 31 Jul 2019 14:15:25 +0100 From: Liviu Dudau To: "Lowry Li (Arm Technology China)" Cc: "james qian wang (Arm Technology China)" , "maarten.lankhorst@linux.intel.com" , "seanpaul@chromium.org" , "airlied@linux.ie" , "daniel@ffwll.ch" , Brian Starkey , "Julien Yin (Arm Technology China)" , "maxime.ripard@bootlin.com" , "eric@anholt.net" , "kieran.bingham+renesas@ideasonboard.com" , "sean@poorly.run" , "laurent.pinchart@ideasonboard.com" , "Jonathan Chai (Arm Technology China)" , Ayan Halder , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , nd Subject: Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled Message-ID: <20190731131525.vjnkbnbatb5tbuzh@e110455-lin.cambridge.arm.com> References: <1564571048-15029-1-git-send-email-lowry.li@arm.com> <1564571048-15029-3-git-send-email-lowry.li@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1564571048-15029-3-git-send-email-lowry.li@arm.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lowry, On Wed, Jul 31, 2019 at 11:04:45AM +0000, Lowry Li (Arm Technology China) wrote: > During it signals the completion of a writeback job, after releasing > the out_fence, we'd clear the pointer. > > Check if fence left over in drm_writeback_cleanup_job(), release it. > > Signed-off-by: Lowry Li (Arm Technology China) > --- > drivers/gpu/drm/drm_writeback.c | 23 +++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c > index ff138b6..43d9e3b 100644 > --- a/drivers/gpu/drm/drm_writeback.c > +++ b/drivers/gpu/drm/drm_writeback.c > @@ -324,6 +324,9 @@ void drm_writeback_cleanup_job(struct drm_writeback_job *job) > if (job->fb) > drm_framebuffer_put(job->fb); > > + if (job->out_fence) > + dma_fence_put(job->out_fence); > + > kfree(job); > } This change looks good. > EXPORT_SYMBOL(drm_writeback_cleanup_job); > @@ -366,25 +369,29 @@ static void cleanup_work(struct work_struct *work) > { > unsigned long flags; > struct drm_writeback_job *job; > + struct dma_fence *out_fence; > > spin_lock_irqsave(&wb_connector->job_lock, flags); > job = list_first_entry_or_null(&wb_connector->job_queue, > struct drm_writeback_job, > list_entry); > - if (job) { > + if (job) > list_del(&job->list_entry); > - if (job->out_fence) { > - if (status) > - dma_fence_set_error(job->out_fence, status); > - dma_fence_signal(job->out_fence); > - dma_fence_put(job->out_fence); *Here* > - } > - } > + > spin_unlock_irqrestore(&wb_connector->job_lock, flags); > > if (WARN_ON(!job)) > return; > > + out_fence = job->out_fence; > + if (out_fence) { > + if (status) > + dma_fence_set_error(out_fence, status); > + dma_fence_signal(out_fence); > + dma_fence_put(out_fence); > + job->out_fence = NULL; > + } > + I don't get the point of this change. Why not just add job->out_fence = NULL where *Here* is? Best regards, Liviu > INIT_WORK(&job->cleanup_work, cleanup_work); > queue_work(system_long_wq, &job->cleanup_work); > } > -- > 1.9.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled Date: Wed, 31 Jul 2019 14:15:25 +0100 Message-ID: <20190731131525.vjnkbnbatb5tbuzh@e110455-lin.cambridge.arm.com> References: <1564571048-15029-1-git-send-email-lowry.li@arm.com> <1564571048-15029-3-git-send-email-lowry.li@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 1444289CE3 for ; Wed, 31 Jul 2019 13:15:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1564571048-15029-3-git-send-email-lowry.li@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Lowry Li (Arm Technology China)" Cc: "linux-renesas-soc@vger.kernel.org" , nd , "airlied@linux.ie" , "Jonathan Chai (Arm Technology China)" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Julien Yin (Arm Technology China)" , "maxime.ripard@bootlin.com" , "kieran.bingham+renesas@ideasonboard.com" , "seanpaul@chromium.org" , "laurent.pinchart@ideasonboard.com" , "james qian wang (Arm Technology China)" , Ayan Halder , "sean@poorly.run" List-Id: dri-devel@lists.freedesktop.org SGkgTG93cnksCgpPbiBXZWQsIEp1bCAzMSwgMjAxOSBhdCAxMTowNDo0NUFNICswMDAwLCBMb3dy eSBMaSAoQXJtIFRlY2hub2xvZ3kgQ2hpbmEpIHdyb3RlOgo+IER1cmluZyBpdCBzaWduYWxzIHRo ZSBjb21wbGV0aW9uIG9mIGEgd3JpdGViYWNrIGpvYiwgYWZ0ZXIgcmVsZWFzaW5nCj4gdGhlIG91 dF9mZW5jZSwgd2UnZCBjbGVhciB0aGUgcG9pbnRlci4KPiAKPiBDaGVjayBpZiBmZW5jZSBsZWZ0 IG92ZXIgaW4gZHJtX3dyaXRlYmFja19jbGVhbnVwX2pvYigpLCByZWxlYXNlIGl0Lgo+IAo+IFNp Z25lZC1vZmYtYnk6IExvd3J5IExpIChBcm0gVGVjaG5vbG9neSBDaGluYSkgPGxvd3J5LmxpQGFy bS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fd3JpdGViYWNrLmMgfCAyMyArKysr KysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwg OCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV93cml0 ZWJhY2suYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fd3JpdGViYWNrLmMKPiBpbmRleCBmZjEzOGI2 Li40M2Q5ZTNiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fd3JpdGViYWNrLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3dyaXRlYmFjay5jCj4gQEAgLTMyNCw2ICszMjQs OSBAQCB2b2lkIGRybV93cml0ZWJhY2tfY2xlYW51cF9qb2Ioc3RydWN0IGRybV93cml0ZWJhY2tf am9iICpqb2IpCj4gIAlpZiAoam9iLT5mYikKPiAgCQlkcm1fZnJhbWVidWZmZXJfcHV0KGpvYi0+ ZmIpOwo+ICAKPiArCWlmIChqb2ItPm91dF9mZW5jZSkKPiArCQlkbWFfZmVuY2VfcHV0KGpvYi0+ b3V0X2ZlbmNlKTsKPiArCj4gIAlrZnJlZShqb2IpOwo+ICB9CgpUaGlzIGNoYW5nZSBsb29rcyBn b29kLgoKPiAgRVhQT1JUX1NZTUJPTChkcm1fd3JpdGViYWNrX2NsZWFudXBfam9iKTsKPiBAQCAt MzY2LDI1ICszNjksMjkgQEAgc3RhdGljIHZvaWQgY2xlYW51cF93b3JrKHN0cnVjdCB3b3JrX3N0 cnVjdCAqd29yaykKPiAgewo+ICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPiAgCXN0cnVjdCBkcm1f d3JpdGViYWNrX2pvYiAqam9iOwo+ICsJc3RydWN0IGRtYV9mZW5jZSAqb3V0X2ZlbmNlOwo+ICAK PiAgCXNwaW5fbG9ja19pcnFzYXZlKCZ3Yl9jb25uZWN0b3ItPmpvYl9sb2NrLCBmbGFncyk7Cj4g IAlqb2IgPSBsaXN0X2ZpcnN0X2VudHJ5X29yX251bGwoJndiX2Nvbm5lY3Rvci0+am9iX3F1ZXVl LAo+ICAJCQkJICAgICAgIHN0cnVjdCBkcm1fd3JpdGViYWNrX2pvYiwKPiAgCQkJCSAgICAgICBs aXN0X2VudHJ5KTsKPiAtCWlmIChqb2IpIHsKPiArCWlmIChqb2IpCj4gIAkJbGlzdF9kZWwoJmpv Yi0+bGlzdF9lbnRyeSk7Cj4gLQkJaWYgKGpvYi0+b3V0X2ZlbmNlKSB7Cj4gLQkJCWlmIChzdGF0 dXMpCj4gLQkJCQlkbWFfZmVuY2Vfc2V0X2Vycm9yKGpvYi0+b3V0X2ZlbmNlLCBzdGF0dXMpOwo+ IC0JCQlkbWFfZmVuY2Vfc2lnbmFsKGpvYi0+b3V0X2ZlbmNlKTsKPiAtCQkJZG1hX2ZlbmNlX3B1 dChqb2ItPm91dF9mZW5jZSk7CgoqSGVyZSoKCj4gLQkJfQo+IC0JfQo+ICsKPiAgCXNwaW5fdW5s b2NrX2lycXJlc3RvcmUoJndiX2Nvbm5lY3Rvci0+am9iX2xvY2ssIGZsYWdzKTsKPiAgCj4gIAlp ZiAoV0FSTl9PTigham9iKSkKPiAgCQlyZXR1cm47Cj4gIAo+ICsJb3V0X2ZlbmNlID0gam9iLT5v dXRfZmVuY2U7Cj4gKwlpZiAob3V0X2ZlbmNlKSB7Cj4gKwkJaWYgKHN0YXR1cykKPiArCQkJZG1h X2ZlbmNlX3NldF9lcnJvcihvdXRfZmVuY2UsIHN0YXR1cyk7Cj4gKwkJZG1hX2ZlbmNlX3NpZ25h bChvdXRfZmVuY2UpOwo+ICsJCWRtYV9mZW5jZV9wdXQob3V0X2ZlbmNlKTsKPiArCQlqb2ItPm91 dF9mZW5jZSA9IE5VTEw7Cj4gKwl9Cj4gKwoKSSBkb24ndCBnZXQgdGhlIHBvaW50IG9mIHRoaXMg Y2hhbmdlLiBXaHkgbm90IGp1c3QgYWRkIGpvYi0+b3V0X2ZlbmNlID0gTlVMTAp3aGVyZSAqSGVy ZSogaXM/CgpCZXN0IHJlZ2FyZHMsCkxpdml1IAoKPiAgCUlOSVRfV09SSygmam9iLT5jbGVhbnVw X3dvcmssIGNsZWFudXBfd29yayk7Cj4gIAlxdWV1ZV93b3JrKHN5c3RlbV9sb25nX3dxLCAmam9i LT5jbGVhbnVwX3dvcmspOwo+ICB9Cj4gLS0gCj4gMS45LjEKPiAKCi0tIAo9PT09PT09PT09PT09 PT09PT09PQp8IEkgd291bGQgbGlrZSB0byB8CnwgZml4IHRoZSB3b3JsZCwgIHwKfCBidXQgdGhl eSdyZSBub3QgfAp8IGdpdmluZyBtZSB0aGUgICB8CiBcIHNvdXJjZSBjb2RlISAgLwogIC0tLS0t LS0tLS0tLS0tLQogICAgwq9cXyjjg4QpXy/CrwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw=