From: Anthony PERARD <anthony.perard@citrix.com>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Artem Mygaiev <Artem_Mygaiev@epam.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Lars Kurth <lars.kurth.xen@gmail.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"Tim \(Xen.org\)" <tim@xen.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
'Jan Beulich' <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Viktor Mitin <viktor.mitin.19@gmail.com>
Subject: Re: [Xen-devel] [PATCH] CODING_STYLE: clarify function argument indentation
Date: Thu, 1 Aug 2019 10:55:00 +0100 [thread overview]
Message-ID: <20190801095500.GB5791@perard.uk.xensource.com> (raw)
In-Reply-To: <8736imhyt0.fsf@epam.com>
On Wed, Jul 31, 2019 at 05:57:32PM +0000, Volodymyr Babchuk wrote:
> Lars Kurth writes:
> > Ultimately we have to make some trade-offs as to what is more important:
> > a) automatic style checking - which means "common sense" can't be formalised and there will be boundary cases like the above
> > b) reclaiming code review bandwidth through automation or going for a labour intensive manual approach
> I like the linux kernel approach. checkpatch.pl produces errors, which are
> "no go", but it also produces warnings for such boundary cases, for
> maintainer/reviewer to decide.
Yes! QEMU also uses checkpatch.pl script and I found that very useful
(both as reviewer and author of a patch). It tells you what are the
coding style violation in newly added code and doesn't try to reformat
the whole file.
But that script would needs quite a lot of rewriting, I think, to be
able to be used on the multiple coding style of xen.git.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-01 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:24 [Xen-devel] [PATCH] CODING_STYLE: clarify function argument indentation Volodymyr Babchuk
2019-07-31 16:45 ` Andrew Cooper
2019-07-31 16:54 ` Viktor Mitin
2019-07-31 17:05 ` Lars Kurth
2019-07-31 17:57 ` Volodymyr Babchuk
2019-08-01 9:55 ` Anthony PERARD [this message]
2019-08-01 10:07 ` Juergen Gross
2019-07-31 17:49 ` Volodymyr Babchuk
2019-07-31 18:10 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801095500.GB5791@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=Artem_Mygaiev@epam.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.kurth.xen@gmail.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=viktor.mitin.19@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.