From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E3AC433FF for ; Thu, 1 Aug 2019 09:58:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 635012171F for ; Thu, 1 Aug 2019 09:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730098AbfHAJ6m (ORCPT ); Thu, 1 Aug 2019 05:58:42 -0400 Received: from foss.arm.com ([217.140.110.172]:33278 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbfHAJ6l (ORCPT ); Thu, 1 Aug 2019 05:58:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70FD01570; Thu, 1 Aug 2019 02:58:40 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C2893F694; Thu, 1 Aug 2019 02:58:40 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id DF2E86802BE; Thu, 1 Aug 2019 10:58:38 +0100 (BST) Date: Thu, 1 Aug 2019 10:58:38 +0100 From: Liviu Dudau To: "Lowry Li (Arm Technology China)" Cc: "james qian wang (Arm Technology China)" , "maarten.lankhorst@linux.intel.com" , "seanpaul@chromium.org" , "airlied@linux.ie" , "daniel@ffwll.ch" , Brian Starkey , "Julien Yin (Arm Technology China)" , "maxime.ripard@bootlin.com" , "eric@anholt.net" , "kieran.bingham+renesas@ideasonboard.com" , "sean@poorly.run" , "laurent.pinchart@ideasonboard.com" , "Jonathan Chai (Arm Technology China)" , Ayan Halder , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , nd Subject: Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled Message-ID: <20190801095838.2dy4nmipct3qmohc@e110455-lin.cambridge.arm.com> References: <1564571048-15029-1-git-send-email-lowry.li@arm.com> <1564571048-15029-3-git-send-email-lowry.li@arm.com> <20190731131525.vjnkbnbatb5tbuzh@e110455-lin.cambridge.arm.com> <20190801063055.GA17887@lowry.li@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190801063055.GA17887@lowry.li@arm.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2019 at 06:31:13AM +0000, Lowry Li (Arm Technology China) wrote: > Hi Liviu, > > On Wed, Jul 31, 2019 at 01:15:25PM +0000, Liviu Dudau wrote: > > Hi Lowry, > > > > On Wed, Jul 31, 2019 at 11:04:45AM +0000, Lowry Li (Arm Technology China) wrote: > > > During it signals the completion of a writeback job, after releasing > > > the out_fence, we'd clear the pointer. > > > > > > Check if fence left over in drm_writeback_cleanup_job(), release it. > > > > > > Signed-off-by: Lowry Li (Arm Technology China) > > > --- > > > drivers/gpu/drm/drm_writeback.c | 23 +++++++++++++++-------- > > > 1 file changed, 15 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c > > > index ff138b6..43d9e3b 100644 > > > --- a/drivers/gpu/drm/drm_writeback.c > > > +++ b/drivers/gpu/drm/drm_writeback.c > > > @@ -324,6 +324,9 @@ void drm_writeback_cleanup_job(struct drm_writeback_job *job) > > > if (job->fb) > > > drm_framebuffer_put(job->fb); > > > > > > + if (job->out_fence) > > > + dma_fence_put(job->out_fence); > > > + > > > kfree(job); > > > } > > > > This change looks good. > > > > > EXPORT_SYMBOL(drm_writeback_cleanup_job); > > > @@ -366,25 +369,29 @@ static void cleanup_work(struct work_struct *work) > > > { > > > unsigned long flags; > > > struct drm_writeback_job *job; > > > + struct dma_fence *out_fence; > > > > > > spin_lock_irqsave(&wb_connector->job_lock, flags); > > > job = list_first_entry_or_null(&wb_connector->job_queue, > > > struct drm_writeback_job, > > > list_entry); > > > - if (job) { > > > + if (job) > > > list_del(&job->list_entry); > > > - if (job->out_fence) { > > > - if (status) > > > - dma_fence_set_error(job->out_fence, status); > > > - dma_fence_signal(job->out_fence); > > > - dma_fence_put(job->out_fence); > > > > *Here* > > > > > - } > > > - } > > > + > > > spin_unlock_irqrestore(&wb_connector->job_lock, flags); > > > > > > if (WARN_ON(!job)) > > > return; > > > > > > + out_fence = job->out_fence; > > > + if (out_fence) { > > > + if (status) > > > + dma_fence_set_error(out_fence, status); > > > + dma_fence_signal(out_fence); > > > + dma_fence_put(out_fence); > > > + job->out_fence = NULL; > > > + } > > > + > > > > I don't get the point of this change. Why not just add job->out_fence = NULL > > where *Here* is? > > > > Best regards, > > Liviu > Besides setting NULL, also did a refine by moving the fence operation > out of the lock block. OK, now it makes sense. May I suggest you add that to the commit message? Otherwise, Acked-by: Liviu Dudau Best regards, Liviu > > Best regards, > Lowry > > > INIT_WORK(&job->cleanup_work, cleanup_work); > > > queue_work(system_long_wq, &job->cleanup_work); > > > } > > > -- > > > 1.9.1 > > > > > > > -- > > ==================== > > | I would like to | > > | fix the world, | > > | but they're not | > > | giving me the | > > \ source code! / > > --------------- > > ¯\_(ツ)_/¯ > > -- > Regards, > Lowry -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled Date: Thu, 1 Aug 2019 10:58:38 +0100 Message-ID: <20190801095838.2dy4nmipct3qmohc@e110455-lin.cambridge.arm.com> References: <1564571048-15029-1-git-send-email-lowry.li@arm.com> <1564571048-15029-3-git-send-email-lowry.li@arm.com> <20190731131525.vjnkbnbatb5tbuzh@e110455-lin.cambridge.arm.com> <20190801063055.GA17887@lowry.li@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190801063055.GA17887@lowry.li@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: "Lowry Li (Arm Technology China)" Cc: "james qian wang (Arm Technology China)" , "maarten.lankhorst@linux.intel.com" , "seanpaul@chromium.org" , "airlied@linux.ie" , "daniel@ffwll.ch" , Brian Starkey , "Julien Yin (Arm Technology China)" , "maxime.ripard@bootlin.com" , "eric@anholt.net" , "kieran.bingham+renesas@ideasonboard.com" , "sean@poorly.run" , "laurent.pinchart@ideasonboard.com" , "Jonathan Chai (Arm Technology China)" , Ayan Halder , dri-d List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 01, 2019 at 06:31:13AM +0000, Lowry Li (Arm Technology China) wrote: > Hi Liviu, > > On Wed, Jul 31, 2019 at 01:15:25PM +0000, Liviu Dudau wrote: > > Hi Lowry, > > > > On Wed, Jul 31, 2019 at 11:04:45AM +0000, Lowry Li (Arm Technology China) wrote: > > > During it signals the completion of a writeback job, after releasing > > > the out_fence, we'd clear the pointer. > > > > > > Check if fence left over in drm_writeback_cleanup_job(), release it. > > > > > > Signed-off-by: Lowry Li (Arm Technology China) > > > --- > > > drivers/gpu/drm/drm_writeback.c | 23 +++++++++++++++-------- > > > 1 file changed, 15 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c > > > index ff138b6..43d9e3b 100644 > > > --- a/drivers/gpu/drm/drm_writeback.c > > > +++ b/drivers/gpu/drm/drm_writeback.c > > > @@ -324,6 +324,9 @@ void drm_writeback_cleanup_job(struct drm_writeback_job *job) > > > if (job->fb) > > > drm_framebuffer_put(job->fb); > > > > > > + if (job->out_fence) > > > + dma_fence_put(job->out_fence); > > > + > > > kfree(job); > > > } > > > > This change looks good. > > > > > EXPORT_SYMBOL(drm_writeback_cleanup_job); > > > @@ -366,25 +369,29 @@ static void cleanup_work(struct work_struct *work) > > > { > > > unsigned long flags; > > > struct drm_writeback_job *job; > > > + struct dma_fence *out_fence; > > > > > > spin_lock_irqsave(&wb_connector->job_lock, flags); > > > job = list_first_entry_or_null(&wb_connector->job_queue, > > > struct drm_writeback_job, > > > list_entry); > > > - if (job) { > > > + if (job) > > > list_del(&job->list_entry); > > > - if (job->out_fence) { > > > - if (status) > > > - dma_fence_set_error(job->out_fence, status); > > > - dma_fence_signal(job->out_fence); > > > - dma_fence_put(job->out_fence); > > > > *Here* > > > > > - } > > > - } > > > + > > > spin_unlock_irqrestore(&wb_connector->job_lock, flags); > > > > > > if (WARN_ON(!job)) > > > return; > > > > > > + out_fence = job->out_fence; > > > + if (out_fence) { > > > + if (status) > > > + dma_fence_set_error(out_fence, status); > > > + dma_fence_signal(out_fence); > > > + dma_fence_put(out_fence); > > > + job->out_fence = NULL; > > > + } > > > + > > > > I don't get the point of this change. Why not just add job->out_fence = NULL > > where *Here* is? > > > > Best regards, > > Liviu > Besides setting NULL, also did a refine by moving the fence operation > out of the lock block. OK, now it makes sense. May I suggest you add that to the commit message? Otherwise, Acked-by: Liviu Dudau Best regards, Liviu > > Best regards, > Lowry > > > INIT_WORK(&job->cleanup_work, cleanup_work); > > > queue_work(system_long_wq, &job->cleanup_work); > > > } > > > -- > > > 1.9.1 > > > > > > > -- > > ==================== > > | I would like to | > > | fix the world, | > > | but they're not | > > | giving me the | > > \ source code! / > > --------------- > > ¯\_(ツ)_/¯ > > -- > Regards, > Lowry -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯