From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09219C32750 for ; Fri, 2 Aug 2019 13:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB78F20679 for ; Fri, 2 Aug 2019 13:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404106AbfHBNDY convert rfc822-to-8bit (ORCPT ); Fri, 2 Aug 2019 09:03:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:52864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389446AbfHBNDY (ORCPT ); Fri, 2 Aug 2019 09:03:24 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1A4D20657; Fri, 2 Aug 2019 13:03:22 +0000 (UTC) Date: Fri, 2 Aug 2019 09:03:20 -0400 From: Steven Rostedt To: Jiping Ma Cc: Will Deacon , , , , , , Subject: Re: [PATCH v2] tracing: Function stack size and its name mismatch in arm64 Message-ID: <20190802090320.728f133b@gandalf.local.home> In-Reply-To: <47e90170-e971-c2f5-b6c9-d3c6a694a4a7@windriver.com> References: <20190801083340.57075-1-jiping.ma2@windriver.com> <20190801094156.emo36ekvrm74nndl@willie-the-truck> <47e90170-e971-c2f5-b6c9-d3c6a694a4a7@windriver.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Aug 2019 10:43:03 +0800 Jiping Ma wrote: > > *Why* does the frame appear to be off-by-one? > Because the PC is LR in ARM64 stack actually.  Following is ARM64 stack > layout. Please refer to the figure 3 in > http://infocenter.arm.com/help/topic/com.arm.doc.ihi0055b/IHI0055B_aapcs64.pdf >             LR >             FP >             ...... >             LR >             FP And the LR holds the return address, right? Which would be identical to x86 and every other arch I know about. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BDC7C41514 for ; Fri, 2 Aug 2019 13:03:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5377B20657 for ; Fri, 2 Aug 2019 13:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RMq6b1if" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5377B20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4VZqqYMGuNkuqFEFeNsldmJejcdfDD+09othbzhAwxc=; b=RMq6b1ifeIqOT1 6mnfBdlitcEhve5GYUsoTne6AlMMO4w84L0sWcfFkOOGTDd8KN+STY7R64rGrIhrPnyQgzv9Y8dBK KB4sDzh4pok2GEAV5HYGcp9e2zriRDnz2lr4bHzWLQNMpiQ1p6JLh067ID3bBmKND4TXUUyI/Huy7 tKOeWeY8Stilxa1iuGPMnpSiOWia5RLls4TVnLY1yuE/CsBw3etOvENWPP1PgT8MiXLXksp/sW+Bn NJCrZHg6nT5H2OGunigBuLlNeWBR0suc6H7TN3cGUtLsIrpA5hNxl8JQgqc0TQAtUf3fV6jNCGHPM ccVDdnuvTY04rntveBzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htXDU-0005pE-S7; Fri, 02 Aug 2019 13:03:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1htXDR-0005oY-8E for linux-arm-kernel@lists.infradead.org; Fri, 02 Aug 2019 13:03:26 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1A4D20657; Fri, 2 Aug 2019 13:03:22 +0000 (UTC) Date: Fri, 2 Aug 2019 09:03:20 -0400 From: Steven Rostedt To: Jiping Ma Subject: Re: [PATCH v2] tracing: Function stack size and its name mismatch in arm64 Message-ID: <20190802090320.728f133b@gandalf.local.home> In-Reply-To: <47e90170-e971-c2f5-b6c9-d3c6a694a4a7@windriver.com> References: <20190801083340.57075-1-jiping.ma2@windriver.com> <20190801094156.emo36ekvrm74nndl@willie-the-truck> <47e90170-e971-c2f5-b6c9-d3c6a694a4a7@windriver.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190802_060325_313669_D2AD2587 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, mingo@redhat.com, joel@joelfernandes.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyIEF1ZyAyMDE5IDEwOjQzOjAzICswODAwCkppcGluZyBNYSA8SmlwaW5nLk1hMkB3 aW5kcml2ZXIuY29tPiB3cm90ZToKCj4gPiAqV2h5KiBkb2VzIHRoZSBmcmFtZSBhcHBlYXIgdG8g YmUgb2ZmLWJ5LW9uZT8gIAo+IEJlY2F1c2UgdGhlIFBDIGlzIExSIGluIEFSTTY0IHN0YWNrIGFj dHVhbGx5LsKgIEZvbGxvd2luZyBpcyBBUk02NCBzdGFjayAKPiBsYXlvdXQuIFBsZWFzZSByZWZl ciB0byB0aGUgZmlndXJlIDMgaW4gCj4gaHR0cDovL2luZm9jZW50ZXIuYXJtLmNvbS9oZWxwL3Rv cGljL2NvbS5hcm0uZG9jLmloaTAwNTViL0lISTAwNTVCX2FhcGNzNjQucGRmCj4gIMKgwqDCoCDC oMKgwqAgwqDCoMKgIExSCj4gIMKgwqDCoCDCoMKgwqAgwqDCoMKgIEZQCj4gIMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgLi4uLi4uCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgTFIKPiAgwqDCoMKg IMKgwqDCoCDCoMKgwqAgRlAKCkFuZCB0aGUgTFIgaG9sZHMgdGhlIHJldHVybiBhZGRyZXNzLCBy aWdodD8gV2hpY2ggd291bGQgYmUgaWRlbnRpY2FsIHRvCng4NiBhbmQgZXZlcnkgb3RoZXIgYXJj aCBJIGtub3cgYWJvdXQuCgotLSBTdGV2ZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=