From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8A6C32750 for ; Fri, 2 Aug 2019 09:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAC7D2064A for ; Fri, 2 Aug 2019 09:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564739595; bh=UopGAuB+MwMe7Kfos3DzGTgDnrX771ytZVnZuWACKvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PDl4LCWehi+g3AhK0WtDeqsg0wI2nqBiXfG2cDYqVPZUSge7eqPTF9TovbmgNaPIr 3c5rGRMd8xRunQCJJsTIY+X6FOUHwiPn/UqtVgZlx38orvoIVrMbokPyS67Z9lvmo3 RvPaTJ6zBYjBvn9dDVy7YMRp9BjTB5Ra12A7o9D4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406185AbfHBJxO (ORCPT ); Fri, 2 Aug 2019 05:53:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:59198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406170AbfHBJxN (ORCPT ); Fri, 2 Aug 2019 05:53:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4016206A2; Fri, 2 Aug 2019 09:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564739593; bh=UopGAuB+MwMe7Kfos3DzGTgDnrX771ytZVnZuWACKvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hcQMVXhLpuOIGbTqiwJDKWWpbUzrez0MVl5RzEgr/5FTfV0vfc1RRXfb/J1dd+Y6c VRyrXdVNCxLtM6xXv9X9N/w1CjBqFoi+KBObbRSZB3jxdy4jni08E2aa1leAFiWxGS aieQxcAyuMID9U93FqcH7KKvUQBLiLEtgx1J3WeA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yan, Zheng" , Jeff Layton , Ilya Dryomov Subject: [PATCH 4.9 223/223] ceph: hold i_ceph_lock when removing caps for freeing inode Date: Fri, 2 Aug 2019 11:37:28 +0200 Message-Id: <20190802092250.987972725@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190802092238.692035242@linuxfoundation.org> References: <20190802092238.692035242@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yan, Zheng commit d6e47819721ae2d9d090058ad5570a66f3c42e39 upstream. ceph_d_revalidate(, LOOKUP_RCU) may call __ceph_caps_issued_mask() on a freeing inode. Signed-off-by: "Yan, Zheng" Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/caps.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -1081,20 +1081,23 @@ static int send_cap_msg(struct ceph_mds_ } /* - * Queue cap releases when an inode is dropped from our cache. Since - * inode is about to be destroyed, there is no need for i_ceph_lock. + * Queue cap releases when an inode is dropped from our cache. */ void ceph_queue_caps_release(struct inode *inode) { struct ceph_inode_info *ci = ceph_inode(inode); struct rb_node *p; + /* lock i_ceph_lock, because ceph_d_revalidate(..., LOOKUP_RCU) + * may call __ceph_caps_issued_mask() on a freeing inode. */ + spin_lock(&ci->i_ceph_lock); p = rb_first(&ci->i_caps); while (p) { struct ceph_cap *cap = rb_entry(p, struct ceph_cap, ci_node); p = rb_next(p); __ceph_remove_cap(cap, true); } + spin_unlock(&ci->i_ceph_lock); } /*