All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, marcelo.leitner@gmail.com,
	jiri@resnulli.us, wenxu@ucloud.cn, saeedm@mellanox.com,
	paulb@mellanox.com, gerlitz.or@gmail.com
Subject: Re: [PATCH net 0/2] flow_offload hardware priority fixes
Date: Fri, 2 Aug 2019 13:00:23 +0200	[thread overview]
Message-ID: <20190802110023.udfcxowe3vmihduq@salvia> (raw)
In-Reply-To: <20190801172014.314a9d01@cakuba.netronome.com>

Hi Jakub,

If the user specifies 'pref' in the new rule, then tc checks if there
is a tcf_proto object that matches this priority. If the tcf_proto
object does not exist, tc creates a tcf_proto object and it adds the
new rule to this tcf_proto.

In cls_flower, each tcf_proto only stores one single rule, so if the
user tries to add another rule with the same 'pref', cls_flower
returns EEXIST.

I'll prepare a new patchset not to map the priority to the netfilter
basechain priority, instead the rule priority will be internally
allocated for each new rule.

Thanks for your feedback.

  reply	other threads:[~2019-08-02 11:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 11:28 [PATCH net 0/2] flow_offload hardware priority fixes Pablo Neira Ayuso
2019-08-01 11:28 ` [PATCH net 1/2] net: sched: use major priority number as hardware priority Pablo Neira Ayuso
2019-08-01 11:28 ` [PATCH net 2/2,v3] netfilter: nf_tables: map basechain priority to " Pablo Neira Ayuso
2019-08-02  0:20 ` [PATCH net 0/2] flow_offload hardware priority fixes Jakub Kicinski
2019-08-02 11:00   ` Pablo Neira Ayuso [this message]
2019-08-02 20:47     ` Jakub Kicinski
2019-08-02 22:04       ` Pablo Neira Ayuso
2019-08-02 22:25         ` Jakub Kicinski
2019-08-03  7:08           ` Pablo Neira Ayuso
2019-08-05 19:04             ` Jakub Kicinski
2019-08-06  9:42               ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190802110023.udfcxowe3vmihduq@salvia \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=gerlitz.or@gmail.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@resnulli.us \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=paulb@mellanox.com \
    --cc=saeedm@mellanox.com \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.