All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Jiri Slaby <jslaby@suse.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib
Date: Fri, 2 Aug 2019 14:08:54 +0200	[thread overview]
Message-ID: <20190802120854.k3arbz6pk6n5ayti@pengutronix.de> (raw)
In-Reply-To: <20190802100349.8659-1-frieder.schrempf@kontron.de>

On Fri, Aug 02, 2019 at 10:04:09AM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> If CONFIG_GPIOLIB is not enabled, mctrl_gpio_init() and
> mctrl_gpio_init_noauto() will currently return an error pointer with
> -ENOSYS. As the mctrl GPIOs are usually optional, drivers need to
> check for this condition to allow continue probing.
> 
> To avoid the need for this check in each driver, we return NULL
> instead, as all the mctrl_gpio_*() functions are skipped anyway.
> We also adapt mctrl_gpio_to_gpiod() to be in line with this change.
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Jiri Slaby <jslaby@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib
Date: Fri, 2 Aug 2019 14:08:54 +0200	[thread overview]
Message-ID: <20190802120854.k3arbz6pk6n5ayti@pengutronix.de> (raw)
In-Reply-To: <20190802100349.8659-1-frieder.schrempf@kontron.de>

On Fri, Aug 02, 2019 at 10:04:09AM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> If CONFIG_GPIOLIB is not enabled, mctrl_gpio_init() and
> mctrl_gpio_init_noauto() will currently return an error pointer with
> -ENOSYS. As the mctrl GPIOs are usually optional, drivers need to
> check for this condition to allow continue probing.
> 
> To avoid the need for this check in each driver, we return NULL
> instead, as all the mctrl_gpio_*() functions are skipped anyway.
> We also adapt mctrl_gpio_to_gpiod() to be in line with this change.
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-08-02 12:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 10:04 [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 2/4] serial: mctrl_gpio: Add a NULL check to mctrl_gpio_to_gpiod() Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 12:12   ` Uwe Kleine-König
2019-08-02 12:12     ` Uwe Kleine-König
2019-08-02 12:12     ` Uwe Kleine-König
2019-08-05  9:01     ` Schrempf Frieder
2019-08-05  9:01       ` Schrempf Frieder
2019-08-05  9:01       ` Schrempf Frieder
2019-08-06  7:45       ` Uwe Kleine-König
2019-08-06  7:45         ` Uwe Kleine-König
2019-08-06  7:45         ` Uwe Kleine-König
2019-08-06  8:02         ` Schrempf Frieder
2019-08-06  8:02           ` Schrempf Frieder
2019-08-06  8:02           ` Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 3/4] serial: sh-sci: Don't check for mctrl_gpio_init() returning -ENOSYS Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 12:13   ` Uwe Kleine-König
2019-08-02 12:13     ` Uwe Kleine-König
2019-08-02 12:13     ` Uwe Kleine-König
2019-08-06  8:09   ` Geert Uytterhoeven
2019-08-06  8:09     ` Geert Uytterhoeven
2019-08-06  8:09     ` Geert Uytterhoeven
2019-08-02 10:04 ` [PATCH v3 4/4] serial: 8250: " Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 12:15   ` Uwe Kleine-König
2019-08-02 12:15     ` Uwe Kleine-König
2019-08-02 12:15     ` Uwe Kleine-König
2019-08-02 12:26     ` Greg Kroah-Hartman
2019-08-02 12:26       ` Greg Kroah-Hartman
2019-08-02 12:26       ` Greg Kroah-Hartman
2019-08-06  7:44       ` Uwe Kleine-König
2019-08-06  7:44         ` Uwe Kleine-König
2019-08-06  7:44         ` Uwe Kleine-König
2019-08-02 12:08 ` Uwe Kleine-König [this message]
2019-08-02 12:08   ` [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Uwe Kleine-König
2019-08-02 12:08   ` Uwe Kleine-König
2019-08-06  8:09 ` Geert Uytterhoeven
2019-08-06  8:09   ` Geert Uytterhoeven
2019-08-06  8:09   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190802120854.k3arbz6pk6n5ayti@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.