From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C53AEC433FF for ; Sat, 3 Aug 2019 01:30:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99FE52087E for ; Sat, 3 Aug 2019 01:30:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KGkroKFj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390443AbfHCBag (ORCPT ); Fri, 2 Aug 2019 21:30:36 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52411 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388638AbfHCBag (ORCPT ); Fri, 2 Aug 2019 21:30:36 -0400 Received: by mail-wm1-f68.google.com with SMTP id s3so69540284wms.2; Fri, 02 Aug 2019 18:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ogf+QVoHZtK9iZfwgzb4P/UWGbW9VrBZvDIl55S3hPY=; b=KGkroKFjol78GrJj8Z3aHbKWLMrcSiwfex8ESVqf5pCyjcNBYG+ZPXlzN5iCRO4k4S j+kWSLfRx1gW9uTsbVilRV/mKw5vnJRnyRovCESrqPj485QPsEXeHmM1ohRfevsYjhl+ bVqgoWYlnrNbPYUfDRYgNeFptq0zUwF8iaVEaW6Y91hTzIKVEhttusPL7xNJjagJgfPx Qmm+hhLcyFpZUGNoAb7uaqmLy2yvIu/dqrpx4BAoA8q5ZPCHBLZqpQBELIiFi0jGG2Yl HbTxR+5W2mtoj7+ef493cG+HiMMsq/Ot47bUXyCg3DdLbc7lKcrFA4E477Jh3bin1LxM lI3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ogf+QVoHZtK9iZfwgzb4P/UWGbW9VrBZvDIl55S3hPY=; b=O1LHYWS6RJDdRWCjHBlN665JF4xGb1dkQ9/isMHGDMB2qeoNeHhIgr2MOvkqYbN++6 3Bq61WNDsUgm42Om7WF4akN6DUDe6fwltUTffibie9vhYkOTfgMRI0hXu6ANz/bAcyhi HczY8sRl7k8UpW0kXOXKuMAvCZaknGAboKaie6crVQB5j4A4ZR7YIQhH6556Fn8oatx0 WlJz67Plm0a5h8mry5wr3c9O6X4Pr++Nde9Dp/zfkXvGIXXo1NW0dcGLnoRNzXaB3pHd g/xQr93Z1PT5xID5VzeSPcG546TgjpwW1wt5ihw9H0y50F2cHw0PnIO56VOM1PCCX9Pp gYYA== X-Gm-Message-State: APjAAAWTGH2d5Q+h6+KJN5MDSH3dqF85MU+YOgyV2mPs0VuolgbNaUSz bMkAqaCbkuLAxrS3AWomqtQ= X-Google-Smtp-Source: APXvYqxqjFQJ9s+K2nHgDoEAg28+wlCsmvPhcNE3ueZNH5NsBPgHWuzjZM3lffnaX7s2DnS6f/1HMQ== X-Received: by 2002:a1c:e108:: with SMTP id y8mr6269283wmg.65.1564795833805; Fri, 02 Aug 2019 18:30:33 -0700 (PDT) Received: from archlinux-threadripper ([2a01:4f8:222:2f1b::2]) by smtp.gmail.com with ESMTPSA id c4sm62233010wrt.86.2019.08.02.18.30.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 02 Aug 2019 18:30:33 -0700 (PDT) Date: Fri, 2 Aug 2019 18:30:31 -0700 From: Nathan Chancellor To: David Miller Cc: andrew@lunn.ch, broonie@kernel.org, devel@driverdev.osuosl.org, f.fainelli@gmail.com, gregkh@linuxfoundation.org, hkallweit1@gmail.com, kernel-build-reports@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org, netdev@vger.kernel.org, willy@infradead.org, lkp@intel.com, rdunlap@infradead.org Subject: Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Message-ID: <20190803013031.GA76252@archlinux-threadripper> References: <20190731.094150.851749535529247096.davem@davemloft.net> <20190731185023.20954-1-natechancellor@gmail.com> <20190802.181132.1425585873361511856.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802.181132.1425585873361511856.davem@davemloft.net> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote: > From: Nathan Chancellor > Date: Wed, 31 Jul 2019 11:50:24 -0700 > > > arm allyesconfig warns: > > > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > > Selected by [y]: > > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && > > NETDEVICES [=y] || COMPILE_TEST [=y]) > > > > and errors: > > > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': > > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > > function 'writeq'; did you mean 'writeb'? > > The proper way to fix this is to include either > > linux/io-64-nonatomic-hi-lo.h > > or > > linux/io-64-nonatomic-lo-hi.h > > whichever is appropriate. Hmmmm, is that not what I did? Although I did not know about io-64-nonatomic-hi-lo.h. What is the difference and which one is needed here? There is apparently another failure when OF_MDIO is not set, I guess I can try to look into that as well and respin into a series if necessary. Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 From: natechancellor@gmail.com (Nathan Chancellor) Date: Fri, 2 Aug 2019 18:30:31 -0700 Subject: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning In-Reply-To: <20190802.181132.1425585873361511856.davem@davemloft.net> References: <20190731.094150.851749535529247096.davem@davemloft.net> <20190731185023.20954-1-natechancellor@gmail.com> <20190802.181132.1425585873361511856.davem@davemloft.net> Message-ID: <20190803013031.GA76252@archlinux-threadripper> List-Id: Linux Driver Project Developer List On Fri, Aug 02, 2019@06:11:32PM -0700, David Miller wrote: > From: Nathan Chancellor > Date: Wed, 31 Jul 2019 11:50:24 -0700 > > > arm allyesconfig warns: > > > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > > Selected by [y]: > > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && > > NETDEVICES [=y] || COMPILE_TEST [=y]) > > > > and errors: > > > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': > > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > > function 'writeq'; did you mean 'writeb'? > > The proper way to fix this is to include either > > linux/io-64-nonatomic-hi-lo.h > > or > > linux/io-64-nonatomic-lo-hi.h > > whichever is appropriate. Hmmmm, is that not what I did? Although I did not know about io-64-nonatomic-hi-lo.h. What is the difference and which one is needed here? There is apparently another failure when OF_MDIO is not set, I guess I can try to look into that as well and respin into a series if necessary. Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC47C0650F for ; Sat, 3 Aug 2019 01:30:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E53312087E for ; Sat, 3 Aug 2019 01:30:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lY4Ymd1d"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KGkroKFj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E53312087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KLO+/NlcmyDZG/1JWQ32Wv2+iOPKKAWLDoBU6JK3J1w=; b=lY4Ymd1dHw441a SI2pcpf32nfD+7kEJB4D5TxNPJNvSCJ0KhLG70+vxuZwm2GAaCSLMZyVpu+FqXcU7g8tjbIxzdDsN fiimp3ylKGsTuQ9PK2kHT+07+EiSPyJ59+0IR8jdT9vI1Zr8JF2qjBs/Z520fU/zeXS48osvM+pBN SDsUW15wLfzwLbTUFn3DzgGWNbsrEw11q5OVB0az0dQKisrTuFC5K7MU6z3C5f1WHOJbtp1JU6MPJ fvvv75FmBd844YAlfIpBKLYmIJ230lWgXo2geqUVX09yDVxZ6Xa0r6trzB5b4fv3ceWOgwdo+g2of QFaYqW/a9hDCLFnv0qbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htisZ-0005F4-5B; Sat, 03 Aug 2019 01:30:39 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1htisW-0005Eb-9C for linux-arm-kernel@lists.infradead.org; Sat, 03 Aug 2019 01:30:37 +0000 Received: by mail-wm1-x344.google.com with SMTP id s15so46577988wmj.3 for ; Fri, 02 Aug 2019 18:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ogf+QVoHZtK9iZfwgzb4P/UWGbW9VrBZvDIl55S3hPY=; b=KGkroKFjol78GrJj8Z3aHbKWLMrcSiwfex8ESVqf5pCyjcNBYG+ZPXlzN5iCRO4k4S j+kWSLfRx1gW9uTsbVilRV/mKw5vnJRnyRovCESrqPj485QPsEXeHmM1ohRfevsYjhl+ bVqgoWYlnrNbPYUfDRYgNeFptq0zUwF8iaVEaW6Y91hTzIKVEhttusPL7xNJjagJgfPx Qmm+hhLcyFpZUGNoAb7uaqmLy2yvIu/dqrpx4BAoA8q5ZPCHBLZqpQBELIiFi0jGG2Yl HbTxR+5W2mtoj7+ef493cG+HiMMsq/Ot47bUXyCg3DdLbc7lKcrFA4E477Jh3bin1LxM lI3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ogf+QVoHZtK9iZfwgzb4P/UWGbW9VrBZvDIl55S3hPY=; b=gUrq2l4mXQuogf41vwNQIgwqriyX9hRRYeB5ErxUmltOJbxHI6aJ8Wj2Jiho3pIS9s Z7uUjuPsj/qp/LI160BsUpwv/w8T+ciKifL2JDVyx18uUvfJecJ1CIjrWsnVDY5eNUFS 3BdcVuxuAHnVaFdRe9FE/2ipl3vQJfxo1c9HaUIneC+5QDYXXx3NJMCGLaRXYjI9nzUd mfCH/5r2kB/wdgT0PpL0Q44snlbeVQuErV2V1uZ7Upn2e4RCV/sGOO9XyylfvQ2mI4kn lGHuM746o007SEeQq2joxishZlX1GFrXnqH4pymucxfRP0mk67DcnOPyxM58We3f/Nyn Y/5g== X-Gm-Message-State: APjAAAUH2pIepz7M30yO+zfQhC//V+drpo+aBFIJ+fVdgS4oQHgCqEav t9O1qkbWIIgh7lODDPdcc9A= X-Google-Smtp-Source: APXvYqxqjFQJ9s+K2nHgDoEAg28+wlCsmvPhcNE3ueZNH5NsBPgHWuzjZM3lffnaX7s2DnS6f/1HMQ== X-Received: by 2002:a1c:e108:: with SMTP id y8mr6269283wmg.65.1564795833805; Fri, 02 Aug 2019 18:30:33 -0700 (PDT) Received: from archlinux-threadripper ([2a01:4f8:222:2f1b::2]) by smtp.gmail.com with ESMTPSA id c4sm62233010wrt.86.2019.08.02.18.30.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 02 Aug 2019 18:30:33 -0700 (PDT) Date: Fri, 2 Aug 2019 18:30:31 -0700 From: Nathan Chancellor To: David Miller Subject: Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Message-ID: <20190803013031.GA76252@archlinux-threadripper> References: <20190731.094150.851749535529247096.davem@davemloft.net> <20190731185023.20954-1-natechancellor@gmail.com> <20190802.181132.1425585873361511856.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190802.181132.1425585873361511856.davem@davemloft.net> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190802_183036_350053_422D33A8 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, andrew@lunn.ch, f.fainelli@gmail.com, lkp@intel.com, kernel-build-reports@lists.linaro.org, gregkh@linuxfoundation.org, rdunlap@infradead.org, willy@infradead.org, broonie@kernel.org, linux-next@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote: > From: Nathan Chancellor > Date: Wed, 31 Jul 2019 11:50:24 -0700 > > > arm allyesconfig warns: > > > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > > Selected by [y]: > > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && > > NETDEVICES [=y] || COMPILE_TEST [=y]) > > > > and errors: > > > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': > > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > > function 'writeq'; did you mean 'writeb'? > > The proper way to fix this is to include either > > linux/io-64-nonatomic-hi-lo.h > > or > > linux/io-64-nonatomic-lo-hi.h > > whichever is appropriate. Hmmmm, is that not what I did? Although I did not know about io-64-nonatomic-hi-lo.h. What is the difference and which one is needed here? There is apparently another failure when OF_MDIO is not set, I guess I can try to look into that as well and respin into a series if necessary. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel