From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 05 Aug 2019 10:35:04 +0000 Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Message-Id: <20190805103504.GE4739@dell> List-Id: References: <20190725143224.GB31803@ravnborg.org> <20190725143934.GH15868@phenom.ffwll.local> <20190725150629.GN23883@dell> <20190726160953.GA25708@ravnborg.org> In-Reply-To: <20190726160953.GA25708@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Sam Ravnborg Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Gerd Hoffmann , Jingoo Han , Peter Rosin On Fri, 26 Jul 2019, Sam Ravnborg wrote: > Hi Lee. > > On Thu, Jul 25, 2019 at 04:06:29PM +0100, Lee Jones wrote: > > On Thu, 25 Jul 2019, Daniel Vetter wrote: > > > > > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > > > This patch removes the support in backlight, > > > > and drop the notifier in fbmem. > > > > > > > > That EARLY_FB_BLANK is not used can be verified that no driver set any of: > > > > > > > > lcd_ops.early_set_power() > > > > lcd_ops.r_early_set_power() > > > > > > > > Noticed while browsing backlight code for other reasons. > > > > > > Ah I didn't grep hard enough, I didn't realize that no one sets the > > > lcd_ops->(r_)early_set_power hooks. Nice find! > > > > > > Reviewed-by: Daniel Vetter > > > > > > > Signed-off-by: Sam Ravnborg > > > > Cc: Lee Jones > > > > Cc: Daniel Thompson > > > > Cc: Jingoo Han > > > > Cc: Bartlomiej Zolnierkiewicz > > > > Cc: Daniel Vetter > > > > Cc: Sam Ravnborg > > > > Cc: Maarten Lankhorst > > > > Cc: "Michał Mirosław" > > > > Cc: Peter Rosin > > > > Cc: Gerd Hoffmann > > > > Cc: dri-devel@lists.freedesktop.org > > > > Cc: linux-fbdev@vger.kernel.org > > > > --- > > > > > > > > Build tested with various architectures, configs. > > > > > > > > Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is > > > > maintained today? > > > > > > backlight is separate from fbdev in Lee's own tree, not in drm-misc. I > > > think at least. > > > > That's correct. We'll sort that once we have all the Acks. > > We have acks all around now. I am still missing Daniel T's Ack. > OK that I commit this to drm-misc-next? > > This is where we maintain fbdev these days. Or you could apply it to > your backlight tree. > > Both solutins would be fine as the risk of introducing merge conflicts > in these code paths are minimal. If that's the case, then I'd be happy to apply it to the Backlight tree. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Date: Mon, 5 Aug 2019 11:35:04 +0100 Message-ID: <20190805103504.GE4739@dell> References: <20190725143224.GB31803@ravnborg.org> <20190725143934.GH15868@phenom.ffwll.local> <20190725150629.GN23883@dell> <20190726160953.GA25708@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0697E6E2B0 for ; Mon, 5 Aug 2019 10:35:08 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id g17so83868789wrr.5 for ; Mon, 05 Aug 2019 03:35:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190726160953.GA25708@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Gerd Hoffmann , Jingoo Han , Peter Rosin List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNiBKdWwgMjAxOSwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUuCj4gCj4g T24gVGh1LCBKdWwgMjUsIDIwMTkgYXQgMDQ6MDY6MjlQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gT24gVGh1LCAyNSBKdWwgMjAxOSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+IAo+ID4g PiBPbiBUaHUsIEp1bCAyNSwgMjAxOSBhdCAwNDozMjoyNFBNICswMjAwLCBTYW0gUmF2bmJvcmcg d3JvdGU6Cj4gPiA+ID4gVGhlcmUgd2FzIG5vIHVzZXJzIGxlZnQgLSBzbyBkcm9wIHRoZSBjb2Rl IHRvIHN1cHBvcnQgRUFSTFlfRkJfQkxBTksuCj4gPiA+ID4gVGhpcyBwYXRjaCByZW1vdmVzIHRo ZSBzdXBwb3J0IGluIGJhY2tsaWdodCwKPiA+ID4gPiBhbmQgZHJvcCB0aGUgbm90aWZpZXIgaW4g ZmJtZW0uCj4gPiA+ID4gCj4gPiA+ID4gVGhhdCBFQVJMWV9GQl9CTEFOSyBpcyBub3QgdXNlZCBj YW4gYmUgdmVyaWZpZWQgdGhhdCBubyBkcml2ZXIgc2V0IGFueSBvZjoKPiA+ID4gPiAKPiA+ID4g PiAgICAgbGNkX29wcy5lYXJseV9zZXRfcG93ZXIoKQo+ID4gPiA+ICAgICBsY2Rfb3BzLnJfZWFy bHlfc2V0X3Bvd2VyKCkKPiA+ID4gPiAKPiA+ID4gPiBOb3RpY2VkIHdoaWxlIGJyb3dzaW5nIGJh Y2tsaWdodCBjb2RlIGZvciBvdGhlciByZWFzb25zLgo+ID4gPiAKPiA+ID4gQWggSSBkaWRuJ3Qg Z3JlcCBoYXJkIGVub3VnaCwgSSBkaWRuJ3QgcmVhbGl6ZSB0aGF0IG5vIG9uZSBzZXRzIHRoZQo+ ID4gPiBsY2Rfb3BzLT4ocl8pZWFybHlfc2V0X3Bvd2VyIGhvb2tzLiBOaWNlIGZpbmQhCj4gPiA+ IAo+ID4gPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4KPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJv cmcub3JnPgo+ID4gPiA+IENjOiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4g PiA+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3JnPgo+ID4g PiA+IENjOiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KPiA+ID4gPiBDYzogQmFy dGxvbWllaiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVya2llQHNhbXN1bmcuY29tPgo+ID4gPiA+ IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gPiA+IENjOiBT YW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gPiA+ID4gQ2M6IE1hYXJ0ZW4gTGFua2hv cnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gQ2M6ICJNaWNo YcWCIE1pcm9zxYJhdyIgPG1pcnEtbGludXhAcmVyZS5xbXFtLnBsPgo+ID4gPiA+IENjOiBQZXRl ciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPgo+ID4gPiA+IENjOiBHZXJkIEhvZmZtYW5uIDxrcmF4 ZWxAcmVkaGF0LmNvbT4KPiA+ID4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+ID4gPiA+IENjOiBsaW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmcKPiA+ID4gPiAtLS0KPiA+ ID4gPiAKPiA+ID4gPiBCdWlsZCB0ZXN0ZWQgd2l0aCB2YXJpb3VzIGFyY2hpdGVjdHVyZXMsIGNv bmZpZ3MuCj4gPiA+ID4gCj4gPiA+ID4gTGVlLCBEYW5pZWwgLSBPSyB0byBjb21taXQgdG8gZHJt LW1pc2MtbmV4dCB3aGVyZSBmYmRldiBzdHVmZiBpcwo+ID4gPiA+IG1haW50YWluZWQgdG9kYXk/ Cj4gPiA+IAo+ID4gPiBiYWNrbGlnaHQgaXMgc2VwYXJhdGUgZnJvbSBmYmRldiBpbiBMZWUncyBv d24gdHJlZSwgbm90IGluIGRybS1taXNjLiBJCj4gPiA+IHRoaW5rIGF0IGxlYXN0Lgo+ID4gCj4g PiBUaGF0J3MgY29ycmVjdC4gIFdlJ2xsIHNvcnQgdGhhdCBvbmNlIHdlIGhhdmUgYWxsIHRoZSBB Y2tzLgo+IAo+IFdlIGhhdmUgYWNrcyBhbGwgYXJvdW5kIG5vdy4KCkkgYW0gc3RpbGwgbWlzc2lu ZyBEYW5pZWwgVCdzIEFjay4KCj4gT0sgdGhhdCBJIGNvbW1pdCB0aGlzIHRvIGRybS1taXNjLW5l eHQ/Cj4gCj4gVGhpcyBpcyB3aGVyZSB3ZSBtYWludGFpbiBmYmRldiB0aGVzZSBkYXlzLiBPciB5 b3UgY291bGQgYXBwbHkgaXQgdG8KPiB5b3VyIGJhY2tsaWdodCB0cmVlLgo+IAo+IEJvdGggc29s dXRpbnMgd291bGQgYmUgZmluZSBhcyB0aGUgcmlzayBvZiBpbnRyb2R1Y2luZyBtZXJnZSBjb25m bGljdHMKPiBpbiB0aGVzZSBjb2RlIHBhdGhzIGFyZSBtaW5pbWFsLgoKSWYgdGhhdCdzIHRoZSBj YXNlLCB0aGVuIEknZCBiZSBoYXBweSB0byBhcHBseSBpdCB0byB0aGUgQmFja2xpZ2h0CnRyZWUu CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVh ZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93 IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWw=