From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
Pascal van Leeuwen <pascalvanl@gmail.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware
Date: Mon, 5 Aug 2019 15:12:13 +0200 [thread overview]
Message-ID: <20190805131213.GM14470@kwain> (raw)
In-Reply-To: <MN2PR20MB2973ECE2AB0598E32E088EDECADA0@MN2PR20MB2973.namprd20.prod.outlook.com>
On Mon, Aug 05, 2019 at 01:02:08PM +0000, Pascal Van Leeuwen wrote:
> > From: Antoine Tenart <antoine.tenart@bootlin.com>
> >
> > Using this function that is designed to sleep with a delay of 0 and
> > designed to timeout with a value of 1 does not seem to follow what the
> > function is designed for :) It could work but I would suggest to keep
> > the polling as it is in the patch in this case.
> >
> Ok, will do. Does that mean that patch 4/4 is good as is?
> i.e. can I add an "Acked-by: Antoine Tenart" line when I resubmit?
Sure, the rest of the patch looked good and you can add:
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-08-05 13:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 15:29 [PATCHv3 0/4] crypto: inside-secure - broaden driver scope Pascal van Leeuwen
2019-07-31 15:29 ` [PATCHv3 1/4] crypto: inside-secure - make driver selectable for non-Marvell hardware Pascal van Leeuwen
2019-08-05 8:04 ` Antoine Tenart
2019-07-31 15:29 ` [PATCHv3 2/4] crypto: inside-secure - Remove redundant algo to engine mapping code Pascal van Leeuwen
2019-08-05 7:51 ` Antoine Tenart
2019-07-31 15:29 ` [PATCHv3 3/4] crypto: inside-secure - add support for PCI based FPGA development board Pascal van Leeuwen
2019-08-05 8:36 ` Antoine Tenart
2019-08-05 8:47 ` Pascal Van Leeuwen
2019-08-05 9:09 ` Antoine Tenart
2019-08-05 9:49 ` Pascal Van Leeuwen
2019-07-31 15:29 ` [PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware Pascal van Leeuwen
2019-08-05 9:07 ` Antoine Tenart
2019-08-05 9:48 ` Pascal Van Leeuwen
2019-08-05 9:54 ` Antoine Tenart
2019-08-05 10:12 ` Pascal Van Leeuwen
2019-08-05 12:43 ` Antoine Tenart
2019-08-05 13:02 ` Pascal Van Leeuwen
2019-08-05 13:12 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805131213.GM14470@kwain \
--to=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.