From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/6] iomap: copy the xfs writeback code to iomap.c
Date: Tue, 6 Aug 2019 07:33:39 +0200 [thread overview]
Message-ID: <20190806053339.GF13409@lst.de> (raw)
In-Reply-To: <CAHc6FU6Q5gz-i9DmdXEqNbc4f3=U7CKryb2+ETO1U1yR3r0hDg@mail.gmail.com>
Hi Andreas,
any chance you could trim your quote to the relevant parts?
On Sun, Aug 04, 2019 at 04:59:25PM +0200, Andreas Gruenbacher wrote:
> > + /*
> > + * File systems can perform actions at submit time and/or override
> > + * the end_io handler here for complex operations like copy on write
> > + * extent manipulation or unwritten extent conversions.
> > + */
> > + if (wpc->ops->submit_ioend)
> > + error = wpc->ops->submit_ioend(ioend, error);
>
> I think we only want to call submit_ioend here if error isn't set already.
No, we need to call it even with an error so that the file system can
override the bi_end_io handler, which bio_endio ends up calling even
for the error case.
Maybe the comment above could use an update to make that more clear.
next prev parent reply other threads:[~2019-08-06 5:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 1:17 [PATCH v4 0/6] iomap: lift the xfs writepage code into iomap Darrick J. Wong
2019-07-30 1:17 ` [PATCH 1/6] list.h: add list_pop and list_pop_entry helpers Darrick J. Wong
2019-07-30 1:17 ` Darrick J. Wong
2019-07-30 1:17 ` [PATCH 2/6] iomap: copy the xfs writeback code to iomap.c Darrick J. Wong
2019-08-04 14:59 ` Andreas Gruenbacher
2019-08-06 5:33 ` Christoph Hellwig [this message]
2019-08-05 12:31 ` Andreas Gruenbacher
2019-08-06 5:32 ` Christoph Hellwig
2019-07-30 1:17 ` [PATCH 3/6] iomap: add tracing for the address space operations Darrick J. Wong
2019-07-30 1:18 ` [PATCH 4/6] iomap: warn on inline maps in iomap_writepage_map Darrick J. Wong
2019-07-30 1:18 ` [PATCH 5/6] xfs: set IOMAP_F_NEW more carefully Darrick J. Wong
2019-07-30 1:18 ` [PATCH 6/6] iomap: zero newly allocated mapped blocks Darrick J. Wong
2019-07-30 14:48 ` [PATCH v4 0/6] iomap: lift the xfs writepage code into iomap Christoph Hellwig
2019-08-05 12:34 ` Andreas Gruenbacher
2019-08-16 6:52 ` Christoph Hellwig
2019-08-17 1:46 ` Darrick J. Wong
2019-08-17 8:25 ` Andreas Gruenbacher
2019-08-17 13:15 ` Damien Le Moal
2019-08-20 7:30 ` Christoph Hellwig
2019-09-01 7:34 ` Christoph Hellwig
2019-09-01 20:44 ` Darrick J. Wong
2019-09-02 17:16 ` Christoph Hellwig
2019-09-10 7:01 ` Christoph Hellwig
2019-09-10 21:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806053339.GF13409@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=agruenba@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.