From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C05C32751 for ; Wed, 7 Aug 2019 10:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B58021E6C for ; Wed, 7 Aug 2019 10:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729444AbfHGKFm convert rfc822-to-8bit (ORCPT ); Wed, 7 Aug 2019 06:05:42 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:41917 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728202AbfHGKFl (ORCPT ); Wed, 7 Aug 2019 06:05:41 -0400 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 689B1240002; Wed, 7 Aug 2019 10:05:38 +0000 (UTC) Date: Wed, 7 Aug 2019 12:05:37 +0200 From: Miquel Raynal To: shiva.linuxworks@gmail.com Cc: Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , Boris Brezillon , Marcel Ziswiler , Frieder Schrempf , Shivamurthy Shastri , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Jeff Kletsky , Chuanhong Guo , liaoweixiong Subject: Re: [PATCH 7/8] mtd: spinand: micron: Fix read failure in Micron M70A flashes Message-ID: <20190807120537.733b6e6d@xps13> In-Reply-To: <20190722055621.23526-8-sshivamurthy@micron.com> References: <20190722055621.23526-1-sshivamurthy@micron.com> <20190722055621.23526-8-sshivamurthy@micron.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shiva, shiva.linuxworks@gmail.com wrote on Mon, 22 Jul 2019 07:56:20 +0200: > From: Shivamurthy Shastri > > M70A series flashes by default enable continuous read feature (BIT0 in > configuration register). This feature will not expose the ECC to host > and causing read failure. This is not readable enough, can you rephrase? Besides that you can add my Reviewed-by: Miquel Raynal > > Signed-off-by: Shivamurthy Shastri > --- > drivers/mtd/nand/spi/micron.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mtd/nand/spi/micron.c b/drivers/mtd/nand/spi/micron.c > index 6fde93ec23a1..1e28ea3d1362 100644 > --- a/drivers/mtd/nand/spi/micron.c > +++ b/drivers/mtd/nand/spi/micron.c > @@ -127,6 +127,15 @@ static int micron_spinand_detect(struct spinand_device *spinand) > return 1; > } > > +static int micron_spinand_init(struct spinand_device *spinand) > +{ > + /* > + * Some of the Micron flashes enable this BIT by default, > + * and there is a chance of read failure due to this. > + */ > + return spinand_upd_cfg(spinand, CFG_QUAD_ENABLE, 0); > +} > + > static void micron_fixup_param_page(struct spinand_device *spinand, > struct nand_onfi_params *p) > { > @@ -150,6 +159,7 @@ static void micron_fixup_param_page(struct spinand_device *spinand, > > static const struct spinand_manufacturer_ops micron_spinand_manuf_ops = { > .detect = micron_spinand_detect, > + .init = micron_spinand_init, > .fixup_param_page = micron_fixup_param_page, > }; > Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CCAC32751 for ; Wed, 7 Aug 2019 10:06:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96CB221E6A for ; Wed, 7 Aug 2019 10:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V+KyKDky" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96CB221E6A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=663qmjYYJytBN5R2cLCRKIOQWUZgvbPxUGC5dGSyoQ8=; b=V+KyKDkyvCe4gD pzwJxEKSVlXR1II6IbLO/P6K1rsGKMs7mVikUsNpYiR8ynYRCEHmFnDJSBvCdKnlwAb2fZrA5TL96 IzapHQQTG99hZEfwrNBNOcqTtSyuwjOAXYI9GEIGKBGWO7tP3nm5csHlTz7WTIEUbWeWg4HB2T5H+ 3xgr8aq0WA78v5I4K124XSq2mM4bUArJ5DFvf5pKSexcJXpUYx/2T2PI1jG+lQx/q92yKYPDYX1QP M6wHhpiBk44ZAhLFFUO3FeY1abbAUtOGlTsQaRQjzIGch7Akb5pQT8c7C/4p1IiOUBs4dr99OIOyc wQNEya76kt/TAlVL5DkQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvIpE-0001c8-Oj; Wed, 07 Aug 2019 10:05:44 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvIpC-0001bf-3K for linux-mtd@lists.infradead.org; Wed, 07 Aug 2019 10:05:43 +0000 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 689B1240002; Wed, 7 Aug 2019 10:05:38 +0000 (UTC) Date: Wed, 7 Aug 2019 12:05:37 +0200 From: Miquel Raynal To: shiva.linuxworks@gmail.com Subject: Re: [PATCH 7/8] mtd: spinand: micron: Fix read failure in Micron M70A flashes Message-ID: <20190807120537.733b6e6d@xps13> In-Reply-To: <20190722055621.23526-8-sshivamurthy@micron.com> References: <20190722055621.23526-1-sshivamurthy@micron.com> <20190722055621.23526-8-sshivamurthy@micron.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_030542_301285_79FA8166 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chuanhong Guo , Vignesh Raghavendra , Boris Brezillon , Marcel Ziswiler , Richard Weinberger , linux-kernel@vger.kernel.org, Frieder Schrempf , liaoweixiong , Marek Vasut , linux-mtd@lists.infradead.org, Jeff Kletsky , Brian Norris , David Woodhouse , Shivamurthy Shastri Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgU2hpdmEsCgpzaGl2YS5saW51eHdvcmtzQGdtYWlsLmNvbSB3cm90ZSBvbiBNb24sIDIyIEp1 bCAyMDE5IDA3OjU2OjIwICswMjAwOgoKPiBGcm9tOiBTaGl2YW11cnRoeSBTaGFzdHJpIDxzc2hp dmFtdXJ0aHlAbWljcm9uLmNvbT4KPiAKPiBNNzBBIHNlcmllcyBmbGFzaGVzIGJ5IGRlZmF1bHQg ZW5hYmxlIGNvbnRpbnVvdXMgcmVhZCBmZWF0dXJlIChCSVQwIGluCj4gY29uZmlndXJhdGlvbiBy ZWdpc3RlcikuIFRoaXMgZmVhdHVyZSB3aWxsIG5vdCBleHBvc2UgdGhlIEVDQyB0byBob3N0Cj4g YW5kIGNhdXNpbmcgcmVhZCBmYWlsdXJlLgoKVGhpcyBpcyBub3QgcmVhZGFibGUgZW5vdWdoLCBj YW4geW91IHJlcGhyYXNlPyBCZXNpZGVzIHRoYXQgeW91IGNhbiBhZGQKbXkgCgpSZXZpZXdlZC1i eTogTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KCj4gCj4gU2lnbmVk LW9mZi1ieTogU2hpdmFtdXJ0aHkgU2hhc3RyaSA8c3NoaXZhbXVydGh5QG1pY3Jvbi5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvc3BpL21pY3Jvbi5jIHwgMTAgKysrKysrKysrKwo+ICAx IGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L210ZC9uYW5kL3NwaS9taWNyb24uYyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL21pY3Jvbi5jCj4g aW5kZXggNmZkZTkzZWMyM2ExLi4xZTI4ZWEzZDEzNjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9t dGQvbmFuZC9zcGkvbWljcm9uLmMKPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3NwaS9taWNyb24u Ywo+IEBAIC0xMjcsNiArMTI3LDE1IEBAIHN0YXRpYyBpbnQgbWljcm9uX3NwaW5hbmRfZGV0ZWN0 KHN0cnVjdCBzcGluYW5kX2RldmljZSAqc3BpbmFuZCkKPiAgCXJldHVybiAxOwo+ICB9Cj4gIAo+ ICtzdGF0aWMgaW50IG1pY3Jvbl9zcGluYW5kX2luaXQoc3RydWN0IHNwaW5hbmRfZGV2aWNlICpz cGluYW5kKQo+ICt7Cj4gKwkvKgo+ICsJICogU29tZSBvZiB0aGUgTWljcm9uIGZsYXNoZXMgZW5h YmxlIHRoaXMgQklUIGJ5IGRlZmF1bHQsCj4gKwkgKiBhbmQgdGhlcmUgaXMgYSBjaGFuY2Ugb2Yg cmVhZCBmYWlsdXJlIGR1ZSB0byB0aGlzLgo+ICsJICovCj4gKwlyZXR1cm4gc3BpbmFuZF91cGRf Y2ZnKHNwaW5hbmQsIENGR19RVUFEX0VOQUJMRSwgMCk7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lk IG1pY3Jvbl9maXh1cF9wYXJhbV9wYWdlKHN0cnVjdCBzcGluYW5kX2RldmljZSAqc3BpbmFuZCwK PiAgCQkJCSAgICBzdHJ1Y3QgbmFuZF9vbmZpX3BhcmFtcyAqcCkKPiAgewo+IEBAIC0xNTAsNiAr MTU5LDcgQEAgc3RhdGljIHZvaWQgbWljcm9uX2ZpeHVwX3BhcmFtX3BhZ2Uoc3RydWN0IHNwaW5h bmRfZGV2aWNlICpzcGluYW5kLAo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBzcGluYW5kX21h bnVmYWN0dXJlcl9vcHMgbWljcm9uX3NwaW5hbmRfbWFudWZfb3BzID0gewo+ICAJLmRldGVjdCA9 IG1pY3Jvbl9zcGluYW5kX2RldGVjdCwKPiArCS5pbml0ID0gbWljcm9uX3NwaW5hbmRfaW5pdCwK PiAgCS5maXh1cF9wYXJhbV9wYWdlID0gbWljcm9uX2ZpeHVwX3BhcmFtX3BhZ2UsCj4gIH07Cj4g IAoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K