From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3977C433FF for ; Wed, 7 Aug 2019 20:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA74021BF6 for ; Wed, 7 Aug 2019 20:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565209021; bh=9jrCLwX3LNqceRPrIp1jyjebmoHx3o9gZO1ZatQ4skM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=oDgIGsrflwEePKb8blNh1YZV2gXzLdwYj8SQEGs9i1j+zB53Z4lVcmaQikz4nYLgf XmLcoXpc8pYXl8irW+qbrR26j3tVdW0Ipmp38qNhsTeHV3ue8QqLQ0Tsk3PnO2LnqP W6+5/lAISBmbrm1ynqIQDbzxmm+qGxyBY6m3cUaY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389399AbfHGURA (ORCPT ); Wed, 7 Aug 2019 16:17:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:50316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387969AbfHGURA (ORCPT ); Wed, 7 Aug 2019 16:17:00 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EAC82199C; Wed, 7 Aug 2019 20:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565209019; bh=9jrCLwX3LNqceRPrIp1jyjebmoHx3o9gZO1ZatQ4skM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sEN1paERUMluEqczWXfNlPMKbSdmYQaq4T7rTni0CxSxEnrjjHKQ765sgQWu8A8s0 QKx24YVdqUtvGPcVbdAJxRFJMxYJyV6Ah+0UPLJtP5uaP8snDxXhkkuBKnRyRw75Aq iNGGe6IBLOd1dbfd+9eQdQKz0RAljH5GsNO+CLMo= Date: Wed, 7 Aug 2019 13:16:58 -0700 From: Andrew Morton To: Steven Price Cc: Mark Rutland , x86@kernel.org, Arnd Bergmann , Ard Biesheuvel , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org, "Liang, Kan" , "Kirill A. Shutemov" Subject: Re: [PATCH v10 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Message-Id: <20190807131658.08793793a97fa4310af4f495@linux-foundation.org> In-Reply-To: <066fa4ca-5a46-ba86-607f-9c3e16f79cde@arm.com> References: <20190731154603.41797-1-steven.price@arm.com> <20190731154603.41797-21-steven.price@arm.com> <20190806165823.3f735b45a7c4163aca20a767@linux-foundation.org> <066fa4ca-5a46-ba86-607f-9c3e16f79cde@arm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Aug 2019 13:58:21 +0100 Steven Price wrote: > > ./arch/x86/include/asm/pgtable_64_types.h:56:22: error: initializer element is not constant > > #define PTRS_PER_PGD 512 > > ^ > > This is very unhelpful of GCC - it's actually PTRS_PER_P4D which isn't > constant! Well. You had every right to assume that an all-caps macro is a compile-time constant. We are innocent victims of Kirill's c65e774fb3f6af2 ("x86/mm: Make PGDIR_SHIFT and PTRS_PER_P4D variable") which lazily converted these macros into runtime-only, under some Kconfig settings. It should have changed those macros into static inlined lower-case functions. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61666C32754 for ; Wed, 7 Aug 2019 20:17:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 371ED22305 for ; Wed, 7 Aug 2019 20:17:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kz016pLI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sEN1paER" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 371ED22305 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/UKx/O/JQ5WFeN4gAtgr+u78MwBnyCC7VDeTXb1c48Y=; b=kz016pLIyurn8B WrayfD9tsyjIk7Dp9dqq0pocw6razHUFaqp4kUBAb4uIGCqkU23QD1+eUSWEuqW9ygOPD8ENJrFNF 1Xy5JUtdwVjASQvMxEZhygYF5HvmsDsFjmwzdt3mKZ3iYY5bTqazNn5E9rmMLN1qUhI1xdysLb9Ut vEeyFuJPG5nbBkO4h07x/InA2T6OFK5Y+ASMvLekZGjR3ZypFYuXQm7QDdD5YeXCBp95GV9Fi0W92 lm5UXS5YmsS/+W5i3vE1Q5Le5PB+j5r1e/BSsO7YojwGzVVtm1FEu02a3cpyvwVdFQvhnZ9vwm0nt IEmQF6mrB1RGd8/3CGXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvSMo-0006NN-La; Wed, 07 Aug 2019 20:17:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvSMm-0006N6-GE for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2019 20:17:01 +0000 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EAC82199C; Wed, 7 Aug 2019 20:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565209019; bh=9jrCLwX3LNqceRPrIp1jyjebmoHx3o9gZO1ZatQ4skM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sEN1paERUMluEqczWXfNlPMKbSdmYQaq4T7rTni0CxSxEnrjjHKQ765sgQWu8A8s0 QKx24YVdqUtvGPcVbdAJxRFJMxYJyV6Ah+0UPLJtP5uaP8snDxXhkkuBKnRyRw75Aq iNGGe6IBLOd1dbfd+9eQdQKz0RAljH5GsNO+CLMo= Date: Wed, 7 Aug 2019 13:16:58 -0700 From: Andrew Morton To: Steven Price Subject: Re: [PATCH v10 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Message-Id: <20190807131658.08793793a97fa4310af4f495@linux-foundation.org> In-Reply-To: <066fa4ca-5a46-ba86-607f-9c3e16f79cde@arm.com> References: <20190731154603.41797-1-steven.price@arm.com> <20190731154603.41797-21-steven.price@arm.com> <20190806165823.3f735b45a7c4163aca20a767@linux-foundation.org> <066fa4ca-5a46-ba86-607f-9c3e16f79cde@arm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_131700_566535_A3215AD6 X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Dave Hansen , Arnd Bergmann , Ard Biesheuvel , Peter Zijlstra , Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , Ingo Molnar , Borislav Petkov , "Kirill A. Shutemov" , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org, "Liang, Kan" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 7 Aug 2019 13:58:21 +0100 Steven Price wrote: > > ./arch/x86/include/asm/pgtable_64_types.h:56:22: error: initializer element is not constant > > #define PTRS_PER_PGD 512 > > ^ > > This is very unhelpful of GCC - it's actually PTRS_PER_P4D which isn't > constant! Well. You had every right to assume that an all-caps macro is a compile-time constant. We are innocent victims of Kirill's c65e774fb3f6af2 ("x86/mm: Make PGDIR_SHIFT and PTRS_PER_P4D variable") which lazily converted these macros into runtime-only, under some Kconfig settings. It should have changed those macros into static inlined lower-case functions. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel