From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F507C0650F for ; Thu, 8 Aug 2019 08:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2168E21880 for ; Thu, 8 Aug 2019 08:24:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732008AbfHHIY5 (ORCPT ); Thu, 8 Aug 2019 04:24:57 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:47551 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731642AbfHHIY4 (ORCPT ); Thu, 8 Aug 2019 04:24:56 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hvdj5-0001DO-Uj; Thu, 08 Aug 2019 10:24:47 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hvdj2-000204-KL; Thu, 08 Aug 2019 10:24:44 +0200 Date: Thu, 8 Aug 2019 10:24:44 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Paul Cercueil Cc: Thierry Reding , Rob Herring , Mark Rutland , od@zcrc.me, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] pwm: jz4740: Remove unused devicetree compatible strings Message-ID: <20190808082444.y4pnl5gofmeftpe6@pengutronix.de> References: <20190607154410.10633-1-paul@crapouillou.net> <20190607154410.10633-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190607154410.10633-3-paul@crapouillou.net> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 07, 2019 at 05:44:06PM +0200, Paul Cercueil wrote: > Right now none of the Ingenic-based boards probe this driver from > devicetree. This driver defined three compatible strings for the exact > same behaviour. Before these strings are used, we can remove two of > them. > > Signed-off-by: Paul Cercueil No hard opinion on my side on this one. Keeping the unused compatibles around (maybe with a comment to prefer ingenic,jz4740-pwm) is what I would have done. If you're really sure nobody used the two removed ones this is fine. The binding already requests that ingenic,jz4740-pwm is to be used. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |