From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0E3C0650F for ; Thu, 8 Aug 2019 23:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49B7C216C8 for ; Thu, 8 Aug 2019 23:09:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dbDwiA4A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404533AbfHHXJH (ORCPT ); Thu, 8 Aug 2019 19:09:07 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43715 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404029AbfHHXJH (ORCPT ); Thu, 8 Aug 2019 19:09:07 -0400 Received: by mail-pl1-f194.google.com with SMTP id 4so37158120pld.10 for ; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=dbDwiA4Adn6NNb5EvA73thvbmUP2keuqre4+n/NxwEHqhexDztnDaNh7AsRSTZZe49 hYpD3IzLcNsObNJn7jV0JwQOyof3bHoudWE9xbxMphJZ3xC6+cAju3iiWanCTUgT+RRy 5BTDqjSStXzv50strdYe4GteQ70uxl48L/KiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=ajwAjaHy7C6k9QNVWIIewYnL6j0cfcOOiitsdsOp9maUd/7IicwqosZojq/e8Vz6NX jRoNKW/KoL3w2naqrpkGD5a7LgxLwqi8TBYvWcdtbzYpPhlCOHmPJGgCFSUPISG8VuEW 4NVguRARdBp+ta7Dvq42w9s6SQBkaTNuj1+FYikG/wgHPXTLND93Stp5ypbcZ+KSCFZ4 7KE5nYHuLrDrMvGitO44TBW3fjWjD/6uYVn8dYPUKSbyXPaJwAAOODgkvMzV50B0/pn2 yoM6ux41iAsvCQdiXlH3N6LLbox/FCae2flTiasKRbxzl/cQjL4WC45JQ/PaF7/s1oID LCBA== X-Gm-Message-State: APjAAAVkzkuO18/kRaGe3XT5NYx9lu7+7r6N6qKqC0f0Isq/Z6BmNFGs Z3Rf5Rm0fviCA7h/aY6/6gXP7Q== X-Google-Smtp-Source: APXvYqwRMwQCoIwwE1SVnXBBenp7lYzRwUiHs8nPiovNgZn+1R84ViErtlLi11BYuAEM5u5dpbcusw== X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr15179356ply.251.1565305746634; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o130sm157376311pfg.171.2019.08.08.16.09.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2019 16:09:05 -0700 (PDT) Date: Thu, 8 Aug 2019 16:09:04 -0700 From: Kees Cook To: Andrew Morton Cc: Andrey Konovalov , Will Deacon , Will Deacon , Vincenzo Frascino , Catalin Marinas , Mark Rutland , kvm@vger.kernel.org, Szabolcs Nagy , dri-devel@lists.freedesktop.org, Kostya Serebryany , Khalid Aziz , "open list:KERNEL SELFTEST FRAMEWORK" , Felix Kuehling , Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Linux ARM , Dave Martin , Evgeniy Stepanov , linux-media@vger.kernel.org, Kevin Brodsky , Ruben Ayrapetyan , Ramana Radhakrishnan , Alex Williamson , Mauro Carvalho Chehab , Dmitry Vyukov , Linux Memory Management List , Greg Kroah-Hartman , Yishai Hadas , LKML , Jens Wiklander , Lee Smith , Alexander Deucher , enh , Robin Murphy , Christian Koenig , Luc Van Oostenryck Subject: Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Message-ID: <201908081608.A4F6711@keescook> References: <20190724140212.qzvbcx5j2gi5lcoj@willie-the-truck> <20190724142059.GC21234@fuggles.cambridge.arm.com> <20190806171335.4dzjex5asoertaob@willie-the-truck> <201908081410.C16D2BD@keescook> <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Aug 08, 2019 at 03:33:00PM -0700, Andrew Morton wrote: > On Thu, 8 Aug 2019 14:12:19 -0700 Kees Cook wrote: > > > > The ones that are left are the mm ones: 4, 5, 6, 7 and 8. > > > > > > Andrew, could you take a look and give your Acked-by or pick them up directly? > > > > Given the subsystem Acks, it seems like 3-10 and 12 could all just go > > via Andrew? I hope he agrees. :) > > I'll grab everything that has not yet appeared in linux-next. If more > of these patches appear in linux-next I'll drop those as well. > > The review discussion against " [PATCH v19 02/15] arm64: Introduce > prctl() options to control the tagged user addresses ABI" has petered > out inconclusively. prctl() vs arch_prctl(). I've always disliked arch_prctl() existing at all. Given that tagging is likely to be a multi-architectural feature, it seems like the controls should live in prctl() to me. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214ADC32756 for ; Thu, 8 Aug 2019 23:09:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C503A2173E for ; Thu, 8 Aug 2019 23:09:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dbDwiA4A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C503A2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 536DF6B0007; Thu, 8 Aug 2019 19:09:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F0456B0008; Thu, 8 Aug 2019 19:09:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D61E6B000A; Thu, 8 Aug 2019 19:09:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by kanga.kvack.org (Postfix) with ESMTP id 064BF6B0007 for ; Thu, 8 Aug 2019 19:09:08 -0400 (EDT) Received: by mail-pl1-f199.google.com with SMTP id k9so56332399pls.13 for ; Thu, 08 Aug 2019 16:09:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:references:mime-version:content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=HO2880JA0kwnAJ4pBEp5pVzNStvGCMgnUgVmwiptl8CEqK+ZICrShQIXGlOzSduDb4 vYcUNdNuiQBB/8D2i0ZwZ8CzP9x7fJ2Q8XJJH44B+aNpuq+MKh1C47MHKRs67m2BNxJS yl4JN5VbgB2TfiGRRpnaMLjhn8x6f9QIgKDQTW8qoJ9X/LXZBIWN7IUMgJzmbZ4Z74Vd c/GFVBWUOgF2TSh02OGxDag7a2m3VX8zew/7yD/YD++gUtZu5IkXSUAxB6XqiaWELBzy wtfqeEziUJ2+WGWGn8uNkVOcTgZTaoaiA5jIS8SZx1f/A9p4y8BeTDUciWeLZSsNXeMH eyqA== X-Gm-Message-State: APjAAAXLf9Xw/2LhP1BYOJIsXZ8i+31m1JoFGz+p7i7+qRNanOJeomWF Kc8hd6lkhbPTK8vC0HlUSCWuwBnt0xIfwwyZEJ/bzfIC2Xwo5xgsfuGKqZ+5JMI2mQ16Yt5Cx1P qrXooFbW+JmDUs8BULy9nCXHYYz/GiBcqxBi95xqTq+gEr766jCm/8WY+3JDUwign0w== X-Received: by 2002:a17:902:24b:: with SMTP id 69mr15413860plc.250.1565305747658; Thu, 08 Aug 2019 16:09:07 -0700 (PDT) X-Received: by 2002:a17:902:24b:: with SMTP id 69mr15413816plc.250.1565305746894; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565305746; cv=none; d=google.com; s=arc-20160816; b=M15MlT08LpwOxiucVqZuVIuew+FDF9Y2y4jSgOE0yEAlFlqNttey1tKpkqWPPAFavk rCtPxZZ1DOjAxQaKV9EA8keUnZ7ws+vVC8EBOZT3LpVJJaLD0lsBD3VifylpEdriaplS NgKguzCJJvkhEvOWCasz6RUPL5pPuNKcYpdGCTw0g1bgJBOK6cEE1BKPi1V9zOsUSc8o YFp5Fmei2brOHZdT/Ddu3ZVD/vbjn7Id28VAQdUrUxDDlkVB8Jt/S7aL4T4HBQfVdVVq ZNei6oalDwUu8XbTLFQ27d0gvNvaQ7U+OyZ4dbgiabFgGNf70tnV+X5hLzAostx7Evg9 T7gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=xrq+AU1rVXQkAk9V6iZZky+Ksa15EQrh7DmulJEwnDbJbmr4gpZNYsJXEatidL/F57 8N29PGldT1mr8bURCUwh6iPwRETyfwN7+2cla6vkqSPECXGWV/DFHFH4u5k0kiB2AHf2 vN4Wyiaet5XS/dcQkZisi8kaBk7xm+67E1mED4VAV+ZCjEIzQfKscOvUnEfyU7UjufcV 3luS3NcY2KvoHuD6863iT2fD2OMnMeGAq2nBHVkSjLz5GY5/NvzuohaQdm9Hmgpu+Wws XwD6N9A0jmWaGLDH7XZyEIsVmlGdp7Knb9Ndi6Png8/DjVabzYWP8yJr3rhXJFLumt+/ kRZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dbDwiA4A; spf=pass (google.com: domain of keescook@chromium.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 101sor113683862plf.70.2019.08.08.16.09.06 for (Google Transport Security); Thu, 08 Aug 2019 16:09:06 -0700 (PDT) Received-SPF: pass (google.com: domain of keescook@chromium.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dbDwiA4A; spf=pass (google.com: domain of keescook@chromium.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=dbDwiA4Adn6NNb5EvA73thvbmUP2keuqre4+n/NxwEHqhexDztnDaNh7AsRSTZZe49 hYpD3IzLcNsObNJn7jV0JwQOyof3bHoudWE9xbxMphJZ3xC6+cAju3iiWanCTUgT+RRy 5BTDqjSStXzv50strdYe4GteQ70uxl48L/KiQ= X-Google-Smtp-Source: APXvYqwRMwQCoIwwE1SVnXBBenp7lYzRwUiHs8nPiovNgZn+1R84ViErtlLi11BYuAEM5u5dpbcusw== X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr15179356ply.251.1565305746634; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o130sm157376311pfg.171.2019.08.08.16.09.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2019 16:09:05 -0700 (PDT) Date: Thu, 8 Aug 2019 16:09:04 -0700 From: Kees Cook To: Andrew Morton Cc: Andrey Konovalov , Will Deacon , Will Deacon , Vincenzo Frascino , Catalin Marinas , Mark Rutland , kvm@vger.kernel.org, Szabolcs Nagy , dri-devel@lists.freedesktop.org, Kostya Serebryany , Khalid Aziz , "open list:KERNEL SELFTEST FRAMEWORK" , Felix Kuehling , Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Linux ARM , Dave Martin , Evgeniy Stepanov , linux-media@vger.kernel.org, Kevin Brodsky , Ruben Ayrapetyan , Ramana Radhakrishnan , Alex Williamson , Mauro Carvalho Chehab , Dmitry Vyukov , Linux Memory Management List , Greg Kroah-Hartman , Yishai Hadas , LKML , Jens Wiklander , Lee Smith , Alexander Deucher , enh , Robin Murphy , Christian Koenig , Luc Van Oostenryck Subject: Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Message-ID: <201908081608.A4F6711@keescook> References: <20190724140212.qzvbcx5j2gi5lcoj@willie-the-truck> <20190724142059.GC21234@fuggles.cambridge.arm.com> <20190806171335.4dzjex5asoertaob@willie-the-truck> <201908081410.C16D2BD@keescook> <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 08, 2019 at 03:33:00PM -0700, Andrew Morton wrote: > On Thu, 8 Aug 2019 14:12:19 -0700 Kees Cook wrote: > > > > The ones that are left are the mm ones: 4, 5, 6, 7 and 8. > > > > > > Andrew, could you take a look and give your Acked-by or pick them up directly? > > > > Given the subsystem Acks, it seems like 3-10 and 12 could all just go > > via Andrew? I hope he agrees. :) > > I'll grab everything that has not yet appeared in linux-next. If more > of these patches appear in linux-next I'll drop those as well. > > The review discussion against " [PATCH v19 02/15] arm64: Introduce > prctl() options to control the tagged user addresses ABI" has petered > out inconclusively. prctl() vs arch_prctl(). I've always disliked arch_prctl() existing at all. Given that tagging is likely to be a multi-architectural feature, it seems like the controls should live in prctl() to me. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93711C0650F for ; Thu, 8 Aug 2019 23:09:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6468E2173E for ; Thu, 8 Aug 2019 23:09:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E1DA+nRa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dbDwiA4A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6468E2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+UAA0ufmJaYUyfVYygW+h60TNqiNj9ws1CqUgbj+neM=; b=E1DA+nRaV/BzLu dyyRwTuFhrp5xi2MDVWzfbuZi8C1GHF8xmmD6dqYqwIZlDPWtQd/vU9dxX3QBag0NwQNab9SGoPkY fd2dt+P2niS9yubCsuoH1mz3vG9OMYWXiy8KV2qTjPY2oj/+P9T/SvXE6jCx0PuTPP2jHuVoSfb0Y 0sdvdZabHCgoWNPSvR3Fzvnsy/xQfIVltt3VIv47Vf647QgHAKFYEZ+949p8/nSqVDkGbe9GiAcbi w6wXzIJ42ArN3Q86cpLgwyLHkV2O14mJhgzc1yS3kJR0WUgVslX8mWTqfc5ZE48IXSL+qf4xTxk0h IwEplQ0s/xpzyKqVMgGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvrWy-00031e-R3; Thu, 08 Aug 2019 23:09:12 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvrWv-00030L-UR for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2019 23:09:10 +0000 Received: by mail-pl1-x644.google.com with SMTP id b3so44204902plr.4 for ; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=dbDwiA4Adn6NNb5EvA73thvbmUP2keuqre4+n/NxwEHqhexDztnDaNh7AsRSTZZe49 hYpD3IzLcNsObNJn7jV0JwQOyof3bHoudWE9xbxMphJZ3xC6+cAju3iiWanCTUgT+RRy 5BTDqjSStXzv50strdYe4GteQ70uxl48L/KiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=EA+HkDe7JncUtG4RSYto9ilb8q7q647RB82zfKjpYIqbZUf86PY3fPMWVqxAu3EmKf jaT3zSJqTvyABUyhJaTJE9RfY1vL4E5iTFzfVTROPYdhk25P/h0ga14SZT2ETbFfLSEv BOjR/L8dTsU20wdiWrnhZ1BM5HWYCmmfmtA80Z0voFJ6fOHJGFM/238wPnpkR9gwwqVH twppJGKpRWa8A1DBt83G+k5S40FOjDY6XYyAmezjW/6NbKzF6kgE6avYBJY8OIhmRFwh FMuXppnJhQD1Gdxemlcp44jQ+YH8vDPBxKXr/ZZnbfYNf3O0p7WBVIldrGiCguYR3HRA Sq+g== X-Gm-Message-State: APjAAAXtf2OBsoEKDB5j7BasG9VrXTIYkAcIfFwJVt4nYUoNrDBE/daw gJez1vS8gPiVXRmcT3T6CcojsQ== X-Google-Smtp-Source: APXvYqwRMwQCoIwwE1SVnXBBenp7lYzRwUiHs8nPiovNgZn+1R84ViErtlLi11BYuAEM5u5dpbcusw== X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr15179356ply.251.1565305746634; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o130sm157376311pfg.171.2019.08.08.16.09.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2019 16:09:05 -0700 (PDT) Date: Thu, 8 Aug 2019 16:09:04 -0700 From: Kees Cook To: Andrew Morton Subject: Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Message-ID: <201908081608.A4F6711@keescook> References: <20190724140212.qzvbcx5j2gi5lcoj@willie-the-truck> <20190724142059.GC21234@fuggles.cambridge.arm.com> <20190806171335.4dzjex5asoertaob@willie-the-truck> <201908081410.C16D2BD@keescook> <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_160909_984692_B72C2F97 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Christian Koenig , Szabolcs Nagy , Catalin Marinas , Will Deacon , dri-devel@lists.freedesktop.org, Kostya Serebryany , Khalid Aziz , Lee Smith , "open list:KERNEL SELFTEST FRAMEWORK" , Vincenzo Frascino , Will Deacon , Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Dmitry Vyukov , Dave Martin , Evgeniy Stepanov , linux-media@vger.kernel.org, Ruben Ayrapetyan , Andrey Konovalov , Kevin Brodsky , Alex Williamson , Mauro Carvalho Chehab , Linux ARM , Linux Memory Management List , Greg Kroah-Hartman , Felix Kuehling , LKML , Jens Wiklander , Ramana Radhakrishnan , Alexander Deucher , enh , Robin Murphy , Yishai Hadas , Luc Van Oostenryck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 08, 2019 at 03:33:00PM -0700, Andrew Morton wrote: > On Thu, 8 Aug 2019 14:12:19 -0700 Kees Cook wrote: > > > > The ones that are left are the mm ones: 4, 5, 6, 7 and 8. > > > > > > Andrew, could you take a look and give your Acked-by or pick them up directly? > > > > Given the subsystem Acks, it seems like 3-10 and 12 could all just go > > via Andrew? I hope he agrees. :) > > I'll grab everything that has not yet appeared in linux-next. If more > of these patches appear in linux-next I'll drop those as well. > > The review discussion against " [PATCH v19 02/15] arm64: Introduce > prctl() options to control the tagged user addresses ABI" has petered > out inconclusively. prctl() vs arch_prctl(). I've always disliked arch_prctl() existing at all. Given that tagging is likely to be a multi-architectural feature, it seems like the controls should live in prctl() to me. -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Date: Thu, 8 Aug 2019 16:09:04 -0700 Message-ID: <201908081608.A4F6711@keescook> References: <20190724140212.qzvbcx5j2gi5lcoj@willie-the-truck> <20190724142059.GC21234@fuggles.cambridge.arm.com> <20190806171335.4dzjex5asoertaob@willie-the-truck> <201908081410.C16D2BD@keescook> <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Andrey Konovalov , Will Deacon , Will Deacon , Vincenzo Frascino , Catalin Marinas , Mark Rutland , kvm@vger.kernel.org, Szabolcs Nagy , dri-devel@lists.freedesktop.org, Kostya Serebryany , Khalid Aziz , "open list:KERNEL SELFTEST FRAMEWORK" , Felix Kuehling , Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Linux ARM List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 08, 2019 at 03:33:00PM -0700, Andrew Morton wrote: > On Thu, 8 Aug 2019 14:12:19 -0700 Kees Cook wrote: > > > > The ones that are left are the mm ones: 4, 5, 6, 7 and 8. > > > > > > Andrew, could you take a look and give your Acked-by or pick them up directly? > > > > Given the subsystem Acks, it seems like 3-10 and 12 could all just go > > via Andrew? I hope he agrees. :) > > I'll grab everything that has not yet appeared in linux-next. If more > of these patches appear in linux-next I'll drop those as well. > > The review discussion against " [PATCH v19 02/15] arm64: Introduce > prctl() options to control the tagged user addresses ABI" has petered > out inconclusively. prctl() vs arch_prctl(). I've always disliked arch_prctl() existing at all. Given that tagging is likely to be a multi-architectural feature, it seems like the controls should live in prctl() to me. -- Kees Cook