Hi Olga,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nfsd/nfsd-next]
[cannot apply to v5.3-rc3 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/server-side-support-for-inter-SSC-copy/20190811-120551
base:   git://linux-nfs.org/~bfields/linux.git nfsd-next
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from fs/nfsd/nfsctl.c:23:0:
   fs/nfsd/nfsd.h:391:16: warning: 'struct nfs42_netaddr' declared inside parameter list will not be visible outside of this definition or declaration
            struct nfs42_netaddr *netaddr)
                   ^~~~~~~~~~~~~
   fs/nfsd/nfsd.h: In function 'nfsd4_set_netaddr':
   fs/nfsd/nfsd.h:401:18: error: dereferencing pointer to incomplete type 'struct nfs42_netaddr'
      sprintf(netaddr->netid, "tcp");
                     ^~
   In file included from fs/nfsd/pnfs.h:10:0,
                    from fs/nfsd/nfsctl.c:27:
   fs/nfsd/xdr4.h: At top level:
>> fs/nfsd/xdr4.h:527:20: error: field 'cp_src' has incomplete type
     struct nl4_server cp_src;
                       ^~~~~~
--
   In file included from fs/nfsd/state.h:42:0,
                    from fs/nfsd/xdr4.h:40,
                    from fs/nfsd/nfs4xdr.c:47:
   fs/nfsd/nfsd.h:391:16: warning: 'struct nfs42_netaddr' declared inside parameter list will not be visible outside of this definition or declaration
            struct nfs42_netaddr *netaddr)
                   ^~~~~~~~~~~~~
   fs/nfsd/nfsd.h: In function 'nfsd4_set_netaddr':
   fs/nfsd/nfsd.h:401:18: error: dereferencing pointer to incomplete type 'struct nfs42_netaddr'
      sprintf(netaddr->netid, "tcp");
                     ^~
   In file included from fs/nfsd/nfs4xdr.c:47:0:
   fs/nfsd/xdr4.h: At top level:
>> fs/nfsd/xdr4.h:527:20: error: field 'cp_src' has incomplete type
     struct nl4_server cp_src;
                       ^~~~~~
   fs/nfsd/nfs4xdr.c: In function 'nfsd4_decode_nl4_server':
>> fs/nfsd/nfs4xdr.c:1743:4: error: dereferencing pointer to incomplete type 'struct nl4_server'
     ns->nl4_type = be32_to_cpup(p++);
       ^~
>> fs/nfsd/nfs4xdr.c:1747:7: error: 'NL4_NETADDR' undeclared (first use in this function); did you mean 'RTM_GETADDR'?
     case NL4_NETADDR:
          ^~~~~~~~~~~
          RTM_GETADDR
   fs/nfsd/nfs4xdr.c:1747:7: note: each undeclared identifier is reported only once for each function it appears in
>> fs/nfsd/nfs4xdr.c:1751:8: error: dereferencing pointer to incomplete type 'struct nfs42_netaddr'
      naddr->netid_len = be32_to_cpup(p++);
           ^~
   fs/nfsd/nfs4xdr.c: In function 'nfsd4_decode_copy':
>> fs/nfsd/nfs4xdr.c:1804:28: error: invalid application of 'sizeof' to incomplete type 'struct nl4_server'
     ns_dummy = kmalloc(sizeof(struct nl4_server), GFP_KERNEL);
                               ^~~~~~

vim +/cp_src +527 fs/nfsd/xdr4.h

   519	
   520	struct nfsd4_copy {
   521		/* request */
   522		stateid_t		cp_src_stateid;
   523		stateid_t		cp_dst_stateid;
   524		u64			cp_src_pos;
   525		u64			cp_dst_pos;
   526		u64			cp_count;
 > 527		struct nl4_server	cp_src;
   528		bool			cp_intra;
   529	
   530		/* both */
   531		bool		cp_synchronous;
   532	
   533		/* response */
   534		struct nfsd42_write_res	cp_res;
   535	
   536		/* for cb_offload */
   537		struct nfsd4_callback	cp_cb;
   538		__be32			nfserr;
   539		struct knfsd_fh		fh;
   540	
   541		struct nfs4_client      *cp_clp;
   542	
   543		struct file             *file_src;
   544		struct file             *file_dst;
   545	
   546		stateid_t		cp_stateid;
   547	
   548		struct list_head	copies;
   549		struct task_struct	*copy_task;
   550		refcount_t		refcount;
   551		bool			stopped;
   552	};
   553	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation