From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B40CAC31E40 for ; Mon, 12 Aug 2019 20:01:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7751E206C1 for ; Mon, 12 Aug 2019 20:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T+ABqL6c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbfHLUBl (ORCPT ); Mon, 12 Aug 2019 16:01:41 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:41740 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfHLUBk (ORCPT ); Mon, 12 Aug 2019 16:01:40 -0400 Received: by mail-qk1-f194.google.com with SMTP id g17so7239917qkk.8 for ; Mon, 12 Aug 2019 13:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mzJd9LfyI6OyvkYy9nxABgF/o+uPg/L4uhRhKYYKXK8=; b=T+ABqL6cQJgPOi3/KuUg8dw9+u7TLkZl7ie+BEbOpts6p3A3W9mVODE3y46Nqai7kR X/Y8oXA6FHUXaU21ggo2fHUEnuLty4utTuLosncCtowhrw421B8HtDtcDNedK5VJw8WB CQoecsb0gLNIGPdcpTDScYJ8D/QGb34a380s3+/5r482y8yLTaGd81SuOLMnBErDd0lq w2RybkThge83juCWZ0bWRj7Wn3+CMhUQWzFGmDjj7kM0pA7ENhgnqUxs39oUbhqAYfXn coZLZzzxxGqqjw+5LEXeD+qn/tpmYXrP9UTfyDJjgRRPGvPNmfqmxkeUTvKVddz/vGNA uHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mzJd9LfyI6OyvkYy9nxABgF/o+uPg/L4uhRhKYYKXK8=; b=l6bPVhFUrxwFY6PlxOlcdO4/D1JdvFetETt1KD88HWUEIts/wkj3xWo94XAumtyoQS zf7OvNh9pVEB7YeQil8xwPpchuxwqWx1La3s6Ws6JCx4+aUFG7C9GmuOMCP6EQ2n3tAQ woWyBzTOggGVu5ehoqYC4Bj2dI8CWbk5t1SNM3RcUhBgCxC+7920vXmluc/5nOH/ViRW DYUujAYQdyEdvdPdBDiV1A7Id7g8TvOJz6LXZ6wxShNcS9QitvyVtXOAhnx2/P/c9/4s WRcoMYtlGfDv/NY4yQP/fFFEqYBA8qMOeCV+St0qZfXiEwR0f2JV6TQKt4DNf9V7gvwk jNSw== X-Gm-Message-State: APjAAAX/WE3sEPxOxtQO3TF6WpkOoBePCezcthAM/Ce1nM4hVn4h97l+ yRJXx1SA8iFz7YuOwmwI/aM= X-Google-Smtp-Source: APXvYqy5EUKQpFOfiq5JMIN+wnSVRvYvH6S2RbGmJ5VoQBUBEx4uyhTG//pEJ9deZvUF58j6IEtE3w== X-Received: by 2002:ae9:f801:: with SMTP id x1mr28277094qkh.242.1565640099542; Mon, 12 Aug 2019 13:01:39 -0700 (PDT) Received: from quaco.ghostprotocols.net (187-26-98-68.3g.claro.net.br. [187.26.98.68]) by smtp.gmail.com with ESMTPSA id f22sm5634753qkh.55.2019.08.12.13.01.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 13:01:38 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D585740340; Mon, 12 Aug 2019 17:01:34 -0300 (-03) Date: Mon, 12 Aug 2019 17:01:34 -0300 To: Igor Lubashev Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Alexey Budankov , Peter Zijlstra , Ingo Molnar , Mathieu Poirier , Alexander Shishkin , Namhyung Kim , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, James Morris Subject: Re: [PATCH v3 2/4] perf: Use CAP_SYS_ADMIN with perf_event_paranoid checks Message-ID: <20190812200134.GE9280@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Aug 07, 2019 at 10:44:15AM -0400, Igor Lubashev escreveu: > +++ b/tools/perf/util/evsel.c > @@ -279,7 +279,7 @@ struct evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx) > static bool perf_event_can_profile_kernel(void) > { > - return geteuid() == 0 || perf_event_paranoid() == -1; > + return perf_event_paranoid_check(-1); > } While looking at your changes I think the pre-existing code is wrong, i.e. the check in sys_perf_event_open(), in the kernel is: if (!attr.exclude_kernel) { if (perf_paranoid_kernel() && !capable(CAP_SYS_ADMIN)) return -EACCES; } And: static inline bool perf_paranoid_kernel(void) { return sysctl_perf_event_paranoid > 1; } So we have to change that perf_event_paranoit_check(-1) to pass 1 instead? bool perf_event_paranoid_check(int max_level) { return perf_cap__capable(CAP_SYS_ADMIN) || perf_event_paranoid() <= max_level; } Also you defined perf_cap__capable(anything) as: #ifdef HAVE_LIBCAP_SUPPORT #include bool perf_cap__capable(cap_value_t cap); #else static inline bool perf_cap__capable(int cap __maybe_unused) { return false; } #endif /* HAVE_LIBCAP_SUPPORT */ I think we should have: #else static inline bool perf_cap__capable(int cap __maybe_unused) { return geteuid() == 0; } #endif /* HAVE_LIBCAP_SUPPORT */ Right? So I am removing the introduction of perf_cap__capable() from the first patch you sent, leaving it with _only_ the feature detection part, using that feature detection to do anything is then moved to a separate patch, after we finish this discussion about what we should fallback to when libcap-devel isn't available, i.e. we should use the previous checks, etc. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD6A7C32750 for ; Mon, 12 Aug 2019 20:01:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C7F2206C1 for ; Mon, 12 Aug 2019 20:01:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k9/n4wE4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="e/jOHcUE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C7F2206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3laKRtq0C7UCzIi7mRbzsSkjuX0xW7neZ1nWqOXploA=; b=k9/n4wE4KlnIBo /vjwdMEmP0yusAZe+KFwuqZC/g8wUqrOSY37eRDfWsYN7CDq4ixl42INkG2I1aojC3UZqC+2IEHBJ O0LcIUXxeMeW59XifF5/Asdr97R/SC6inzyCoNtBuNZnBWc8mM/gKeiC2XdPPXznnH5wZEDCPtxCN IZM4mCc57jFPM2BgMT+FP0d4IN9tcipeuGDa7GFla/WgUQsongyitGNVU9QvuqN6yGK6ywYmDO7+W 2tE+jV18mT8Vg0+RxQBjMB5oqGOr0y1mnL9MfSzTFb4QDw9eCr2iQ14SCJgjEUxOPrbGGxtXjgNdS quZ9AqyDhwIvURQypMsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxGVj-0006wn-6b; Mon, 12 Aug 2019 20:01:43 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxGVh-0006wf-Ky for linux-arm-kernel@bombadil.infradead.org; Mon, 12 Aug 2019 20:01:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mzJd9LfyI6OyvkYy9nxABgF/o+uPg/L4uhRhKYYKXK8=; b=e/jOHcUEEcQBgPHdUtMXcYRoz 1zPkiL0qQ/of1HyHPJVxhnKid8ngwJquo4GSqJAF5h++hrKGsM7UDCp8nldRhpvRHSXwsoyAZ2Xpk 0fP2QZxkYYf1oRByRvlY/eOZzz1KmeKouFK0jnjeGR2+x+uOMWBiwFFg5RnN1h+KPbuLTwo6tgYam Jc8qrnNqhRClFwmXoKCRjLBndwEKi2169q4JblCafRPZR4k1KI8wIfhU3vMg7sO3YByd9XyAgqlFa ouXSyp23eLGuLKa8ARpSIgy0ijIQyWppvGlOu8Z8MkLi6IcC7hm/r7t1qWpCae50oqIfmHD3fzvDZ rBpfVOsKg==; Received: from 187-26-98-68.3g.claro.net.br ([187.26.98.68] helo=quaco.ghostprotocols.net) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hxGVf-0004IL-J3; Mon, 12 Aug 2019 20:01:39 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D585740340; Mon, 12 Aug 2019 17:01:34 -0300 (-03) Date: Mon, 12 Aug 2019 17:01:34 -0300 From: Arnaldo Carvalho de Melo To: Igor Lubashev Subject: Re: [PATCH v3 2/4] perf: Use CAP_SYS_ADMIN with perf_event_paranoid checks Message-ID: <20190812200134.GE9280@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.0 (2019-05-25) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Suzuki K Poulose , Peter Zijlstra , Alexey Budankov , linux-kernel@vger.kernel.org, James Morris , Alexander Shishkin , Ingo Molnar , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Aug 07, 2019 at 10:44:15AM -0400, Igor Lubashev escreveu: > +++ b/tools/perf/util/evsel.c > @@ -279,7 +279,7 @@ struct evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx) > static bool perf_event_can_profile_kernel(void) > { > - return geteuid() == 0 || perf_event_paranoid() == -1; > + return perf_event_paranoid_check(-1); > } While looking at your changes I think the pre-existing code is wrong, i.e. the check in sys_perf_event_open(), in the kernel is: if (!attr.exclude_kernel) { if (perf_paranoid_kernel() && !capable(CAP_SYS_ADMIN)) return -EACCES; } And: static inline bool perf_paranoid_kernel(void) { return sysctl_perf_event_paranoid > 1; } So we have to change that perf_event_paranoit_check(-1) to pass 1 instead? bool perf_event_paranoid_check(int max_level) { return perf_cap__capable(CAP_SYS_ADMIN) || perf_event_paranoid() <= max_level; } Also you defined perf_cap__capable(anything) as: #ifdef HAVE_LIBCAP_SUPPORT #include bool perf_cap__capable(cap_value_t cap); #else static inline bool perf_cap__capable(int cap __maybe_unused) { return false; } #endif /* HAVE_LIBCAP_SUPPORT */ I think we should have: #else static inline bool perf_cap__capable(int cap __maybe_unused) { return geteuid() == 0; } #endif /* HAVE_LIBCAP_SUPPORT */ Right? So I am removing the introduction of perf_cap__capable() from the first patch you sent, leaving it with _only_ the feature detection part, using that feature detection to do anything is then moved to a separate patch, after we finish this discussion about what we should fallback to when libcap-devel isn't available, i.e. we should use the previous checks, etc. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel