From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B62C31E40 for ; Mon, 12 Aug 2019 20:22:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BA7D206C2 for ; Mon, 12 Aug 2019 20:22:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ml/MGLzQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727535AbfHLUW5 (ORCPT ); Mon, 12 Aug 2019 16:22:57 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:33819 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbfHLUW5 (ORCPT ); Mon, 12 Aug 2019 16:22:57 -0400 Received: by mail-qk1-f193.google.com with SMTP id m10so2794857qkk.1 for ; Mon, 12 Aug 2019 13:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x36Zdhrbd36jlNpMgEK+It3M4pd2ku8s6wizrey81eQ=; b=ml/MGLzQ5saV9X1B44nl9UwnQZ9ePQjJ8hTKCvSAhp7c6bcvdAh4OZe95ApTh9vegf 7U0AP+JImas6NgvsFmb6eC9h0TGpUAsYpfb8e2mRNXJljiCH2SWbb/LcjVadT/cMwmGK BW6iDS4c1Svm/aK4Tvl1sG5vHQloq3RuJJyVTlFZBDE+NkxNNbGBElrinkOXRp4TqABb vUtgb14z9/9t/d39khykbMvzJNav11a4+QLlZsesEtYbCyowq5jpfqHcR+MysIDMeSOO WmI9ass4AE8MEdKxp06RwJ5GbBjPBIn0PKyaI13Nc27NInqRoVosQ1aROr7YbO5b6F/k xiKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x36Zdhrbd36jlNpMgEK+It3M4pd2ku8s6wizrey81eQ=; b=T7n/GCtDB+ojloufRJZTKQnSkxke75d0o4JNCWinXR7tvyu5P0lTM4Mf/3msxQmvqm P5UeD5FKfZ68IhzgkLqknkSB1GySr3IqFHXpZqZWtamSLCyrPyOIyrSJAcXZwqAjMQWM 7xatdzJjlr+NV2IaoqNcxGl9Nllk7vxQ1sFXTNX+H+XWlsSMaf+5ZFIdlgjrhO6Z4Z5N KKXffn8bwEqdpLGRf79x9z06eOZrrgFVejgwV2s5XhBSFkv3qLaBdvZ9R9wF2qDlqWwk rGJf5Ut9iJUYjjJaB24710H6pATJefCp1TxM8nlH/zKow92ieEWMSLuOVFQQd/4ZOtZd 2kBw== X-Gm-Message-State: APjAAAXikv0OIvo8QJwRHLlSo+tZ56U5C/ikd99IDFeiXwdAEYhdHzyl +7IXq9BKS+sg9wobBDw3L3g= X-Google-Smtp-Source: APXvYqzgbzL5Mm5f07CLUKO1VvXHfZiq1D0qFMkqcfETjVjkbGxvLhwlN5nG0T0ITiIdLeWHJugQKw== X-Received: by 2002:ae9:d606:: with SMTP id r6mr30567211qkk.364.1565641375989; Mon, 12 Aug 2019 13:22:55 -0700 (PDT) Received: from quaco.ghostprotocols.net (187-26-98-68.3g.claro.net.br. [187.26.98.68]) by smtp.gmail.com with ESMTPSA id p32sm54442466qtb.67.2019.08.12.13.22.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 13:22:54 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3F25040340; Mon, 12 Aug 2019 17:22:51 -0300 (-03) Date: Mon, 12 Aug 2019 17:22:51 -0300 To: Igor Lubashev Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Alexey Budankov , Peter Zijlstra , Ingo Molnar , Mathieu Poirier , Alexander Shishkin , Namhyung Kim , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, James Morris Subject: Re: [PATCH v3 4/4] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Message-ID: <20190812202251.GG9280@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Aug 07, 2019 at 10:44:17AM -0400, Igor Lubashev escreveu: > Kernel requires CAP_SYS_ADMIN instead of euid==0 to mount debugfs for ftrace. > Make perf do the same. > > Signed-off-by: Igor Lubashev > --- > tools/perf/builtin-ftrace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > index ae1466aa3b26..d09eac8a6d57 100644 > --- a/tools/perf/builtin-ftrace.c > +++ b/tools/perf/builtin-ftrace.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include "debug.h" > #include > @@ -21,6 +22,7 @@ > #include "target.h" > #include "cpumap.h" > #include "thread_map.h" > +#include "util/cap.h" > #include "util/config.h" > > > @@ -281,7 +283,7 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > .events = POLLIN, > }; > > - if (geteuid() != 0) { > + if (!perf_cap__capable(CAP_SYS_ADMIN)) { > pr_err("ftrace only works for root!\n"); I guess we should update the error message too? > return -1; > } > -- > 2.7.4 -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3B3C433FF for ; Mon, 12 Aug 2019 20:23:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BF30206C2 for ; Mon, 12 Aug 2019 20:23:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pjArH8HX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BF30206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=To7jeo98XYxkmJ0ugLO46lGkpXnFZcYGCUwyGdGvXyE=; b=pjArH8HXy3UuII h0ttMC5VQeizsOBFmnmUoB3VccMCK/mpcyk7rDY5aWVsS5rmhiRfQrxzyQc+J35M15pFYpNGwONOM 38d8ZPnyXBbrYRjRxVfAiU4LgJKtg7WkrTQDLEVyoVun3bzApZAfw7i6/rCw9shwC8QK37MvX02LD Mf0aPPpEyr9a73wGzvsB1RZrACHkD0hpqmBdCHwZLHhqOz9nbvol/QjRNgvd/QjmFZToCl3vfz1da uUt11s0HkZQR4SuLb9lc0Segm/65tkATnR9obLe8PbPCstNl0uFYjZuAyrlNKkArQZVns0iCGxaB8 R1+dnEDpbfeB6cjB3v0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxGqH-0005W9-33; Mon, 12 Aug 2019 20:22:57 +0000 Received: from 187-26-98-68.3g.claro.net.br ([187.26.98.68] helo=quaco.ghostprotocols.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hxGqD-0005Vr-AL; Mon, 12 Aug 2019 20:22:53 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3F25040340; Mon, 12 Aug 2019 17:22:51 -0300 (-03) Date: Mon, 12 Aug 2019 17:22:51 -0300 From: Arnaldo Carvalho de Melo To: Igor Lubashev Subject: Re: [PATCH v3 4/4] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Message-ID: <20190812202251.GG9280@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.0 (2019-05-25) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Suzuki K Poulose , Peter Zijlstra , Alexey Budankov , linux-kernel@vger.kernel.org, James Morris , Alexander Shishkin , Ingo Molnar , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Aug 07, 2019 at 10:44:17AM -0400, Igor Lubashev escreveu: > Kernel requires CAP_SYS_ADMIN instead of euid==0 to mount debugfs for ftrace. > Make perf do the same. > > Signed-off-by: Igor Lubashev > --- > tools/perf/builtin-ftrace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > index ae1466aa3b26..d09eac8a6d57 100644 > --- a/tools/perf/builtin-ftrace.c > +++ b/tools/perf/builtin-ftrace.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include "debug.h" > #include > @@ -21,6 +22,7 @@ > #include "target.h" > #include "cpumap.h" > #include "thread_map.h" > +#include "util/cap.h" > #include "util/config.h" > > > @@ -281,7 +283,7 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > .events = POLLIN, > }; > > - if (geteuid() != 0) { > + if (!perf_cap__capable(CAP_SYS_ADMIN)) { > pr_err("ftrace only works for root!\n"); I guess we should update the error message too? > return -1; > } > -- > 2.7.4 -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel