From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CAFC31E40 for ; Mon, 12 Aug 2019 20:27:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48CCB206C2 for ; Mon, 12 Aug 2019 20:27:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bbz8xNwS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727526AbfHLU1M (ORCPT ); Mon, 12 Aug 2019 16:27:12 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:45419 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbfHLU1L (ORCPT ); Mon, 12 Aug 2019 16:27:11 -0400 Received: by mail-qk1-f196.google.com with SMTP id m2so4146949qki.12 for ; Mon, 12 Aug 2019 13:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9zeU09HvL8h4sQQ/WE4AQZf/AMEHoTVJyw4VstGuzg0=; b=bbz8xNwSmE0ajseU9lAnpKEuAIcEunhMu4RccUlNeUCFdhCL9MFdQ/KaQFJ/9JP+Ef K49I5xb4koGhAod6mCKlHr4At6WEmrK1SZkSzJQndo85oyyDkBr0+KtAQUBR8HJYpcST JTv5eI4q8DNxOZTus2sj4XKqXAsRKagTdM0I/HcLNGRzaMeoB/1C0qpNwsbtqyAfSuvD mI0ln3TjFFG9sR8nn3/x673FV5RdNdFhGXDS82l4+eIBeECJtK50cqMmHAOIDOwlHzTQ FScL9xCuWs4QJHn+R3El0eqm2cejEYwIL5fwxXdZ00zCmJlIevsbFysi6MOFL965x6wd POQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9zeU09HvL8h4sQQ/WE4AQZf/AMEHoTVJyw4VstGuzg0=; b=I7J3xJemrtrKSat+3XV6KOv9fr87YzV+ii8hx7SYwlGwLFJpb5d9A5kUvEKyyhwf0m EeND1ZtRvkGEC34hOnuzKZbXyz5MUJ3Lnu2I5KPMwBpcJJq4NfSZ3cSOn8hFrb3hPNie Ho/NpttAI5rMJtX7lO/GCIJjT4HcKHvuFIv2yAHu+/MMx0/mJI54e9jxq4U404HNsjwY mObsJ0B0oHTdIHwHsZvrXEQAlp31qfi68JNKskTitNnzx9U8j4rWLUgG6/9VUzHeamOf hC7ArDK9JPgsMy+XIUPTYBXIy/xulter99aq6tGkTd4Vyd7EFjpWR5B80zA6QHmRHTOq vC5Q== X-Gm-Message-State: APjAAAVSV6uDrmqyjR+RlH2S0Lr52mafy6srjL9God4WN854QIY9+Mio qY4FdhSUOdWLjw1R98tgJtQ= X-Google-Smtp-Source: APXvYqxtGY6lLemTlys1bRmIOk/IUxz9wbXRq/fv3QDB1ZrLtFk/1sLAFxqz6JTiOmiRoJgeGESzeQ== X-Received: by 2002:a37:d245:: with SMTP id f66mr30971706qkj.59.1565641630935; Mon, 12 Aug 2019 13:27:10 -0700 (PDT) Received: from quaco.ghostprotocols.net (187-26-98-68.3g.claro.net.br. [187.26.98.68]) by smtp.gmail.com with ESMTPSA id t5sm2359942qkt.93.2019.08.12.13.27.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 13:27:10 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 70EC640340; Mon, 12 Aug 2019 17:27:06 -0300 (-03) Date: Mon, 12 Aug 2019 17:27:06 -0300 To: Igor Lubashev Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Alexey Budankov , Peter Zijlstra , Ingo Molnar , Mathieu Poirier , Alexander Shishkin , Namhyung Kim , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, James Morris Subject: Re: [PATCH v3 4/4] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Message-ID: <20190812202706.GH9280@kernel.org> References: <20190812202251.GG9280@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812202251.GG9280@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Aug 12, 2019 at 05:22:51PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 07, 2019 at 10:44:17AM -0400, Igor Lubashev escreveu: > > Kernel requires CAP_SYS_ADMIN instead of euid==0 to mount debugfs for ftrace. > > Make perf do the same. > > > > Signed-off-by: Igor Lubashev > > --- > > tools/perf/builtin-ftrace.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > > index ae1466aa3b26..d09eac8a6d57 100644 > > --- a/tools/perf/builtin-ftrace.c > > +++ b/tools/perf/builtin-ftrace.c > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "debug.h" > > #include > > @@ -21,6 +22,7 @@ > > #include "target.h" > > #include "cpumap.h" > > #include "thread_map.h" > > +#include "util/cap.h" > > #include "util/config.h" > > > > > > @@ -281,7 +283,7 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > .events = POLLIN, > > }; > > > > - if (geteuid() != 0) { > > + if (!perf_cap__capable(CAP_SYS_ADMIN)) { > > pr_err("ftrace only works for root!\n"); > > I guess we should update the error message too? > I.e. I applied this as a follow up patch: diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index 01a5bb58eb04..ba8b65c2f9dc 100644 --- a/tools/perf/builtin-ftrace.c +++ b/tools/perf/builtin-ftrace.c @@ -284,7 +284,12 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) }; if (!perf_cap__capable(CAP_SYS_ADMIN)) { - pr_err("ftrace only works for root!\n"); + pr_err("ftrace only works for %s!\n", +#ifdef HAVE_LIBCAP_SUPPORT + "users with the SYS_ADMIN capability" +#else + "root" +#endif return -1; } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379F4C433FF for ; Mon, 12 Aug 2019 20:27:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBABA206C2 for ; Mon, 12 Aug 2019 20:27:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k7TVsl8H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBABA206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RdHagazJUgfiskG1ULpxcjiNod8qryYnQq5vvdyApTU=; b=k7TVsl8H8nLp6u E8ssSrCJSJ+Yx7vlU8c0Mw1OmUPrrfPdy8Q6T20qjeYRGgDWngvqR8N3Mir+rPUg3r6kcndFKaghE 9ifqNE+IrbKBAYgzvQiFl6d2/hs8VRyROKJBo+d5PMi2gMhrlt0T0gcIxGbEGl1vs4wQ4n9oPK+7x +fh58ccrPFVZIKEqJdMAUrSoU+8E1Ox3RWgAMofo8iamF/Zw3UVUv6oif1Y2h/aCcURgYgRPeJKUI ROI2aRhuSOHxZPjtjJz6va02BspGFkLIbPD+bj12wwrdJtQln4ZkjrlCrTdd2385Cuk+ALCKyxFWD ZTUp5SAj+P8tb1ZzyzXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxGuN-0007FM-NQ; Mon, 12 Aug 2019 20:27:11 +0000 Received: from 187-26-98-68.3g.claro.net.br ([187.26.98.68] helo=quaco.ghostprotocols.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hxGuL-0007FB-Ko; Mon, 12 Aug 2019 20:27:10 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 70EC640340; Mon, 12 Aug 2019 17:27:06 -0300 (-03) Date: Mon, 12 Aug 2019 17:27:06 -0300 From: Arnaldo Carvalho de Melo To: Igor Lubashev Subject: Re: [PATCH v3 4/4] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Message-ID: <20190812202706.GH9280@kernel.org> References: <20190812202251.GG9280@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190812202251.GG9280@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.0 (2019-05-25) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Suzuki K Poulose , Peter Zijlstra , Alexey Budankov , linux-kernel@vger.kernel.org, James Morris , Alexander Shishkin , Ingo Molnar , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Aug 12, 2019 at 05:22:51PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 07, 2019 at 10:44:17AM -0400, Igor Lubashev escreveu: > > Kernel requires CAP_SYS_ADMIN instead of euid==0 to mount debugfs for ftrace. > > Make perf do the same. > > > > Signed-off-by: Igor Lubashev > > --- > > tools/perf/builtin-ftrace.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > > index ae1466aa3b26..d09eac8a6d57 100644 > > --- a/tools/perf/builtin-ftrace.c > > +++ b/tools/perf/builtin-ftrace.c > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "debug.h" > > #include > > @@ -21,6 +22,7 @@ > > #include "target.h" > > #include "cpumap.h" > > #include "thread_map.h" > > +#include "util/cap.h" > > #include "util/config.h" > > > > > > @@ -281,7 +283,7 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > .events = POLLIN, > > }; > > > > - if (geteuid() != 0) { > > + if (!perf_cap__capable(CAP_SYS_ADMIN)) { > > pr_err("ftrace only works for root!\n"); > > I guess we should update the error message too? > I.e. I applied this as a follow up patch: diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index 01a5bb58eb04..ba8b65c2f9dc 100644 --- a/tools/perf/builtin-ftrace.c +++ b/tools/perf/builtin-ftrace.c @@ -284,7 +284,12 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) }; if (!perf_cap__capable(CAP_SYS_ADMIN)) { - pr_err("ftrace only works for root!\n"); + pr_err("ftrace only works for %s!\n", +#ifdef HAVE_LIBCAP_SUPPORT + "users with the SYS_ADMIN capability" +#else + "root" +#endif return -1; } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel