All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serge Semin <fancer.lancer@gmail.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Paul Burton <paul.burton@mips.com>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"yasha.che3@gmail.com" <yasha.che3@gmail.com>,
	"aurelien@aurel32.net" <aurelien@aurel32.net>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	"matt.redfearn@mips.com" <matt.redfearn@mips.com>,
	"chenhc@lemote.com" <chenhc@lemote.com>
Subject: Re: [EXTERNAL]Drop boot_mem_map
Date: Tue, 13 Aug 2019 11:39:54 +0300	[thread overview]
Message-ID: <20190813083952.gg533rwix5ciclwc@mobilestation> (raw)
In-Reply-To: <ac8efbfe-be18-ca91-2060-2a8c601cbbd1@flygoat.com>

Hello Jiaxun,

On Mon, Aug 12, 2019 at 01:28:19PM +0800, Jiaxun Yang wrote:
> 
> On 2019/8/12 下午12:56, Paul Burton wrote:
> > Hi Jiaxun,
> > 
> > On Thu, Aug 08, 2019 at 03:50:06PM +0800, Jiaxun Yang wrote:
> > > Hi there:
> > > I was trying to make a generic NUMA implementation for ip27 and loongson-3,
> > > and the boot_mem_map without nid support become a barrier of merging memory
> > > init code.
> > > 
> > > Rather than add nid support to boot_mem_map, this patchset drops the whole
> > > boot_mem_map as it can be replaced by memblock functions.
> > Very nice - cleaning this up will be a neat improvement :)
> > 
> > Am I right to suspect though that patch 1 will break the build for all
> > platforms that make use of boot_mem_map? (ie. all the platforms touched
> > by later patches in this series)
> 
> Yes. Rest of the set should fixed all the platforms.
> 
> You can verify by grep boot_mem_map tree-wide.
> 
> --
> 
> Jiaxun Yang
> 

The cleanup you did is great! I was going to do this myself when get to have
more free time. Thanks to you the only thing left is to review your work.

Regarding the Paul' comment about the platforms source code buildability in
patch 1. Alas it's a kernel patches requirement to leave the source code
buildable and the kernel runnable after each patch [1].

I am not sure about correct execution, but at least buildability can be reached
just by moving the patch 1 to the tail of the series.

Regarding the patches itself, I'll leave my comments inline within the
corresponding emails.

[1] https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L223

  reply	other threads:[~2019-08-13  8:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08  7:50 Drop boot_mem_map Jiaxun Yang
2019-08-08  7:50 ` [PATCH 1/7] MIPS: init: " Jiaxun Yang
2019-08-14 11:54   ` Serge Semin
2019-08-14 13:40     ` Jiaxun Yang
2019-08-08  7:50 ` [PATCH 2/7] MIPS: OCTEON: " Jiaxun Yang
2019-08-08  7:50 ` [PATCH 3/7] MIPS: fw: Record prom memory Jiaxun Yang
2019-08-14 12:03   ` Serge Semin
2019-08-14 12:50     ` Thomas Bogendoerfer
2019-08-14 13:45     ` Jiaxun Yang
2019-08-08  7:50 ` [PATCH 4/7] MIPS: malta: Drop prom_free_prom_memory Jiaxun Yang
2019-08-08  7:50 ` [PATCH 5/7] MIPS: msp: Record prom memory Jiaxun Yang
2019-08-14 12:12   ` Serge Semin
2019-08-08  7:50 ` [PATCH 6/7] MIPS: ip22: Drop addr_is_ram Jiaxun Yang
2019-08-08  7:50 ` [PATCH 7/7] MIPS: xlp: Drop boot_mem_map Jiaxun Yang
2019-08-12  4:56 ` [EXTERNAL]Drop boot_mem_map Paul Burton
2019-08-12  5:28   ` Jiaxun Yang
2019-08-13  8:39     ` Serge Semin [this message]
2019-08-13 15:09       ` Jiaxun Yang
2019-08-19 14:23 ` [PATCH v1 0/8] MIPS: Drop boot_mem_map Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 1/8] MIPS: OCTEON: " Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 2/8] MIPS: fw: Record prom memory Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 3/8] MIPS: malta: Drop prom_free_prom_memory Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 4/8] MIPS: msp: Record prom memory Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 5/8] MIPS: ip22: Drop addr_is_ram Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 6/8] MIPS: xlp: Drop boot_mem_map Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 7/8] MIPS: mm: " Jiaxun Yang
2019-08-19 14:23   ` [PATCH v1 8/8] MIPS: init: " Jiaxun Yang
2019-08-23 14:45   ` [PATCH v1 0/8] MIPS: " Paul Burton
2019-08-23 17:20     ` Jiaxun Yang
2019-08-23 17:36       ` Jiaxun Yang
2019-08-23 18:05     ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190813083952.gg533rwix5ciclwc@mobilestation \
    --to=fancer.lancer@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=chenhc@lemote.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=matt.redfearn@mips.com \
    --cc=paul.burton@mips.com \
    --cc=sfr@canb.auug.org.au \
    --cc=yasha.che3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.