All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	bgoswami@codeaurora.org, plai@codeaurora.org,
	lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, spapothi@codeaurora.org
Subject: Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()
Date: Wed, 14 Aug 2019 09:41:42 +0530	[thread overview]
Message-ID: <20190814041142.GU12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20190813195804.GL5093@sirena.co.uk>

On 13-08-19, 20:58, Mark Brown wrote:
> On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre-Louis Bossart wrote:
> 
> > Indeed. I don't have a full understanding of that part to be honest, nor why
> > we need something SoundWire-specific. We already abused the set_tdm_slot API
> > to store an HDaudio stream, now we have a rather confusing stream
> > information for SoundWire and I have about 3 other 'stream' contexts in
> > SOF... I am still doing basic cleanups but this has been on my radar for a
> > while.
> 
> There is something to be said for not abusing the TDM slot API if it can
> make things clearer by using bus-idiomatic mechanisms, but it does mean
> everything needs to know about each individual bus :/ .

Here ASoC doesn't need to know about sdw bus. As Srini explained, this
helps in the case for him to get the stream context and set the stream
context from the machine driver.

Nothing else is expected to be done from this API. We already do a set
using snd_soc_dai_set_sdw_stream(). Here we add the snd_soc_dai_get_sdw_stream() to query

Thanks
-- 
~Vinod

  reply	other threads:[~2019-08-14  4:12 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  8:35 [PATCH v2 0/5] soundwire: Add support to Qualcomm SoundWire master Srinivas Kandagatla
2019-08-13  8:35 ` [PATCH v2 1/5] soundwire: Add compute_params callback Srinivas Kandagatla
2019-08-13 14:34   ` Pierre-Louis Bossart
2019-08-13 18:17     ` Srinivas Kandagatla
2019-08-13 19:08       ` Pierre-Louis Bossart
2019-08-14  4:05         ` Vinod Koul
2019-09-04  9:28   ` Vinod Koul
2019-09-04  9:28     ` [alsa-devel] " Vinod Koul
2019-09-04 13:36     ` Pierre-Louis Bossart
2019-09-04 13:36       ` Pierre-Louis Bossart
2019-08-13  8:35 ` [PATCH v2 2/5] soundwire: stream: make stream name a const pointer Srinivas Kandagatla
2019-09-04  9:29   ` Vinod Koul
2019-09-04  9:29     ` [alsa-devel] " Vinod Koul
2019-08-13  8:35 ` [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() Srinivas Kandagatla
2019-08-13 14:44   ` [alsa-devel] " Pierre-Louis Bossart
2019-08-13 16:50     ` Srinivas Kandagatla
2019-08-13 17:51       ` Pierre-Louis Bossart
2019-08-13 18:06         ` Srinivas Kandagatla
2019-08-13 19:15           ` Pierre-Louis Bossart
2019-08-13 19:18             ` Mark Brown
2019-08-13 19:38               ` Pierre-Louis Bossart
2019-08-13 19:58                 ` Mark Brown
2019-08-14  4:11                   ` Vinod Koul [this message]
2019-08-14  9:08                     ` Mark Brown
2019-08-14 14:09                     ` Pierre-Louis Bossart
2019-10-09  8:32                       ` Srinivas Kandagatla
2019-10-09  8:32                         ` Srinivas Kandagatla
2019-10-09 14:29                         ` Pierre-Louis Bossart
2019-10-09 14:29                           ` Pierre-Louis Bossart
2019-10-09 14:29                           ` Pierre-Louis Bossart
2019-10-09 16:01                           ` Srinivas Kandagatla
2019-10-09 16:01                             ` Srinivas Kandagatla
2019-10-09 16:01                             ` Srinivas Kandagatla
2019-10-09 18:53                             ` Pierre-Louis Bossart
2019-10-09 18:53                               ` Pierre-Louis Bossart
2019-10-10  8:50                               ` Srinivas Kandagatla
2019-10-10  8:50                                 ` Srinivas Kandagatla
2019-10-10 12:03                                 ` Charles Keepax
2019-10-10 12:03                                   ` Charles Keepax
2019-10-10 12:03                                   ` Charles Keepax
2019-10-10 13:51                                   ` Mark Brown
2019-10-10 13:51                                     ` Mark Brown
2019-10-10 14:01                                   ` Pierre-Louis Bossart
2019-10-10 14:01                                     ` Pierre-Louis Bossart
2019-10-10 14:52                                     ` Srinivas Kandagatla
2019-10-10 14:52                                       ` Srinivas Kandagatla
2019-10-10 15:49                                       ` Pierre-Louis Bossart
2019-10-10 15:49                                         ` Pierre-Louis Bossart
2019-10-11 12:30                                         ` Srinivas Kandagatla
2019-10-11 12:30                                           ` Srinivas Kandagatla
2019-08-13 16:03   ` Cezary Rojewski
2019-08-13 16:52     ` Srinivas Kandagatla
2019-08-13 17:29       ` Cezary Rojewski
2019-08-13 19:19         ` Mark Brown
2019-08-13  8:35 ` [PATCH v2 4/5] dt-bindings: soundwire: add bindings for Qcom controller Srinivas Kandagatla
2019-08-23  7:28   ` Vinod Koul
2019-08-30  8:05     ` Srinivas Kandagatla
2019-08-30  8:05       ` [alsa-devel] " Srinivas Kandagatla
2019-08-13  8:35 ` [PATCH v2 5/5] soundwire: qcom: add support for SoundWire controller Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814041142.GU12733@vkoul-mobl.Dlink \
    --to=vkoul@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=plai@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=spapothi@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.