From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE5FC0650F for ; Wed, 14 Aug 2019 06:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1EB32133F for ; Wed, 14 Aug 2019 06:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727363AbfHNGQa (ORCPT ); Wed, 14 Aug 2019 02:16:30 -0400 Received: from mga06.intel.com ([134.134.136.31]:54436 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfHNGQa (ORCPT ); Wed, 14 Aug 2019 02:16:30 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 23:16:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,384,1559545200"; d="scan'208";a="167287654" Received: from buildpc-hp-z230.iind.intel.com (HELO buildpc-HP-Z230) ([10.223.89.34]) by orsmga007.jf.intel.com with ESMTP; 13 Aug 2019 23:16:25 -0700 Date: Wed, 14 Aug 2019 11:48:28 +0530 From: Sanyog Kale To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com Subject: Re: [alsa-devel] [PATCH v2 0/3] soundwire: debugfs support for 5.4 Message-ID: <20190814061827.GA21043@buildpc-HP-Z230> References: <20190812235942.7120-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812235942.7120-1-pierre-louis.bossart@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 12, 2019 at 06:59:39PM -0500, Pierre-Louis Bossart wrote: > This patchset enables debugfs support and corrects all the feedback > provided on an earlier RFC ('soundwire: updates for 5.4') > > There is one remaining hard-coded value in intel.c that will need to > be fixed in a follow-up patchset not specific to debugfs: we need to > remove hard-coded Intel-specific configurations from cadence_master.c > (PDI offsets, etc). > > Changes since v1 (Feedback from GKH) > Handle debugfs in a more self-contained way (no dentry as return or parameter) > Used CONFIG_DEBUG_FS in structures and code to make it easier to > remove if need be. > No functional change for register dumps. > > Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog): > removed error checks > used DEFINE_SHOW_ATTRIBUTE and seq_file > fixed copyright dates > fixed SPDX license info to use GPL2.0 only > fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected > used static inlines for fallback compilation > removed intermediate variables > removed hard-coded constants in loops (used registers offsets and > hardware capabilities) > squashed patch 3 > Changes looks good to me. Acked-by: Sanyog Kale > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --