All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Keeping <john@metanate.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org, John Keeping <john@metanate.com>
Subject: [PATCH v2 1/3] perf map: use zalloc for map_groups
Date: Thu, 15 Aug 2019 11:01:44 +0100	[thread overview]
Message-ID: <20190815100146.28842-1-john@metanate.com> (raw)
In-Reply-To: <20190804124434.204da4ac.john@metanate.com>

In the next commit we will add new fields to map_groups and we need
these to be null if no value is assigned.  The simplest way to achieve
this is to request zeroed memory from the allocator.

Signed-off-by: John Keeping <john@metanate.com>
---
Unchanged in v2
---
 tools/perf/util/map.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 668410b1d426..44b556812e4b 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -636,7 +636,7 @@ bool map_groups__empty(struct map_groups *mg)
 
 struct map_groups *map_groups__new(struct machine *machine)
 {
-	struct map_groups *mg = malloc(sizeof(*mg));
+	struct map_groups *mg = zalloc(sizeof(*mg));
 
 	if (mg != NULL)
 		map_groups__init(mg, machine);
-- 
2.22.0


  reply	other threads:[~2019-08-15 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 17:24 [PATCH 1/2] perf map: use zalloc for map_groups John Keeping
2019-07-29 17:24 ` [PATCH 2/2] perf unwind: fix libunwind when tid != pid John Keeping
2019-08-02 13:30   ` Jiri Olsa
2019-08-04 11:44     ` John Keeping
2019-08-15 10:01       ` John Keeping [this message]
2019-08-15 10:01         ` [PATCH v2 2/3] " John Keeping
2019-08-15 14:10           ` Jiri Olsa
2019-08-16 15:30             ` Arnaldo Carvalho de Melo
2019-08-16 21:00           ` [tip:perf/core] perf unwind: Fix " tip-bot for John Keeping
2019-08-15 10:01         ` [PATCH v2 3/3] perf unwind: remove unnecessary test John Keeping
2019-08-16 21:01           ` [tip:perf/core] perf unwind: Remove " tip-bot for John Keeping
2019-08-16 20:59         ` [tip:perf/core] perf map: Use zalloc for map_groups tip-bot for John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190815100146.28842-1-john@metanate.com \
    --to=john@metanate.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.